From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Gwendal Grignou <gwendal@chromium.org>,
briannorris@chromium.org, jic23@kernel.org, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, lee.jones@linaro.org,
bleung@chromium.org, dianders@chromium.org, groeck@chromium.org,
fabien.lahoudere@collabora.com, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
Dmitry Torokhov <dtor@google.com>
Subject: Re: [PATCH v4 08/17] Revert "Input: cros_ec_keyb: mask out extra flags in event_type"
Date: Mon, 11 Nov 2019 11:23:49 -0800 [thread overview]
Message-ID: <20191111192349.GE57214@dtor-ws> (raw)
In-Reply-To: <b8abe5c0-991f-5ba2-daf9-de3e011e60fe@collabora.com>
On Mon, Nov 11, 2019 at 10:20:41AM +0100, Enric Balletbo i Serra wrote:
> Hi,
>
> cc'in Dmitry and linux-input list which is missing
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> On 5/11/19 23:26, Gwendal Grignou wrote:
> > This reverts commit d096aa3eb6045a6a475a0239f3471c59eedf3d61.
> >
> > This patch is not needed anymore since we clear EC_MKBP_HAS_MORE_EVENTS
> > flag before calling the notifiers in patch
> > "9d9518f5b52a (platform: chrome: cros_ec: handle MKBP more events flag)"
> >
> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> > ---
> > No changes in v4, v3.
> > New to v2.
> >
> > drivers/input/keyboard/cros_ec_keyb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> > index a29e81fdf186..2b71c5a51f90 100644
> > --- a/drivers/input/keyboard/cros_ec_keyb.c
> > +++ b/drivers/input/keyboard/cros_ec_keyb.c
> > @@ -237,7 +237,7 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
> > if (queued_during_suspend && !device_may_wakeup(ckdev->dev))
> > return NOTIFY_OK;
> >
> > - switch (ckdev->ec->event_data.event_type & EC_MKBP_EVENT_TYPE_MASK) {
> > + switch (ckdev->ec->event_data.event_type) {
> > case EC_MKBP_EVENT_KEY_MATRIX:
> > pm_wakeup_event(ckdev->dev, 0);
> >
> >
--
Dmitry
prev parent reply other threads:[~2019-11-11 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191105222652.70226-1-gwendal@chromium.org>
[not found] ` <20191105222652.70226-8-gwendal@chromium.org>
2019-11-11 9:20 ` [PATCH v4 07/17] Revert "Input: cros_ec_keyb - add back missing mask for event_type" Enric Balletbo i Serra
2019-11-11 19:23 ` Dmitry Torokhov
[not found] ` <20191105222652.70226-9-gwendal@chromium.org>
2019-11-11 9:20 ` [PATCH v4 08/17] Revert "Input: cros_ec_keyb: mask out extra flags in event_type" Enric Balletbo i Serra
2019-11-11 19:23 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111192349.GE57214@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=fabien.lahoudere@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).