* [PATCH] Input: alps - Remove unnecessary unlikely
@ 2019-10-12 8:36 zhengbin
2019-11-13 3:11 ` zhengbin (A)
0 siblings, 1 reply; 3+ messages in thread
From: zhengbin @ 2019-10-12 8:36 UTC (permalink / raw)
To: pali.rohar, dmitry.torokhov, linux-input; +Cc: zhengbin13
IS_ERR_OR_NULL already contains unlikely, there is no need
for another one.
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/input/mouse/alps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index 34700ed..ed16614 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -1476,7 +1476,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse,
/* On V2 devices the DualPoint Stick reports bare packets */
dev = priv->dev2;
dev2 = psmouse->dev;
- } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) {
+ } else if (IS_ERR_OR_NULL(priv->dev3)) {
/* Register dev3 mouse if we received PS/2 packet first time */
if (!IS_ERR(priv->dev3))
psmouse_queue_work(psmouse, &priv->dev3_register_work,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: alps - Remove unnecessary unlikely
2019-10-12 8:36 [PATCH] Input: alps - Remove unnecessary unlikely zhengbin
@ 2019-11-13 3:11 ` zhengbin (A)
2019-11-13 8:05 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: zhengbin (A) @ 2019-11-13 3:11 UTC (permalink / raw)
To: pali.rohar, dmitry.torokhov, linux-input
ping
On 2019/10/12 16:36, zhengbin wrote:
> IS_ERR_OR_NULL already contains unlikely, there is no need
> for another one.
>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> drivers/input/mouse/alps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 34700ed..ed16614 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -1476,7 +1476,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse,
> /* On V2 devices the DualPoint Stick reports bare packets */
> dev = priv->dev2;
> dev2 = psmouse->dev;
> - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) {
> + } else if (IS_ERR_OR_NULL(priv->dev3)) {
> /* Register dev3 mouse if we received PS/2 packet first time */
> if (!IS_ERR(priv->dev3))
> psmouse_queue_work(psmouse, &priv->dev3_register_work,
> --
> 2.7.4
>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: alps - Remove unnecessary unlikely
2019-11-13 3:11 ` zhengbin (A)
@ 2019-11-13 8:05 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2019-11-13 8:05 UTC (permalink / raw)
To: zhengbin (A); +Cc: pali.rohar, linux-input
On Wed, Nov 13, 2019 at 11:11:04AM +0800, zhengbin (A) wrote:
> ping
No, the preference is to keep the code here as is, thank you.
>
> On 2019/10/12 16:36, zhengbin wrote:
> > IS_ERR_OR_NULL already contains unlikely, there is no need
> > for another one.
> >
> > Signed-off-by: zhengbin <zhengbin13@huawei.com>
> > ---
> > drivers/input/mouse/alps.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> > index 34700ed..ed16614 100644
> > --- a/drivers/input/mouse/alps.c
> > +++ b/drivers/input/mouse/alps.c
> > @@ -1476,7 +1476,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse,
> > /* On V2 devices the DualPoint Stick reports bare packets */
> > dev = priv->dev2;
> > dev2 = psmouse->dev;
> > - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) {
> > + } else if (IS_ERR_OR_NULL(priv->dev3)) {
> > /* Register dev3 mouse if we received PS/2 packet first time */
> > if (!IS_ERR(priv->dev3))
> > psmouse_queue_work(psmouse, &priv->dev3_register_work,
> > --
> > 2.7.4
> >
> >
> > .
> >
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-13 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-12 8:36 [PATCH] Input: alps - Remove unnecessary unlikely zhengbin
2019-11-13 3:11 ` zhengbin (A)
2019-11-13 8:05 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).