From: Rob Herring <robh@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: support.opensource@diasemi.com, stwiss.opensource@diasemi.com,
dmitry.torokhov@gmail.com, Adam.Thomson.Opensource@diasemi.com,
devicetree@vger.kernel.org, kernel@pengutronix.de,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: Input: da9062 - fix dlg,disable-key-power description
Date: Thu, 5 Dec 2019 15:38:42 -0600 [thread overview]
Message-ID: <20191205213842.GA5354@bogus> (raw)
In-Reply-To: <20191127132304.22924-4-m.felsch@pengutronix.de>
On Wed, Nov 27, 2019 at 02:23:04PM +0100, Marco Felsch wrote:
> There was a bug within the driver since commit f889beaaab1c ("Input:
> da9063 - report KEY_POWER instead of KEY_SLEEP during power
> key-press"). Since we fixed the bug the KEY_POWER will be reported
> always so we need to adapt the dt-bindings too. Make the description
> more precise while on it.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> v2:
> - change description according Dmitry's suggestion.
>
> Documentation/devicetree/bindings/input/da9062-onkey.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> index 0005b2bdcdd7..9f895454179d 100644
> --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt
> +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> @@ -15,9 +15,8 @@ Required properties:
>
> Optional properties:
>
> -- dlg,disable-key-power : Disable power-down using a long key-press. If this
> - entry exists the OnKey driver will remove support for the KEY_POWER key
> - press when triggered using a long press of the OnKey.
> +- dlg,disable-key-power : If this property is present, the host will not be
> + issuing shutdown command over I2C in response to a long key-press.
This seems odd. Typically a long key press is used when the system is
locked up and would have to be a h/w mechanism.
Also, the new wording sounds like s/w policy, not h/w configuration.
What the OS does in response to KEY_POWER doesn't belong in DT.
>
> - dlg,key-opmode : Set the nONKEY behaviour. This value is initial set by the
> otp values. See nONKEY_PIN register description for more information.
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-12-05 21:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 13:23 [PATCH v2 0/3] DA9063 Onkey Improvements and Fixes Marco Felsch
2019-11-27 13:23 ` [PATCH v2 1/3] dt-bindings: Input: da9062 - add key-opmode documentation Marco Felsch
2019-12-02 11:38 ` Adam Thomson
2019-12-05 21:40 ` Rob Herring
2020-01-22 5:57 ` Dmitry Torokhov
2020-02-18 11:56 ` Marco Felsch
2019-11-27 13:23 ` [PATCH v2 2/3] input: misc: da9063_onkey: add mode change support Marco Felsch
2019-12-02 12:01 ` Adam Thomson
2020-01-08 8:48 ` Marco Felsch
2020-01-13 10:40 ` Lee Jones
2019-11-27 13:23 ` [PATCH v2 3/3] dt-bindings: Input: da9062 - fix dlg,disable-key-power description Marco Felsch
2019-12-02 12:15 ` Adam Thomson
2019-12-10 8:27 ` Marco Felsch
2019-12-12 10:08 ` Adam Thomson
2020-01-07 8:08 ` Marco Felsch
2020-01-08 10:05 ` Adam Thomson
2019-12-05 21:38 ` Rob Herring [this message]
2020-01-16 8:51 ` [PATCH v2 0/3] DA9063 Onkey Improvements and Fixes Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205213842.GA5354@bogus \
--to=robh@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).