From: Lee Jones <lee.jones@linaro.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: support.opensource@diasemi.com, stwiss.opensource@diasemi.com,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
Adam.Thomson.Opensource@diasemi.com, devicetree@vger.kernel.org,
kernel@pengutronix.de, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 2/3] input: misc: da9063_onkey: add mode change support
Date: Mon, 13 Jan 2020 10:40:28 +0000 [thread overview]
Message-ID: <20200113104028.GB5414@dell> (raw)
In-Reply-To: <20200108084800.x2doud4v6m3ssz6s@pengutronix.de>
On Wed, 08 Jan 2020, Marco Felsch wrote:
> Hi Lee,
>
> I forgot to add you to review the mfd part, sorry. Please can you have a
> look on it?
[...]
> > --- a/drivers/mfd/da9062-core.c
> > +++ b/drivers/mfd/da9062-core.c
> > @@ -510,6 +510,7 @@ static const struct regmap_range da9062_aa_writeable_ranges[] = {
> > regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B),
> > regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT),
> > regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19),
> > + regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I),
> > };
> >
> > static const struct regmap_range da9062_aa_volatile_ranges[] = {
Looks fine.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-01-13 10:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 13:23 [PATCH v2 0/3] DA9063 Onkey Improvements and Fixes Marco Felsch
2019-11-27 13:23 ` [PATCH v2 1/3] dt-bindings: Input: da9062 - add key-opmode documentation Marco Felsch
2019-12-02 11:38 ` Adam Thomson
2019-12-05 21:40 ` Rob Herring
2020-01-22 5:57 ` Dmitry Torokhov
2020-02-18 11:56 ` Marco Felsch
2019-11-27 13:23 ` [PATCH v2 2/3] input: misc: da9063_onkey: add mode change support Marco Felsch
2019-12-02 12:01 ` Adam Thomson
2020-01-08 8:48 ` Marco Felsch
2020-01-13 10:40 ` Lee Jones [this message]
2019-11-27 13:23 ` [PATCH v2 3/3] dt-bindings: Input: da9062 - fix dlg,disable-key-power description Marco Felsch
2019-12-02 12:15 ` Adam Thomson
2019-12-10 8:27 ` Marco Felsch
2019-12-12 10:08 ` Adam Thomson
2020-01-07 8:08 ` Marco Felsch
2020-01-08 10:05 ` Adam Thomson
2019-12-05 21:38 ` Rob Herring
2020-01-16 8:51 ` [PATCH v2 0/3] DA9063 Onkey Improvements and Fixes Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113104028.GB5414@dell \
--to=lee.jones@linaro.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).