linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Will Tipton <willwtipton@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: config option to change key soft autorepeat behavior
Date: Thu, 9 Jan 2020 17:02:21 -0800	[thread overview]
Message-ID: <20200110010221.GJ8314@dtor-ws> (raw)
In-Reply-To: <CANC6dXB4HQ6kF=JgahM7hFyGLRPx82zQQe04syqfV16_DDpBiA@mail.gmail.com>

Hi Will,

On Wed, Jan 08, 2020 at 01:08:54PM -0800, Will Tipton wrote:
> Hello,
> 
> I'd like to add an option to the input subsystem to change the behavior of
> key repeat. Essentially, when two keyboard keys 'a' and 'b' are held down
> simultaneously, I'd like to get 'abababab...' rather than 'abbbbbbbb...'.
> Another example of a request for this feature is here
> <https://tl.net/forum/sc2-strategy/446530-rapid-fire-hotkey-trick?page=4#64>
> .
> 
> Re: implementation -- I think this is a relatively minor change in
> input.h/.c
> <https://github.com/torvalds/linux/blob/master/drivers/input/input.c#L153>.
> When this kernel option is enabled, the timer and repeat_key
> <https://github.com/torvalds/linux/blob/master/include/linux/input.h#L165>
> members of input_dev are replaced by a container of (timer, key) tuples.
> There's one entry in this container for each currently-pressed key, and
> each entry is basically managed the same way the singular timer and
> repeat_key are managed currently.
> 
> I'm curious whether:
> - a patch adding this feature is likely to be accepted.
> - the implementation strategy I mentioned is the best approach.

Given that most environments (X, Wayland) ignore kernel autorepeat and
implement it themselves (since autorepeat parameters are really more of
a user preferences rather than hardware/system properties), I do not
think we should leave the kernel as is.

Thanks.

-- 
Dmitry

           reply	other threads:[~2020-01-10  1:02 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CANC6dXB4HQ6kF=JgahM7hFyGLRPx82zQQe04syqfV16_DDpBiA@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110010221.GJ8314@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=willwtipton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).