From: "Life is hard, and then you die" <ronald@innovation.ch>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Sergiu Cuciurean <sergiu.cuciurean@analog.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, nikolas@gnu.org,
gregkh@linuxfoundation.org, maowenan@huawei.com
Subject: Re: [PATCH] input: keyboard: applespi: Use new structure for SPI transfer delays
Date: Mon, 2 Mar 2020 22:03:51 -0800 [thread overview]
Message-ID: <20200303060351.GA12060@innovation.ch> (raw)
In-Reply-To: <20200302110932.GS1224808@smile.fi.intel.com>
On Mon, Mar 02, 2020 at 01:09:32PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 28, 2020 at 07:26:16PM -0800, Life is hard, and then you die wrote:
> > On Thu, Feb 27, 2020 at 02:45:34PM +0200, Sergiu Cuciurean wrote:
>
> ...
>
> > > - wr_t->delay_usecs = SPI_RW_CHG_DELAY_US;
> > > + wr_t->delay.value = SPI_RW_CHG_DELAY_US;
> > > + wr_t->delay.unit = SPI_DELAY_UNIT_USECS;
> >
> > Looks good to me and tested to confirm things still work.
>
> Ronald, we have the established tags for such, like Tested-by:, Reviewed-by:.
Apologies, that was sloppy of me. So:
Tested-by: Ronald Tschalär <ronald@innovation.ch>
Reviewed-by: Ronald Tschalär <ronald@innovation.ch>
Cheers,
Ronald
next prev parent reply other threads:[~2020-03-03 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 12:45 [PATCH] input: keyboard: applespi: Use new structure for SPI transfer delays Sergiu Cuciurean
2020-02-29 3:26 ` Life is hard, and then you die
2020-03-02 11:09 ` Andy Shevchenko
2020-03-03 6:03 ` Life is hard, and then you die [this message]
2020-12-11 5:57 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303060351.GA12060@innovation.ch \
--to=ronald@innovation.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=nikolas@gnu.org \
--cc=sergiu.cuciurean@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).