* Re: [PATCH] input: i8042: Remove special PowerPC handling [not found] ` <20200518181043.3363953-1-natechancellor@gmail.com> @ 2020-05-20 6:07 ` Michael Ellerman 2020-05-20 17:16 ` Dmitry Torokhov 0 siblings, 1 reply; 3+ messages in thread From: Michael Ellerman @ 2020-05-20 6:07 UTC (permalink / raw) To: dmitry.torokhov, linux-input Cc: Nathan Chancellor, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev, linux-kernel, clang-built-linux, Nathan Chancellor, kbuild test robot [ + Dmitry & linux-input ] Nathan Chancellor <natechancellor@gmail.com> writes: > This causes a build error with CONFIG_WALNUT because kb_cs and kb_data > were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and > include/asm-ppc"). > > ld.lld: error: undefined symbol: kb_cs >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a > > ld.lld: error: undefined symbol: kb_data >> referenced by i8042.c:309 (drivers/input/serio/i8042.c:309) >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> referenced by i8042-ppcio.h:33 (drivers/input/serio/i8042-ppcio.h:33) >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> referenced by i8042.c:319 (drivers/input/serio/i8042.c:319) >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> referenced 15 more times > > Presumably since nobody has noticed this for the last 12 years, there is > not anyone actually trying to use this driver so we can just remove this > special walnut code and use the generic header so it builds for all > configurations. > > Fixes: 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > drivers/input/serio/i8042-ppcio.h | 57 ------------------------------- > drivers/input/serio/i8042.h | 2 -- > 2 files changed, 59 deletions(-) > delete mode 100644 drivers/input/serio/i8042-ppcio.h This LGTM. Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) I assumed drivers/input/serio would be pretty quiet, but there's actually some commits to it in linux-next. So perhaps this should go via the input tree. Dmitry do you want to take this, or should I take it via powerpc? Original patch is here: https://lore.kernel.org/lkml/20200518181043.3363953-1-natechancellor@gmail.com cheers > diff --git a/drivers/input/serio/i8042-ppcio.h b/drivers/input/serio/i8042-ppcio.h > deleted file mode 100644 > index 391f94d9e47d..000000000000 > --- a/drivers/input/serio/i8042-ppcio.h > +++ /dev/null > @@ -1,57 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0-only */ > -#ifndef _I8042_PPCIO_H > -#define _I8042_PPCIO_H > - > - > -#if defined(CONFIG_WALNUT) > - > -#define I8042_KBD_IRQ 25 > -#define I8042_AUX_IRQ 26 > - > -#define I8042_KBD_PHYS_DESC "walnutps2/serio0" > -#define I8042_AUX_PHYS_DESC "walnutps2/serio1" > -#define I8042_MUX_PHYS_DESC "walnutps2/serio%d" > - > -extern void *kb_cs; > -extern void *kb_data; > - > -#define I8042_COMMAND_REG (*(int *)kb_cs) > -#define I8042_DATA_REG (*(int *)kb_data) > - > -static inline int i8042_read_data(void) > -{ > - return readb(kb_data); > -} > - > -static inline int i8042_read_status(void) > -{ > - return readb(kb_cs); > -} > - > -static inline void i8042_write_data(int val) > -{ > - writeb(val, kb_data); > -} > - > -static inline void i8042_write_command(int val) > -{ > - writeb(val, kb_cs); > -} > - > -static inline int i8042_platform_init(void) > -{ > - i8042_reset = I8042_RESET_ALWAYS; > - return 0; > -} > - > -static inline void i8042_platform_exit(void) > -{ > -} > - > -#else > - > -#include "i8042-io.h" > - > -#endif > - > -#endif /* _I8042_PPCIO_H */ > diff --git a/drivers/input/serio/i8042.h b/drivers/input/serio/i8042.h > index 38dc27ad3c18..eb376700dfff 100644 > --- a/drivers/input/serio/i8042.h > +++ b/drivers/input/serio/i8042.h > @@ -17,8 +17,6 @@ > #include "i8042-ip22io.h" > #elif defined(CONFIG_SNI_RM) > #include "i8042-snirm.h" > -#elif defined(CONFIG_PPC) > -#include "i8042-ppcio.h" > #elif defined(CONFIG_SPARC) > #include "i8042-sparcio.h" > #elif defined(CONFIG_X86) || defined(CONFIG_IA64) > > base-commit: 72bc15d0018ebfbc9c389539d636e2e9a9002b3b > -- > 2.27.0.rc0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] input: i8042: Remove special PowerPC handling 2020-05-20 6:07 ` [PATCH] input: i8042: Remove special PowerPC handling Michael Ellerman @ 2020-05-20 17:16 ` Dmitry Torokhov 2020-05-21 7:39 ` Michael Ellerman 0 siblings, 1 reply; 3+ messages in thread From: Dmitry Torokhov @ 2020-05-20 17:16 UTC (permalink / raw) To: Michael Ellerman Cc: linux-input, Nathan Chancellor, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev, linux-kernel, clang-built-linux, kbuild test robot Hi Michael, On Wed, May 20, 2020 at 04:07:00PM +1000, Michael Ellerman wrote: > [ + Dmitry & linux-input ] > > Nathan Chancellor <natechancellor@gmail.com> writes: > > This causes a build error with CONFIG_WALNUT because kb_cs and kb_data > > were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and > > include/asm-ppc"). > > > > ld.lld: error: undefined symbol: kb_cs > >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) > >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a > >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) > >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a > >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) > >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a > > > > ld.lld: error: undefined symbol: kb_data > >> referenced by i8042.c:309 (drivers/input/serio/i8042.c:309) > >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a > >> referenced by i8042-ppcio.h:33 (drivers/input/serio/i8042-ppcio.h:33) > >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a > >> referenced by i8042.c:319 (drivers/input/serio/i8042.c:319) > >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a > >> referenced 15 more times > > > > Presumably since nobody has noticed this for the last 12 years, there is > > not anyone actually trying to use this driver so we can just remove this > > special walnut code and use the generic header so it builds for all > > configurations. > > > > Fixes: 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc") > > Reported-by: kbuild test robot <lkp@intel.com> > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > --- > > drivers/input/serio/i8042-ppcio.h | 57 ------------------------------- > > drivers/input/serio/i8042.h | 2 -- > > 2 files changed, 59 deletions(-) > > delete mode 100644 drivers/input/serio/i8042-ppcio.h > > This LGTM. > > Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) > > I assumed drivers/input/serio would be pretty quiet, but there's > actually some commits to it in linux-next. So perhaps this should go via > the input tree. > > Dmitry do you want to take this, or should I take it via powerpc? > > Original patch is here: > https://lore.kernel.org/lkml/20200518181043.3363953-1-natechancellor@gmail.com I'm fine with you taking it through powerpc. Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Also, while I have your attention ;), could you please ack or take https://lore.kernel.org/lkml/20191002214854.GA114387@dtor-ws/ as I believe this is the last user or input_polled_dev API and I would like to drop it from the tree. Thanks! -- Dmitry ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] input: i8042: Remove special PowerPC handling 2020-05-20 17:16 ` Dmitry Torokhov @ 2020-05-21 7:39 ` Michael Ellerman 0 siblings, 0 replies; 3+ messages in thread From: Michael Ellerman @ 2020-05-21 7:39 UTC (permalink / raw) To: Dmitry Torokhov Cc: linux-input, Nathan Chancellor, Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev, linux-kernel, clang-built-linux, kbuild test robot Dmitry Torokhov <dmitry.torokhov@gmail.com> writes: > Hi Michael, > > On Wed, May 20, 2020 at 04:07:00PM +1000, Michael Ellerman wrote: >> [ + Dmitry & linux-input ] >> >> Nathan Chancellor <natechancellor@gmail.com> writes: >> > This causes a build error with CONFIG_WALNUT because kb_cs and kb_data >> > were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and >> > include/asm-ppc"). >> > >> > ld.lld: error: undefined symbol: kb_cs >> >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> > >> > ld.lld: error: undefined symbol: kb_data >> >> referenced by i8042.c:309 (drivers/input/serio/i8042.c:309) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced by i8042-ppcio.h:33 (drivers/input/serio/i8042-ppcio.h:33) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced by i8042.c:319 (drivers/input/serio/i8042.c:319) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced 15 more times >> > >> > Presumably since nobody has noticed this for the last 12 years, there is >> > not anyone actually trying to use this driver so we can just remove this >> > special walnut code and use the generic header so it builds for all >> > configurations. >> > >> > Fixes: 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc") >> > Reported-by: kbuild test robot <lkp@intel.com> >> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> >> > --- >> > drivers/input/serio/i8042-ppcio.h | 57 ------------------------------- >> > drivers/input/serio/i8042.h | 2 -- >> > 2 files changed, 59 deletions(-) >> > delete mode 100644 drivers/input/serio/i8042-ppcio.h >> >> This LGTM. >> >> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) >> >> I assumed drivers/input/serio would be pretty quiet, but there's >> actually some commits to it in linux-next. So perhaps this should go via >> the input tree. >> >> Dmitry do you want to take this, or should I take it via powerpc? >> >> Original patch is here: >> https://lore.kernel.org/lkml/20200518181043.3363953-1-natechancellor@gmail.com > > I'm fine with you taking it through powerpc. > > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Thanks. > Also, while I have your attention ;), could you please ack or take > https://lore.kernel.org/lkml/20191002214854.GA114387@dtor-ws/ as I > believe this is the last user or input_polled_dev API and I would like > to drop it from the tree. Ooof. Sorry, you are very patient :) I have put it in my next-test. In future feel free to send me mail off-list, or ping me on irc, if I haven't picked something up after several months! cheers ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-21 7:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <87a7254bxd.fsf@mpe.ellerman.id.au>
[not found] ` <20200518181043.3363953-1-natechancellor@gmail.com>
2020-05-20 6:07 ` [PATCH] input: i8042: Remove special PowerPC handling Michael Ellerman
2020-05-20 17:16 ` Dmitry Torokhov
2020-05-21 7:39 ` Michael Ellerman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).