From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yariv <oigevald+kernel@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: PROBLEM: Apple external Trackpad event timestamps are jittery (regression)
Date: Sat, 23 May 2020 14:18:41 -0700 [thread overview]
Message-ID: <20200523211841.GD89269@dtor-ws> (raw)
In-Reply-To: <CAEwx+Qr=nJ0tPcuHhjO4=Mw_OHr17QcqeqTvcEzgZ0EcoNc8GQ@mail.gmail.com>
On Sat, May 23, 2020 at 10:11:50PM +0300, Yariv wrote:
> Hi,
>
> I omitted what looks unrelated, please let me know if you need other
> details or the full content.
> Also I wasn't sure how to find the relevant driver, so I pasted the
> relevant dmesg snippets. If there is a more precise way to identify
> the driver please let me know and I'll send the missing items.
>
> Gen1:
>
> dmesg
>
> [ 11.307056] Bluetooth: HIDP (Human Interface Emulation) ver 1.2
> [ 11.307060] Bluetooth: HIDP socket layer initialized
> [ 11.310541] magicmouse 0005:05AC:030E.0005: unknown main item tag 0x0
> [ 11.310657] input: john’s Trackpad as
> /devices/pci0000:00/0000:00:14.0/usb1/1-13/1-13:1.0/bluetooth/hci0/hci0:70/0005:05AC:030E.0005/input/input21
> [ 11.310776] magicmouse 0005:05AC:030E.0005: input,hidraw4:
> BLUETOOTH HID v1.60 Mouse [john’s Trackpad] on 00:1a:7d:da:71:09
Ok, awesome. Can you please try the patch below?
--
Dmitry
HID: magicmouse: do not set up autorepeat
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Neither trackpad, nor the mouse want input core to generate autorepeat
events for their buttons, so let's reset the bit (as hid-input sets it
for these devices based on the usage vendor code).
Reported-by: Yariv <oigevald+kernel@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/hid/hid-magicmouse.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index 34138667f8af..7ea78be11c84 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -535,6 +535,12 @@ static int magicmouse_setup_input(struct input_dev *input, struct hid_device *hd
__set_bit(MSC_RAW, input->mscbit);
}
+ /*
+ * hit-input may mark device as using autorepeat, but neither
+ * the trackpad, nor the mouse actually want it.
+ */
+ __clear_bit(EV_REP, input->evbit);
+
return 0;
}
next prev parent reply other threads:[~2020-05-23 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 6:18 PROBLEM: Apple external Trackpad event timestamps are jittery (regression) Yariv
2020-05-11 20:11 ` Dmitry Torokhov
2020-05-12 5:19 ` Peter Hutterer
2020-05-12 19:54 ` Yariv
2020-05-22 5:27 ` Yariv
2020-05-23 18:37 ` Dmitry Torokhov
2020-05-23 19:11 ` Yariv
2020-05-23 21:18 ` Dmitry Torokhov [this message]
2020-05-24 11:36 ` Yariv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523211841.GD89269@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=oigevald+kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).