* [PATCH v10] Add matrix keypad driver support for Mediatek SoCs
@ 2020-05-28 5:33 Fengping Yu
2020-05-28 7:19 ` Marco Felsch
0 siblings, 1 reply; 2+ messages in thread
From: Fengping Yu @ 2020-05-28 5:33 UTC (permalink / raw)
To: Yingjoe Chen, Dmitry Torokhov, Andy Shevchenko, Marco Felsch
Cc: linux-input, linux-arm-kernel, linux-mediatek
Change since v9:
- modify KEYBOARD_MTK_KPD config dependent item
- remove wakeup member of mtk_keypad struct
- remove default pinctrl state set
- modify request irq failed return value
- add space of kepad matching table
- modify align issue
fengping.yu (3):
dt-bindings: Add keypad devicetree documentation
drivers: input: keyboard: Add mtk keypad driver
configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m
.../devicetree/bindings/input/mtk-kpd.yaml | 95 +++++++++
arch/arm64/configs/defconfig | 1 +
drivers/input/keyboard/Kconfig | 11 +
drivers/input/keyboard/Makefile | 1 +
drivers/input/keyboard/mtk-kpd.c | 201 ++++++++++++++++++
5 files changed, 309 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
create mode 100644 drivers/input/keyboard/mtk-kpd.c
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v10] Add matrix keypad driver support for Mediatek SoCs
2020-05-28 5:33 [PATCH v10] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
@ 2020-05-28 7:19 ` Marco Felsch
0 siblings, 0 replies; 2+ messages in thread
From: Marco Felsch @ 2020-05-28 7:19 UTC (permalink / raw)
To: Fengping Yu
Cc: Yingjoe Chen, Dmitry Torokhov, Andy Shevchenko, linux-input,
linux-arm-kernel, linux-mediatek
Hi,
this version looks nice to me =) One last question.
On 20-05-28 13:33, Fengping Yu wrote:
>
> Change since v9:
> - modify KEYBOARD_MTK_KPD config dependent item
> - remove wakeup member of mtk_keypad struct
You also removed the device wakeup capability completely, was this
intended? What I mean is that we don't need that member within the
driver state struct.
Regards,
Marco
> - remove default pinctrl state set
> - modify request irq failed return value
> - add space of kepad matching table
> - modify align issue
>
> fengping.yu (3):
> dt-bindings: Add keypad devicetree documentation
> drivers: input: keyboard: Add mtk keypad driver
> configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m
>
> .../devicetree/bindings/input/mtk-kpd.yaml | 95 +++++++++
> arch/arm64/configs/defconfig | 1 +
> drivers/input/keyboard/Kconfig | 11 +
> drivers/input/keyboard/Makefile | 1 +
> drivers/input/keyboard/mtk-kpd.c | 201 ++++++++++++++++++
> 5 files changed, 309 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
> create mode 100644 drivers/input/keyboard/mtk-kpd.c
>
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-28 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 5:33 [PATCH v10] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
2020-05-28 7:19 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).