* [RESEND PATCH v11] Add matrix keypad driver support for Mediatek SoCs
@ 2020-05-28 9:01 Fengping Yu
2020-05-28 10:24 ` Andy Shevchenko
[not found] ` <20200528090144.54033-3-fengping.yu@mediatek.com>
0 siblings, 2 replies; 6+ messages in thread
From: Fengping Yu @ 2020-05-28 9:01 UTC (permalink / raw)
To: Yingjoe Chen, Dmitry Torokhov, Andy Shevchenko, Marco Felsch
Cc: linux-input, linux-arm-kernel, linux-mediatek
Change since v10:
- add wakeup source setting in probe function
fengping.yu (3):
dt-bindings: Add keypad devicetree documentation
drivers: input: keyboard: Add mtk keypad driver
configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m
.../devicetree/bindings/input/mtk-kpd.yaml | 95 ++++++++
arch/arm64/configs/defconfig | 1 +
drivers/input/keyboard/Kconfig | 11 +
drivers/input/keyboard/Makefile | 1 +
drivers/input/keyboard/mtk-kpd.c | 206 ++++++++++++++++++
5 files changed, 314 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
create mode 100644 drivers/input/keyboard/mtk-kpd.c
--
2.18.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v11] Add matrix keypad driver support for Mediatek SoCs
2020-05-28 9:01 [RESEND PATCH v11] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
@ 2020-05-28 10:24 ` Andy Shevchenko
[not found] ` <20200528090144.54033-3-fengping.yu@mediatek.com>
1 sibling, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2020-05-28 10:24 UTC (permalink / raw)
To: Fengping Yu
Cc: Yingjoe Chen, Dmitry Torokhov, Marco Felsch, linux-input,
linux-arm-kernel, linux-mediatek
On Thu, May 28, 2020 at 05:01:42PM +0800, Fengping Yu wrote:
>
> Change since v10:
> - add wakeup source setting in probe function
You forgot tags by Marco
>
> fengping.yu (3):
> dt-bindings: Add keypad devicetree documentation
> drivers: input: keyboard: Add mtk keypad driver
> configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m
>
> .../devicetree/bindings/input/mtk-kpd.yaml | 95 ++++++++
> arch/arm64/configs/defconfig | 1 +
> drivers/input/keyboard/Kconfig | 11 +
> drivers/input/keyboard/Makefile | 1 +
> drivers/input/keyboard/mtk-kpd.c | 206 ++++++++++++++++++
> 5 files changed, 314 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
> create mode 100644 drivers/input/keyboard/mtk-kpd.c
>
> --
> 2.18.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver
[not found] ` <20200528090144.54033-3-fengping.yu@mediatek.com>
@ 2020-05-28 10:27 ` Andy Shevchenko
2020-05-28 11:45 ` Marco Felsch
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2020-05-28 10:27 UTC (permalink / raw)
To: Fengping Yu
Cc: Yingjoe Chen, Dmitry Torokhov, Marco Felsch, linux-input,
linux-arm-kernel, linux-mediatek
On Thu, May 28, 2020 at 05:01:47PM +0800, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@mediatek.com>
>
> This adds matrix keypad support for Mediatek SoCs.
...
> +config KEYBOARD_MTK_KPD
> + tristate "MediaTek Keypad Support"
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> + select CONFIG_REGMAP_MMIO
This is wrong.
> + select INPUT_MATRIXKMAP
...
> + ret = devm_add_action_or_reset(&pdev->dev, kpd_clk_disable,
> + keypad->clk);
I would leave on one line (only 81 characters).
> + if (ret)
> + return ret;
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver
2020-05-28 10:27 ` [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver Andy Shevchenko
@ 2020-05-28 11:45 ` Marco Felsch
2020-05-28 12:22 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Marco Felsch @ 2020-05-28 11:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Fengping Yu, Yingjoe Chen, Dmitry Torokhov, linux-input,
linux-arm-kernel, linux-mediatek
Hi Andy,
On 20-05-28 13:27, Andy Shevchenko wrote:
> On Thu, May 28, 2020 at 05:01:47PM +0800, Fengping Yu wrote:
> > From: "fengping.yu" <fengping.yu@mediatek.com>
> >
> > This adds matrix keypad support for Mediatek SoCs.
>
> ...
>
> > +config KEYBOARD_MTK_KPD
> > + tristate "MediaTek Keypad Support"
> > + depends on ARCH_MEDIATEK || COMPILE_TEST
>
> > + select CONFIG_REGMAP_MMIO
>
> This is wrong.
Why is this wrong? The driver uses the rmap-mmio functions.
Thanks for the explanation =)
Marco
>
> > + select INPUT_MATRIXKMAP
>
> ...
>
> > + ret = devm_add_action_or_reset(&pdev->dev, kpd_clk_disable,
> > + keypad->clk);
>
> I would leave on one line (only 81 characters).
>
> > + if (ret)
> > + return ret;
>
> --
> With Best Regards,
> Andy Shevchenko
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver
2020-05-28 11:45 ` Marco Felsch
@ 2020-05-28 12:22 ` Andy Shevchenko
2020-05-28 12:33 ` Marco Felsch
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2020-05-28 12:22 UTC (permalink / raw)
To: Marco Felsch
Cc: Fengping Yu, Yingjoe Chen, Dmitry Torokhov, linux-input,
linux-arm-kernel, linux-mediatek
On Thu, May 28, 2020 at 01:45:58PM +0200, Marco Felsch wrote:
> On 20-05-28 13:27, Andy Shevchenko wrote:
> > On Thu, May 28, 2020 at 05:01:47PM +0800, Fengping Yu wrote:
...
> > > + select CONFIG_REGMAP_MMIO
> >
> > This is wrong.
>
> Why is this wrong? The driver uses the rmap-mmio functions.
In Kconfig CONFIG_ prefix is implied.
There is no CONFIG_CONFIG_REGMAP_MMIO.
> Thanks for the explanation =)
Sorry, I think it's obvious...
> > > + select INPUT_MATRIXKMAP
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver
2020-05-28 12:22 ` Andy Shevchenko
@ 2020-05-28 12:33 ` Marco Felsch
0 siblings, 0 replies; 6+ messages in thread
From: Marco Felsch @ 2020-05-28 12:33 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Fengping Yu, Yingjoe Chen, Dmitry Torokhov, linux-input,
linux-arm-kernel, linux-mediatek
On 20-05-28 15:22, Andy Shevchenko wrote:
> On Thu, May 28, 2020 at 01:45:58PM +0200, Marco Felsch wrote:
> > On 20-05-28 13:27, Andy Shevchenko wrote:
> > > On Thu, May 28, 2020 at 05:01:47PM +0800, Fengping Yu wrote:
>
> ...
>
> > > > + select CONFIG_REGMAP_MMIO
> > >
> > > This is wrong.
> >
> > Why is this wrong? The driver uses the rmap-mmio functions.
>
> In Kconfig CONFIG_ prefix is implied.
>
> There is no CONFIG_CONFIG_REGMAP_MMIO.
>
> > Thanks for the explanation =)
>
> Sorry, I think it's obvious...
Damn, you right it is. Bloody automatism mismatch in my brain.
Regards,
Marco
>
> > > > + select INPUT_MATRIXKMAP
>
> --
> With Best Regards,
> Andy Shevchenko
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-28 12:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 9:01 [RESEND PATCH v11] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
2020-05-28 10:24 ` Andy Shevchenko
[not found] ` <20200528090144.54033-3-fengping.yu@mediatek.com>
2020-05-28 10:27 ` [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver Andy Shevchenko
2020-05-28 11:45 ` Marco Felsch
2020-05-28 12:22 ` Andy Shevchenko
2020-05-28 12:33 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).