* [PATCH resend 0/2] Input: soc_button_array - Add support for INT33D3 ACPI tablet-switch device
@ 2020-08-26 15:05 Hans de Goede
2020-08-26 15:06 ` [PATCH resend 1/2] Input: soc_button_array - Add active_low setting to soc_button_info Hans de Goede
2020-08-26 15:06 ` [PATCH resend 2/2] Input: soc_button_array - Add support for INT33D3 tablet-mode switch devices Hans de Goede
0 siblings, 2 replies; 6+ messages in thread
From: Hans de Goede @ 2020-08-26 15:05 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Hans de Goede, linux-input
Hi Dmitry,
These 2 patches seem to have fallen through the cracks again, hence
this resend.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH resend 1/2] Input: soc_button_array - Add active_low setting to soc_button_info
2020-08-26 15:05 [PATCH resend 0/2] Input: soc_button_array - Add support for INT33D3 ACPI tablet-switch device Hans de Goede
@ 2020-08-26 15:06 ` Hans de Goede
2020-09-14 6:09 ` Dmitry Torokhov
2020-08-26 15:06 ` [PATCH resend 2/2] Input: soc_button_array - Add support for INT33D3 tablet-mode switch devices Hans de Goede
1 sibling, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2020-08-26 15:06 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Hans de Goede, linux-input
This is a preparation patch for adding support for Intel INT33D3
ACPI devices. These INT33D3 devices follow yet another Intel defined
(but not documented) ACPI GPIO button standard.
Unlike the ACPI GPIO button devices supported so far, the GPIO used in
the INT33D3 devices is active-high, rather then active-low.
This commit makes setting the gpio_keys_button.active_low flag
configurable through the soc_button_info struct and enables it for all
currently supported devices.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/misc/soc_button_array.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
index 08520b3a18b8..e3a22a61f5d9 100644
--- a/drivers/input/misc/soc_button_array.c
+++ b/drivers/input/misc/soc_button_array.c
@@ -23,6 +23,7 @@ struct soc_button_info {
unsigned int event_code;
bool autorepeat;
bool wakeup;
+ bool active_low;
};
struct soc_device_data {
@@ -110,7 +111,7 @@ soc_button_device_create(struct platform_device *pdev,
gpio_keys[n_buttons].type = info->event_type;
gpio_keys[n_buttons].code = info->event_code;
gpio_keys[n_buttons].gpio = gpio;
- gpio_keys[n_buttons].active_low = 1;
+ gpio_keys[n_buttons].active_low = info->active_low;
gpio_keys[n_buttons].desc = info->name;
gpio_keys[n_buttons].wakeup = info->wakeup;
/* These devices often use cheap buttons, use 50 ms debounce */
@@ -173,6 +174,7 @@ static int soc_button_parse_btn_desc(struct device *dev,
}
info->event_type = EV_KEY;
+ info->active_low = true;
info->acpi_index =
soc_button_get_acpi_object_int(&desc->package.elements[1]);
upage = soc_button_get_acpi_object_int(&desc->package.elements[3]);
@@ -383,11 +385,11 @@ static int soc_button_probe(struct platform_device *pdev)
* Platforms"
*/
static const struct soc_button_info soc_button_PNP0C40[] = {
- { "power", 0, EV_KEY, KEY_POWER, false, true },
- { "home", 1, EV_KEY, KEY_LEFTMETA, false, true },
- { "volume_up", 2, EV_KEY, KEY_VOLUMEUP, true, false },
- { "volume_down", 3, EV_KEY, KEY_VOLUMEDOWN, true, false },
- { "rotation_lock", 4, EV_KEY, KEY_ROTATE_LOCK_TOGGLE, false, false },
+ { "power", 0, EV_KEY, KEY_POWER, false, true, true },
+ { "home", 1, EV_KEY, KEY_LEFTMETA, false, true, true },
+ { "volume_up", 2, EV_KEY, KEY_VOLUMEUP, true, false, true },
+ { "volume_down", 3, EV_KEY, KEY_VOLUMEDOWN, true, false, true },
+ { "rotation_lock", 4, EV_KEY, KEY_ROTATE_LOCK_TOGGLE, false, false, true },
{ }
};
@@ -444,9 +446,9 @@ static int soc_device_check_MSHW0040(struct device *dev)
* Obtained from DSDT/testing.
*/
static const struct soc_button_info soc_button_MSHW0040[] = {
- { "power", 0, EV_KEY, KEY_POWER, false, true },
- { "volume_up", 2, EV_KEY, KEY_VOLUMEUP, true, false },
- { "volume_down", 4, EV_KEY, KEY_VOLUMEDOWN, true, false },
+ { "power", 0, EV_KEY, KEY_POWER, false, true, true },
+ { "volume_up", 2, EV_KEY, KEY_VOLUMEUP, true, false, true },
+ { "volume_down", 4, EV_KEY, KEY_VOLUMEDOWN, true, false, true },
{ }
};
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH resend 2/2] Input: soc_button_array - Add support for INT33D3 tablet-mode switch devices
2020-08-26 15:05 [PATCH resend 0/2] Input: soc_button_array - Add support for INT33D3 ACPI tablet-switch device Hans de Goede
2020-08-26 15:06 ` [PATCH resend 1/2] Input: soc_button_array - Add active_low setting to soc_button_info Hans de Goede
@ 2020-08-26 15:06 ` Hans de Goede
2020-09-14 6:09 ` Dmitry Torokhov
1 sibling, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2020-08-26 15:06 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Hans de Goede, linux-input
According to the Microsoft documentation for Windows 8 convertible
devices, these devices should implement a PNP0C60 "laptop/slate mode state
indicator" ACPI device.
This device can work in 2 ways, if there is a GPIO which directly
indicates the device is in tablet-mode or not then the direct-gpio mode
should be used. If there is no such GPIO, but instead the events are
coming from e.g. the embedded-controller, then there should still be
a PNP0C60 ACPI device and event-injection should be used to send the
events. The drivers/platform/x86/intel-vbtn.c code is an example from
a standardized manner of doing the latter.
On various 2-in-1s with either a detachable keyboard, or with 360°
hinges, the direct GPIO mode is indicated by an ACPI device with a
HID of INT33D3, which contains a single GpioInt in its ACPI resource
table, which directly indicates if the device is in tablet-mode or not.
This commit adds support for this to the soc_button_array code, as
well as for the alternative ID9001 HID which some devices use
instead of the INT33D3 HID.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/misc/soc_button_array.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
index e3a22a61f5d9..837c787e9c4b 100644
--- a/drivers/input/misc/soc_button_array.c
+++ b/drivers/input/misc/soc_button_array.c
@@ -397,6 +397,15 @@ static const struct soc_device_data soc_device_PNP0C40 = {
.button_info = soc_button_PNP0C40,
};
+static const struct soc_button_info soc_button_INT33D3[] = {
+ { "tablet_mode", 0, EV_SW, SW_TABLET_MODE, false, false, false },
+ { }
+};
+
+static const struct soc_device_data soc_device_INT33D3 = {
+ .button_info = soc_button_INT33D3,
+};
+
/*
* Special device check for Surface Book 2 and Surface Pro (2017).
* Both, the Surface Pro 4 (surfacepro3_button.c) and the above mentioned
@@ -459,6 +468,8 @@ static const struct soc_device_data soc_device_MSHW0040 = {
static const struct acpi_device_id soc_button_acpi_match[] = {
{ "PNP0C40", (unsigned long)&soc_device_PNP0C40 },
+ { "INT33D3", (unsigned long)&soc_device_INT33D3 },
+ { "ID9001", (unsigned long)&soc_device_INT33D3 },
{ "ACPI0011", 0 },
/* Microsoft Surface Devices (5th and 6th generation) */
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH resend 1/2] Input: soc_button_array - Add active_low setting to soc_button_info
2020-08-26 15:06 ` [PATCH resend 1/2] Input: soc_button_array - Add active_low setting to soc_button_info Hans de Goede
@ 2020-09-14 6:09 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2020-09-14 6:09 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-input
On Wed, Aug 26, 2020 at 05:06:00PM +0200, Hans de Goede wrote:
> This is a preparation patch for adding support for Intel INT33D3
> ACPI devices. These INT33D3 devices follow yet another Intel defined
> (but not documented) ACPI GPIO button standard.
>
> Unlike the ACPI GPIO button devices supported so far, the GPIO used in
> the INT33D3 devices is active-high, rather then active-low.
>
> This commit makes setting the gpio_keys_button.active_low flag
> configurable through the soc_button_info struct and enables it for all
> currently supported devices.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend 2/2] Input: soc_button_array - Add support for INT33D3 tablet-mode switch devices
2020-08-26 15:06 ` [PATCH resend 2/2] Input: soc_button_array - Add support for INT33D3 tablet-mode switch devices Hans de Goede
@ 2020-09-14 6:09 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2020-09-14 6:09 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-input
On Wed, Aug 26, 2020 at 05:06:01PM +0200, Hans de Goede wrote:
> According to the Microsoft documentation for Windows 8 convertible
> devices, these devices should implement a PNP0C60 "laptop/slate mode state
> indicator" ACPI device.
>
> This device can work in 2 ways, if there is a GPIO which directly
> indicates the device is in tablet-mode or not then the direct-gpio mode
> should be used. If there is no such GPIO, but instead the events are
> coming from e.g. the embedded-controller, then there should still be
> a PNP0C60 ACPI device and event-injection should be used to send the
> events. The drivers/platform/x86/intel-vbtn.c code is an example from
> a standardized manner of doing the latter.
>
> On various 2-in-1s with either a detachable keyboard, or with 360°
> hinges, the direct GPIO mode is indicated by an ACPI device with a
> HID of INT33D3, which contains a single GpioInt in its ACPI resource
> table, which directly indicates if the device is in tablet-mode or not.
>
> This commit adds support for this to the soc_button_array code, as
> well as for the alternative ID9001 HID which some devices use
> instead of the INT33D3 HID.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH resend 2/2] Input: soc_button_array - Add support for INT33D3 tablet-mode switch devices
2020-06-20 12:34 [PATCH resend 0/2] " Hans de Goede
@ 2020-06-20 12:34 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2020-06-20 12:34 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Hans de Goede, linux-input
According to the Microsoft documentation for Windows 8 convertible
devices, these devices should implement a PNP0C60 "laptop/slate mode state
indicator" ACPI device.
This device can work in 2 ways, if there is a GPIO which directly
indicates the device is in tablet-mode or not then the direct-gpio mode
should be used. If there is no such GPIO, but instead the events are
coming from e.g. the embedded-controller, then there should still be
a PNP0C60 ACPI device and event-injection should be used to send the
events. The drivers/platform/x86/intel-vbtn.c code is an example from
a standardized manner of doing the latter.
On various 2-in-1s with either a detachable keyboard, or with 360°
hinges, the direct GPIO mode is indicated by an ACPI device with a
HID of INT33D3, which contains a single GpioInt in its ACPI resource
table, which directly indicates if the device is in tablet-mode or not.
This commit adds support for this to the soc_button_array code, as
well as for the alternative ID9001 HID which some devices use
instead of the INT33D3 HID.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/misc/soc_button_array.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
index e3a22a61f5d9..837c787e9c4b 100644
--- a/drivers/input/misc/soc_button_array.c
+++ b/drivers/input/misc/soc_button_array.c
@@ -397,6 +397,15 @@ static const struct soc_device_data soc_device_PNP0C40 = {
.button_info = soc_button_PNP0C40,
};
+static const struct soc_button_info soc_button_INT33D3[] = {
+ { "tablet_mode", 0, EV_SW, SW_TABLET_MODE, false, false, false },
+ { }
+};
+
+static const struct soc_device_data soc_device_INT33D3 = {
+ .button_info = soc_button_INT33D3,
+};
+
/*
* Special device check for Surface Book 2 and Surface Pro (2017).
* Both, the Surface Pro 4 (surfacepro3_button.c) and the above mentioned
@@ -459,6 +468,8 @@ static const struct soc_device_data soc_device_MSHW0040 = {
static const struct acpi_device_id soc_button_acpi_match[] = {
{ "PNP0C40", (unsigned long)&soc_device_PNP0C40 },
+ { "INT33D3", (unsigned long)&soc_device_INT33D3 },
+ { "ID9001", (unsigned long)&soc_device_INT33D3 },
{ "ACPI0011", 0 },
/* Microsoft Surface Devices (5th and 6th generation) */
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-14 6:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 15:05 [PATCH resend 0/2] Input: soc_button_array - Add support for INT33D3 ACPI tablet-switch device Hans de Goede
2020-08-26 15:06 ` [PATCH resend 1/2] Input: soc_button_array - Add active_low setting to soc_button_info Hans de Goede
2020-09-14 6:09 ` Dmitry Torokhov
2020-08-26 15:06 ` [PATCH resend 2/2] Input: soc_button_array - Add support for INT33D3 tablet-mode switch devices Hans de Goede
2020-09-14 6:09 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2020-06-20 12:34 [PATCH resend 0/2] " Hans de Goede
2020-06-20 12:34 ` [PATCH resend 2/2] " Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).