* [PATCH] Input: trackpoint - add new trackpoint variant IDs
@ 2020-09-09 8:36 Vincent Huang
2020-09-14 5:57 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Vincent Huang @ 2020-09-09 8:36 UTC (permalink / raw)
To: linux-input, linux-kernel; +Cc: Vincent Huang, Dmitry Torokhov, Andrew Duggan
Add trackpoint variant IDs to allow supported control
on Synaptics trackpoints
Signed-off-by: Vincent Huang <vincent.huang@tw.synaptics.com>
---
drivers/input/mouse/trackpoint.c | 2 ++
drivers/input/mouse/trackpoint.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
index 3eefee2ee2a1..c54d2f9e1c4a 100644
--- a/drivers/input/mouse/trackpoint.c
+++ b/drivers/input/mouse/trackpoint.c
@@ -21,6 +21,8 @@ static const char * const trackpoint_variants[] = {
[TP_VARIANT_ALPS] = "ALPS",
[TP_VARIANT_ELAN] = "Elan",
[TP_VARIANT_NXP] = "NXP",
+ [TP_VARIANT_JYT_SYNAPTICS] = "JYT_SYNAPTICS",
+ [TP_VARIANT_SYNAPTICS] = "SYNAPTICS",
};
/*
diff --git a/drivers/input/mouse/trackpoint.h b/drivers/input/mouse/trackpoint.h
index 5cb93ed26085..42eda7d4ba08 100644
--- a/drivers/input/mouse/trackpoint.h
+++ b/drivers/input/mouse/trackpoint.h
@@ -28,6 +28,8 @@
#define TP_VARIANT_ALPS 0x02
#define TP_VARIANT_ELAN 0x03
#define TP_VARIANT_NXP 0x04
+#define TP_VARIANT_JYT_SYNAPTICS 0x05
+#define TP_VARIANT_SYNAPTICS 0x06
/*
* Commands
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: trackpoint - add new trackpoint variant IDs
2020-09-09 8:36 [PATCH] Input: trackpoint - add new trackpoint variant IDs Vincent Huang
@ 2020-09-14 5:57 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2020-09-14 5:57 UTC (permalink / raw)
To: Vincent Huang; +Cc: linux-input, linux-kernel, Andrew Duggan
Hi Vincent,
On Wed, Sep 09, 2020 at 04:36:32PM +0800, Vincent Huang wrote:
> Add trackpoint variant IDs to allow supported control
> on Synaptics trackpoints
>
> Signed-off-by: Vincent Huang <vincent.huang@tw.synaptics.com>
> ---
> drivers/input/mouse/trackpoint.c | 2 ++
> drivers/input/mouse/trackpoint.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
> index 3eefee2ee2a1..c54d2f9e1c4a 100644
> --- a/drivers/input/mouse/trackpoint.c
> +++ b/drivers/input/mouse/trackpoint.c
> @@ -21,6 +21,8 @@ static const char * const trackpoint_variants[] = {
> [TP_VARIANT_ALPS] = "ALPS",
> [TP_VARIANT_ELAN] = "Elan",
> [TP_VARIANT_NXP] = "NXP",
> + [TP_VARIANT_JYT_SYNAPTICS] = "JYT_SYNAPTICS",
> + [TP_VARIANT_SYNAPTICS] = "SYNAPTICS",
Do these need to be capitalized? This is simply used in log messages, so
nicer formatted strings can be used.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-14 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 8:36 [PATCH] Input: trackpoint - add new trackpoint variant IDs Vincent Huang
2020-09-14 5:57 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).