* [PATCH] Input: adxl34x - clean up a data type in adxl34x_probe()
@ 2020-10-26 7:28 Dan Carpenter
2020-10-26 7:31 ` Hennerich, Michael
2020-10-27 0:10 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-10-26 7:28 UTC (permalink / raw)
To: Michael Hennerich; +Cc: Dmitry Torokhov, linux-input, kernel-janitors
The "revid" is used to store negative error codes so it should be an int
type.
Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital Accelerometers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/input/misc/adxl34x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
index 5fe92d4ba3f0..4cc4e8ff42b3 100644
--- a/drivers/input/misc/adxl34x.c
+++ b/drivers/input/misc/adxl34x.c
@@ -696,7 +696,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
struct input_dev *input_dev;
const struct adxl34x_platform_data *pdata;
int err, range, i;
- unsigned char revid;
+ int revid;
if (!irq) {
dev_err(dev, "no IRQ?\n");
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] Input: adxl34x - clean up a data type in adxl34x_probe()
2020-10-26 7:28 [PATCH] Input: adxl34x - clean up a data type in adxl34x_probe() Dan Carpenter
@ 2020-10-26 7:31 ` Hennerich, Michael
2020-10-27 0:10 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Hennerich, Michael @ 2020-10-26 7:31 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Dmitry Torokhov, linux-input, kernel-janitors
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Montag, 26. Oktober 2020 08:28
> To: Hennerich, Michael <Michael.Hennerich@analog.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>; linux-
> input@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [PATCH] Input: adxl34x - clean up a data type in adxl34x_probe()
>
> The "revid" is used to store negative error codes so it should be an int type.
>
> Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital
> Accelerometers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/input/misc/adxl34x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c index
> 5fe92d4ba3f0..4cc4e8ff42b3 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -696,7 +696,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int
> irq,
> struct input_dev *input_dev;
> const struct adxl34x_platform_data *pdata;
> int err, range, i;
> - unsigned char revid;
> + int revid;
>
> if (!irq) {
> dev_err(dev, "no IRQ?\n");
> --
> 2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: adxl34x - clean up a data type in adxl34x_probe()
2020-10-26 7:28 [PATCH] Input: adxl34x - clean up a data type in adxl34x_probe() Dan Carpenter
2020-10-26 7:31 ` Hennerich, Michael
@ 2020-10-27 0:10 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2020-10-27 0:10 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Michael Hennerich, linux-input, kernel-janitors
On Mon, Oct 26, 2020 at 10:28:24AM +0300, Dan Carpenter wrote:
> The "revid" is used to store negative error codes so it should be an int
> type.
>
> Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital Accelerometers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-27 0:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 7:28 [PATCH] Input: adxl34x - clean up a data type in adxl34x_probe() Dan Carpenter
2020-10-26 7:31 ` Hennerich, Michael
2020-10-27 0:10 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).