* [PATCH 1/3] Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP
@ 2020-10-29 7:52 Coiby Xu
2020-10-29 7:52 ` [PATCH 2/3] Input: adp5589: " Coiby Xu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Coiby Xu @ 2020-10-29 7:52 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: open list:INPUT (KEYBOARD, MOUSE, JOYSTICK , TOUCHSCREEN)..., open list
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
drivers/input/keyboard/pmic8xxx-keypad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c
index 91d5811d6f0e..c04ab04331b2 100644
--- a/drivers/input/keyboard/pmic8xxx-keypad.c
+++ b/drivers/input/keyboard/pmic8xxx-keypad.c
@@ -621,7 +621,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
static int pmic8xxx_kp_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
@@ -661,7 +660,6 @@ static int pmic8xxx_kp_resume(struct device *dev)
return 0;
}
-#endif
static SIMPLE_DEV_PM_OPS(pm8xxx_kp_pm_ops,
pmic8xxx_kp_suspend, pmic8xxx_kp_resume);
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/3] Input: adp5589: remove unnecessary CONFIG_PM_SLEEP
2020-10-29 7:52 [PATCH 1/3] Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
@ 2020-10-29 7:52 ` Coiby Xu
2020-10-29 7:52 ` [PATCH 3/3] Input: nomadik-ske-keypad: " Coiby Xu
2020-10-29 17:52 ` [PATCH 1/3] Input: pmic8xxx-keypad: " Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Coiby Xu @ 2020-10-29 7:52 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: open list:INPUT (KEYBOARD, MOUSE, JOYSTICK , TOUCHSCREEN)..., open list
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
drivers/input/keyboard/adp5589-keys.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard/adp5589-keys.c
index eb0e9cd66bcb..50f94984e055 100644
--- a/drivers/input/keyboard/adp5589-keys.c
+++ b/drivers/input/keyboard/adp5589-keys.c
@@ -1077,7 +1077,6 @@ static int adp5589_remove(struct i2c_client *client)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
static int adp5589_suspend(struct device *dev)
{
struct adp5589_kpad *kpad = dev_get_drvdata(dev);
@@ -1109,7 +1108,6 @@ static int adp5589_resume(struct device *dev)
return 0;
}
-#endif
static SIMPLE_DEV_PM_OPS(adp5589_dev_pm_ops, adp5589_suspend, adp5589_resume);
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] Input: nomadik-ske-keypad: remove unnecessary CONFIG_PM_SLEEP
2020-10-29 7:52 [PATCH 1/3] Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29 7:52 ` [PATCH 2/3] Input: adp5589: " Coiby Xu
@ 2020-10-29 7:52 ` Coiby Xu
2020-10-29 17:52 ` [PATCH 1/3] Input: pmic8xxx-keypad: " Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Coiby Xu @ 2020-10-29 7:52 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: open list:INPUT (KEYBOARD, MOUSE, JOYSTICK , TOUCHSCREEN)..., open list
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
drivers/input/keyboard/nomadik-ske-keypad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c
index 608446e14614..b3052c8fa5d2 100644
--- a/drivers/input/keyboard/nomadik-ske-keypad.c
+++ b/drivers/input/keyboard/nomadik-ske-keypad.c
@@ -386,7 +386,6 @@ static int ske_keypad_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
static int ske_keypad_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
@@ -414,7 +413,6 @@ static int ske_keypad_resume(struct device *dev)
return 0;
}
-#endif
static SIMPLE_DEV_PM_OPS(ske_keypad_dev_pm_ops,
ske_keypad_suspend, ske_keypad_resume);
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP
2020-10-29 7:52 [PATCH 1/3] Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29 7:52 ` [PATCH 2/3] Input: adp5589: " Coiby Xu
2020-10-29 7:52 ` [PATCH 3/3] Input: nomadik-ske-keypad: " Coiby Xu
@ 2020-10-29 17:52 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2020-10-29 17:52 UTC (permalink / raw)
To: Coiby Xu
Cc: open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..., open list
On Thu, Oct 29, 2020 at 03:52:34PM +0800, Coiby Xu wrote:
> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
Doesn't it result in "defined but not used" warnings if you compile
without CONFIG_PM? I believe if you are dropping #ifdef guards you need
to add __maybe_unused annotations.
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
> drivers/input/keyboard/pmic8xxx-keypad.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c
> index 91d5811d6f0e..c04ab04331b2 100644
> --- a/drivers/input/keyboard/pmic8xxx-keypad.c
> +++ b/drivers/input/keyboard/pmic8xxx-keypad.c
> @@ -621,7 +621,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> static int pmic8xxx_kp_suspend(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> @@ -661,7 +660,6 @@ static int pmic8xxx_kp_resume(struct device *dev)
>
> return 0;
> }
> -#endif
>
> static SIMPLE_DEV_PM_OPS(pm8xxx_kp_pm_ops,
> pmic8xxx_kp_suspend, pmic8xxx_kp_resume);
> --
> 2.28.0
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-29 17:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 7:52 [PATCH 1/3] Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29 7:52 ` [PATCH 2/3] Input: adp5589: " Coiby Xu
2020-10-29 7:52 ` [PATCH 3/3] Input: nomadik-ske-keypad: " Coiby Xu
2020-10-29 17:52 ` [PATCH 1/3] Input: pmic8xxx-keypad: " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).