From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: HyungJae Im <hj2.im@samsung.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"rydberg@bitmath.org" <rydberg@bitmath.org>,
Jungrae Kim <jryu.kim@samsung.com>
Subject: Re: [PATCH v2] input: add 2 kind of switch
Date: Thu, 29 Oct 2020 10:45:24 -0700 [thread overview]
Message-ID: <20201029174524.GC2547185@dtor-ws> (raw)
In-Reply-To: <20201029135715.GB3470996@kroah.com>
On Thu, Oct 29, 2020 at 02:57:15PM +0100, gregkh@linuxfoundation.org wrote:
> On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote:
> > From: "hj2.im" <hj2.im@samsung.com>
> > Date: Thu, 29 Oct 2020 22:11:24 +0900
> > Subject: [PATCH v2] input: add 2 kind of switch
>
> Why is this in the body of that patch?
>
> >
> > We need support to various accessories on the device,
> > some switch does not exist in switch list.
> > So added switch for the following purpose.
> >
> > SW_COVER_ATTACHED is for the checking the cover
> > attached or not on the device. SW_EXT_PEN_ATTACHED is for the
> > checking the external pen attached or not on the device
>
> You didn't answer the previous question as to why the existing values do
> not work for you instead of having to create new ones?
>
>
> >
> > Signed-off-by: Hyungjae Im <hj2.im@samsung.com>
> > ---
> > drivers/input/Kconfig | 20 ++
> > drivers/input/Makefile | 3 +
> > drivers/input/cover_detect.c | 242 ++++++++++++++++++++++++
> > drivers/input/ext_pen_detect.c | 243 +++++++++++++++++++++++++
> > include/linux/mod_devicetable.h | 2 +-
> > include/uapi/linux/input-event-codes.h | 4 +-
> > 6 files changed, 512 insertions(+), 2 deletions(-)
> > create mode 100644 drivers/input/cover_detect.c
> > create mode 100644 drivers/input/ext_pen_detect.c
>
> If this is v2, what changed from v1?
>
> And this is 2 different drivers, it should be 2 different patches at the
> least, right?>
Actually the should simply use gpio-keys.c for this and dispense with
the custom drivers.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-10-29 17:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201029132747epcms1p8fae559dff47bf0eebdcc9f94efd9a1bf@epcms1p8>
2020-10-29 13:27 ` [PATCH v2] input: add 2 kind of switch HyungJae Im
2020-10-29 13:41 ` Barnabás Pőcze
2020-10-29 13:54 ` gregkh
2020-10-29 14:36 ` Barnabás Pőcze
2020-10-29 13:57 ` gregkh
2020-10-29 17:45 ` Dmitry Torokhov [this message]
[not found] ` <CGME20201029132747epcms1p8fae559dff47bf0eebdcc9f94efd9a1bf@epcms1p3>
2020-10-30 4:39 ` HyungJae Im
2020-10-30 10:46 ` (2) " gregkh
[not found] ` <CGME20201029132747epcms1p8fae559dff47bf0eebdcc9f94efd9a1bf@epcms1p7>
2020-10-30 11:28 ` (3) " Jungrae Kim
2020-10-30 11:41 ` gregkh
[not found] ` <CGME20201029132747epcms1p8fae559dff47bf0eebdcc9f94efd9a1bf@epcms1p4>
2020-10-30 11:59 ` Jungrae Kim
2020-10-30 12:19 ` gregkh
[not found] ` <CGME20201029132747epcms1p8fae559dff47bf0eebdcc9f94efd9a1bf@epcms1p2>
2020-10-30 13:15 ` [PATCH] Input: add SW_COVER_ATTACHED and SW_EXT_PEN_ATTACHED Jungrae Kim
2020-10-30 15:41 ` Sebastian Reichel
2020-10-30 15:54 ` Jungrae Kim
2020-11-02 12:35 ` [PATCH v2] input: add 2 kind of switch kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029174524.GC2547185@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hj2.im@samsung.com \
--cc=jryu.kim@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).