* [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input
@ 2020-11-04 16:24 Lee Jones
2020-11-04 16:24 ` [PATCH 01/20] input: rmi4: rmi_bus: Fix misnaming of '__rmi_register_function_handler's 'owner' param Lee Jones
` (20 more replies)
0 siblings, 21 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andrew Duggan, Arjan Opmeer, at www.cypress.com,
Benson Leung, Bruce Kalk, Christopher Heiny, C. Scott Ananian,
Daniel Kurtz, Dan Murphy, David Jander, Dmitry Torokhov,
Dudley Du, dusonlin, Enric Balletbo i Serra, Eugen Hristev,
Ferruh Yigit, Guenter Roeck, Gustavo A. R. Silva, Hans de Goede,
Henrik Rydberg, KT Liao, Kumar G, linux-input, Peter Osterlund,
Phil Blundell, Stefan Gmeiner, Sundar Iyer, Trilok Soni,
Vincent Huang
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This is the first of 2 sets.
Lee Jones (20):
input: rmi4: rmi_bus: Fix misnaming of
'__rmi_register_function_handler's 'owner' param
input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format
input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc
header
input: rmi4: rmi_f01: Struct headers are expected to start with
'struct <name>'
include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused
input: keyboard: cros_ec_keyb: Struct headers should start with
'struct <name>'
input: rmi4: rmi_f11: Struct headers are expected to start with
'struct <name>'
input: touchscreen: resistive-adc-touch: Struct headers should start
with 'struct <name>'
input: mouse: synaptics: Place braces around empty if() body
input: keyboard: gpio_keys: Fix misnamed function parameter 'dev'
input: mouse: elantech: Demote obvious abuse of kernel-doc header
input: rmi4: rmi_f54: Provide some missing 'REPORT_TYPE' enums
input: rmi4: rmi_i2c: Provide some missing descriptions for struct
members
input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to
the only file that references it
input: misc: drv260x: Fix kernel-doc formatting and remove one abuse
input: misc: drv2665: Fix formatting expected by kernel-doc
input: misc: drv2667: Fix formatting and add missing member docs
input: keyboard: nomadik-ske-keypad: Provide some missing struct
member docs
input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting
drivers/input/keyboard/cros_ec_keyb.c | 5 ++--
drivers/input/keyboard/gpio_keys.c | 2 +-
drivers/input/keyboard/nomadik-ske-keypad.c | 2 ++
drivers/input/keyboard/pmic8xxx-keypad.c | 22 ++++++++--------
drivers/input/misc/ab8500-ponkey.c | 2 +-
drivers/input/misc/drv260x.c | 26 +++++++++----------
drivers/input/misc/drv2665.c | 10 +++----
drivers/input/misc/drv2667.c | 14 +++++-----
drivers/input/mouse/cyapa.c | 2 +-
drivers/input/mouse/cyapa_gen5.c | 4 +--
drivers/input/mouse/elantech.c | 2 +-
drivers/input/mouse/synaptics.c | 3 ++-
drivers/input/rmi4/rmi_bus.c | 2 +-
drivers/input/rmi4/rmi_f01.c | 1 +
drivers/input/rmi4/rmi_f11.c | 5 ++--
drivers/input/rmi4/rmi_f54.c | 6 +++++
drivers/input/rmi4/rmi_i2c.c | 4 +++
drivers/input/touchscreen/cyttsp4_core.c | 14 ++++++++++
drivers/input/touchscreen/cyttsp4_core.h | 14 ----------
.../input/touchscreen/resistive-adc-touch.c | 2 +-
include/linux/input/elan-i2c-ids.h | 2 +-
21 files changed, 80 insertions(+), 64 deletions(-)
Cc: Andrew Duggan <aduggan@synaptics.com>
Cc: Arjan Opmeer <arjan@opmeer.net>
Cc: "at www.cypress.com" <ttdrivers@cypress.com>
Cc: Benson Leung <bleung@chromium.org>
Cc: Bruce Kalk <kall@compass.com>
Cc: Christopher Heiny <cheiny@synaptics.com>
Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu>
Cc: Daniel Kurtz <djkurtz@chromium.org>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: David Jander <david@protonic.nl>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dudley Du <dudl@cypress.com>
Cc: dusonlin@emc.com.tw
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Eugen Hristev <eugen.hristev@microchip.com>
Cc: Ferruh Yigit <fery@cypress.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: KT Liao <kt.liao@emc.com.tw>
Cc: Kumar G <naveen.gaddipati@stericsson.com>
Cc: linux-input@vger.kernel.org
Cc: Peter Osterlund <petero2@telia.com>
Cc: Phil Blundell <pb@handhelds.org>
Cc: Stefan Gmeiner <riddlebox@freesurf.ch>
Cc: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: this to <linux-input@vger.kernel.org>
Cc: Trilok Soni <tsoni@codeaurora.org>
Cc: Vincent Huang <vincent.huang@tw.synaptics.com>
--
2.25.1
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 01/20] input: rmi4: rmi_bus: Fix misnaming of '__rmi_register_function_handler's 'owner' param
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-04 16:24 ` [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param Lee Jones
` (19 subsequent siblings)
20 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Vincent Huang, Hans de Goede,
Andrew Duggan, Christopher Heiny, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/rmi4/rmi_bus.c:299: warning: Function parameter or member 'owner' not described in '__rmi_register_function_handler'
drivers/input/rmi4/rmi_bus.c:299: warning: Excess function parameter 'module' description in '__rmi_register_function_handler'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Vincent Huang <vincent.huang@tw.synaptics.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andrew Duggan <aduggan@synaptics.com>
Cc: Christopher Heiny <cheiny@synaptics.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/rmi4/rmi_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
index 47d1b97ed6cf3..24f31a5c0e04a 100644
--- a/drivers/input/rmi4/rmi_bus.c
+++ b/drivers/input/rmi4/rmi_bus.c
@@ -286,7 +286,7 @@ void rmi_unregister_function(struct rmi_function *fn)
/**
* rmi_register_function_handler - register a handler for an RMI function
* @handler: RMI handler that should be registered.
- * @module: pointer to module that implements the handler
+ * @owner: pointer to module that implements the handler
* @mod_name: name of the module implementing the handler
*
* This function performs additional setup of RMI function handler and
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
2020-11-04 16:24 ` [PATCH 01/20] input: rmi4: rmi_bus: Fix misnaming of '__rmi_register_function_handler's 'owner' param Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-04 17:14 ` Benson Leung
2020-11-09 6:31 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 03/20] input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format Lee Jones
` (18 subsequent siblings)
20 siblings, 2 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg, Dudley Du,
Daniel Kurtz, Benson Leung, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' not described in 'cyapa_i2c_write'
drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' description in 'cyapa_i2c_write'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Dudley Du <dudl@cypress.com>
Cc: Daniel Kurtz <djkurtz@chromium.org>
Cc: Benson Leung <bleung@chromium.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/mouse/cyapa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
index c675f156948b5..dacf7c0e43f98 100644
--- a/drivers/input/mouse/cyapa.c
+++ b/drivers/input/mouse/cyapa.c
@@ -119,7 +119,7 @@ static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 reg, size_t len,
/**
* cyapa_i2c_write - Execute i2c block data write operation
* @cyapa: Handle to this driver
- * @ret: Offset of the data to written in the register map
+ * @reg: Offset of the data to written in the register map
* @len: number of bytes to write
* @values: Data to be written
*
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 03/20] input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
2020-11-04 16:24 ` [PATCH 01/20] input: rmi4: rmi_bus: Fix misnaming of '__rmi_register_function_handler's 'owner' param Lee Jones
2020-11-04 16:24 ` [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:32 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 04/20] input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc header Lee Jones
` (17 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg,
Gustavo A. R. Silva, Dudley Du, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'cyapa' not described in 'cyapa_i2c_pip_write'
drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'buf' not described in 'cyapa_i2c_pip_write'
drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'size' not described in 'cyapa_i2c_pip_write'
drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'cyapa' not described in 'cyapa_empty_pip_output_data'
drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'buf' not described in 'cyapa_empty_pip_output_data'
drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'len' not described in 'cyapa_empty_pip_output_data'
drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'func' not described in 'cyapa_empty_pip_output_data'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Dudley Du <dudl@cypress.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/mouse/cyapa_gen5.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c
index bb3a63d1268d1..5c37af994b5b5 100644
--- a/drivers/input/mouse/cyapa_gen5.c
+++ b/drivers/input/mouse/cyapa_gen5.c
@@ -385,7 +385,7 @@ ssize_t cyapa_i2c_pip_read(struct cyapa *cyapa, u8 *buf, size_t size)
return size;
}
-/**
+/*
* Return a negative errno code else zero on success.
*/
ssize_t cyapa_i2c_pip_write(struct cyapa *cyapa, u8 *buf, size_t size)
@@ -435,7 +435,7 @@ static enum cyapa_pm_stage cyapa_get_pip_pm_state(struct cyapa *cyapa)
return pm_stage;
}
-/**
+/*
* This function is aimed to dump all not read data in Gen5 trackpad
* before send any command, otherwise, the interrupt line will be blocked.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 04/20] input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc header
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (2 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 03/20] input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:32 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 05/20] input: rmi4: rmi_f01: Struct headers are expected to start with 'struct <name>' Lee Jones
` (16 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Dmitry Torokhov, Sundar Iyer, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/misc/ab8500-ponkey.c:32: warning: Function parameter or member 'idev' not described in 'ab8500_ponkey'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/misc/ab8500-ponkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c
index ea3b8292acdd5..a9b9013680d62 100644
--- a/drivers/input/misc/ab8500-ponkey.c
+++ b/drivers/input/misc/ab8500-ponkey.c
@@ -19,7 +19,7 @@
/**
* struct ab8500_ponkey - ab8500 ponkey information
- * @input_dev: pointer to input device
+ * @idev: pointer to input device
* @ab8500: ab8500 parent
* @irq_dbf: irq number for falling transition
* @irq_dbr: irq number for rising transition
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 05/20] input: rmi4: rmi_f01: Struct headers are expected to start with 'struct <name>'
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (3 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 04/20] input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc header Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-10 0:49 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused Lee Jones
` (15 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Dmitry Torokhov, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/rmi4/rmi_f01.c:106: warning: Cannot understand * @ctrl0 - see the bit definitions above.
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/rmi4/rmi_f01.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index e623c956376e3..23618fcb1f322 100644
--- a/drivers/input/rmi4/rmi_f01.c
+++ b/drivers/input/rmi4/rmi_f01.c
@@ -103,6 +103,7 @@ struct f01_basic_properties {
#define RMI_F01_CTRL0_CONFIGURED_BIT BIT(7)
/**
+ * struct f01_device_control
* @ctrl0 - see the bit definitions above.
* @doze_interval - controls the interval between checks for finger presence
* when the touch sensor is in doze mode, in units of 10ms.
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (4 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 05/20] input: rmi4: rmi_f01: Struct headers are expected to start with 'struct <name>' Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-04 22:50 ` Dmitry Torokhov
2020-11-12 10:44 ` [PATCH] input: mouse: elan_i2c_core: Move header inclusion inside Lee Jones
2020-11-04 16:24 ` [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct <name>' Lee Jones
` (14 subsequent siblings)
20 siblings, 2 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Dmitry Torokhov, dusonlin, KT Liao, linux-input
Some drivers which include 'elan-i2c-ids.h' make use of
'elan_acpi_id', but not all do. Tell the compiler that this is
expected behaviour.
Fixes the following W=1 kernel build warning(s):
include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=]
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: dusonlin@emc.com.tw
Cc: KT Liao <kt.liao@emc.com.tw>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
include/linux/input/elan-i2c-ids.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/input/elan-i2c-ids.h b/include/linux/input/elan-i2c-ids.h
index 520858d126808..b6976d99b6b75 100644
--- a/include/linux/input/elan-i2c-ids.h
+++ b/include/linux/input/elan-i2c-ids.h
@@ -23,7 +23,7 @@
#include <linux/mod_devicetable.h>
-static const struct acpi_device_id elan_acpi_id[] = {
+static const struct acpi_device_id __maybe_unused elan_acpi_id[] = {
{ "ELAN0000", 0 },
{ "ELAN0100", 0 },
{ "ELAN0600", 0 },
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct <name>'
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (5 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-04 17:15 ` Benson Leung
2020-11-04 16:24 ` [PATCH 08/20] input: rmi4: rmi_f11: Struct headers are expected to " Lee Jones
` (13 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Benson Leung,
Enric Balletbo i Serra, Guenter Roeck, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/keyboard/cros_ec_keyb.c:72: warning: cannot understand function prototype: 'struct cros_ec_bs_map '
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benson Leung <bleung@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/keyboard/cros_ec_keyb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
index 15d17c7170816..fce0c839e1430 100644
--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -58,10 +58,9 @@ struct cros_ec_keyb {
struct notifier_block notifier;
};
-
/**
- * cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch bitmap
- * #defines
+ * struct cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch
+ * bitmap #defines
*
* @ev_type: The type of the input event to generate (e.g., EV_KEY).
* @code: A linux keycode
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 08/20] input: rmi4: rmi_f11: Struct headers are expected to start with 'struct <name>'
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (6 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct <name>' Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-04 16:24 ` [PATCH 09/20] input: touchscreen: resistive-adc-touch: Struct headers should " Lee Jones
` (12 subsequent siblings)
20 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg, Andrew Duggan,
linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/rmi4/rmi_f11.c:66: warning: Cannot understand * @rezero - writing this to the F11 command register will cause the sensor to
drivers/input/rmi4/rmi_f11.c:311: warning: cannot understand function prototype: 'struct f11_2d_sensor_queries '
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Andrew Duggan <aduggan@synaptics.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/rmi4/rmi_f11.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
index ffa39ab153f2a..38baf39ce0916 100644
--- a/drivers/input/rmi4/rmi_f11.c
+++ b/drivers/input/rmi4/rmi_f11.c
@@ -62,7 +62,7 @@
/* maximum ABS_MT_POSITION displacement (in mm) */
#define DMAX 10
-/**
+/*
* @rezero - writing this to the F11 command register will cause the sensor to
* calibrate to the current capacitive state.
*/
@@ -178,7 +178,8 @@
#define F11_UNIFORM_CLICKPAD 0x02
/**
- * Query registers 1 through 4 are always present.
+ * struct f11_2d_sensor_queries - Query registers 1 through 4 are always
+ * present.
*
* @nr_fingers - describes the maximum number of fingers the 2-D sensor
* supports.
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 09/20] input: touchscreen: resistive-adc-touch: Struct headers should start with 'struct <name>'
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (7 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 08/20] input: rmi4: rmi_f11: Struct headers are expected to " Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:33 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body Lee Jones
` (11 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Eugen Hristev, Dmitry Torokhov, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/resistive-adc-touch.c:34: warning: cannot understand function prototype: 'struct grts_state '
Cc: Eugen Hristev <eugen.hristev@microchip.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/touchscreen/resistive-adc-touch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/resistive-adc-touch.c b/drivers/input/touchscreen/resistive-adc-touch.c
index cfc8bb4553f78..e50af30183f4e 100644
--- a/drivers/input/touchscreen/resistive-adc-touch.c
+++ b/drivers/input/touchscreen/resistive-adc-touch.c
@@ -23,7 +23,7 @@
#define GRTS_MAX_POS_MASK GENMASK(11, 0)
/**
- * grts_state - generic resistive touch screen information struct
+ * struct grts_state - generic resistive touch screen information struct
* @pressure_min: number representing the minimum for the pressure
* @pressure: are we getting pressure info or not
* @iio_chans: list of channels acquired
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (8 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 09/20] input: touchscreen: resistive-adc-touch: Struct headers should " Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-06 7:26 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 11/20] input: keyboard: gpio_keys: Fix misnamed function parameter 'dev' Lee Jones
` (10 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg, Peter Osterlund,
Stefan Gmeiner, C. Scott Ananian, Bruce Kalk, this to
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Stefan Gmeiner <riddlebox@freesurf.ch>
Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu>
Cc: Bruce Kalk <kall@compass.com>
Cc: this to <linux-input@vger.kernel.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/mouse/synaptics.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 82577095e175e..07835939d83b9 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse)
num_fingers = hw.w + 2;
break;
case 2:
- if (SYN_MODEL_PEN(info->model_id))
+ if (SYN_MODEL_PEN(info->model_id)) {
; /* Nothing, treat a pen as a single finger */
+ }
break;
case 4 ... 15:
if (SYN_CAP_PALMDETECT(info->capabilities))
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 11/20] input: keyboard: gpio_keys: Fix misnamed function parameter 'dev'
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (9 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:25 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 12/20] input: mouse: elantech: Demote obvious abuse of kernel-doc header Lee Jones
` (9 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Gustavo A. R. Silva, David Jander,
Phil Blundell, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/keyboard/gpio_keys.c:119: warning: Function parameter or member 'dev' not described in 'get_bm_events_by_type'
drivers/input/keyboard/gpio_keys.c:119: warning: Excess function parameter 'input' description in 'get_bm_events_by_type'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: David Jander <david@protonic.nl>
Cc: Phil Blundell <pb@handhelds.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/keyboard/gpio_keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index f2d4e4daa818f..a079504e98e82 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -108,7 +108,7 @@ static int get_n_events_by_type(int type)
/**
* get_bm_events_by_type() - returns bitmap of supported events per @type
- * @input: input device from which bitmap is retrieved
+ * @dev: input device from which bitmap is retrieved
* @type: type of button (%EV_KEY, %EV_SW)
*
* Return value of this function can be used to allocate bitmap
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 12/20] input: mouse: elantech: Demote obvious abuse of kernel-doc header
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (10 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 11/20] input: keyboard: gpio_keys: Fix misnamed function parameter 'dev' Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:25 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 13/20] input: rmi4: rmi_f54: Provide some missing 'REPORT_TYPE' enums Lee Jones
` (8 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg, Arjan Opmeer, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'psmouse' not described in 'elantech_setup_smbus'
drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'info' not described in 'elantech_setup_smbus'
drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'leave_breadcrumbs' not described in 'elantech_setup_smbus'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Arjan Opmeer <arjan@opmeer.net>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/mouse/elantech.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 90f8765f9efc8..47cd0e7f79bd1 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1827,7 +1827,7 @@ static int elantech_create_smbus(struct psmouse *psmouse,
leave_breadcrumbs);
}
-/**
+/*
* elantech_setup_smbus - called once the PS/2 devices are enumerated
* and decides to instantiate a SMBus InterTouch device.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 13/20] input: rmi4: rmi_f54: Provide some missing 'REPORT_TYPE' enums
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (11 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 12/20] input: mouse: elantech: Demote obvious abuse of kernel-doc header Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-04 16:24 ` [PATCH 14/20] input: rmi4: rmi_i2c: Provide some missing descriptions for struct members Lee Jones
` (7 subsequent siblings)
20 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Dmitry Torokhov, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/rmi4/rmi_f54.c:77: warning: Enum value 'F54_REPORT_NONE' not described in enum 'rmi_f54_report_type'
drivers/input/rmi4/rmi_f54.c:77: warning: Enum value 'F54_MAX_REPORT_TYPE' not described in enum 'rmi_f54_report_type'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/rmi4/rmi_f54.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
index 6b23e679606ee..93b328c796c64 100644
--- a/drivers/input/rmi4/rmi_f54.c
+++ b/drivers/input/rmi4/rmi_f54.c
@@ -42,6 +42,8 @@
/**
* enum rmi_f54_report_type - RMI4 F54 report types
*
+ * @F54_REPORT_NONE: No Image Report.
+ *
* @F54_8BIT_IMAGE: Normalized 8-Bit Image Report. The capacitance variance
* from baseline for each pixel.
*
@@ -64,6 +66,10 @@
* Report. Set Low reference to its minimum value and high
* references to its maximum value, then report the raw
* capacitance for each pixel.
+ *
+ * @F54_MAX_REPORT_TYPE:
+ * Maximum number of Report Types. Used for sanity
+ * checking.
*/
enum rmi_f54_report_type {
F54_REPORT_NONE = 0,
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 14/20] input: rmi4: rmi_i2c: Provide some missing descriptions for struct members
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (12 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 13/20] input: rmi4: rmi_f54: Provide some missing 'REPORT_TYPE' enums Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-04 16:24 ` [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it Lee Jones
` (6 subsequent siblings)
20 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Christopher Heiny, Andrew Duggan,
linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/rmi4/rmi_i2c.c:39: warning: Function parameter or member 'client' not described in 'rmi_i2c_xport'
drivers/input/rmi4/rmi_i2c.c:39: warning: Function parameter or member 'supplies' not described in 'rmi_i2c_xport'
drivers/input/rmi4/rmi_i2c.c:39: warning: Function parameter or member 'startup_delay' not described in 'rmi_i2c_xport'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Christopher Heiny <cheiny@synaptics.com>
Cc: Andrew Duggan <aduggan@synaptics.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/rmi4/rmi_i2c.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/input/rmi4/rmi_i2c.c b/drivers/input/rmi4/rmi_i2c.c
index a95c2c9bcab4c..50305fcfbef59 100644
--- a/drivers/input/rmi4/rmi_i2c.c
+++ b/drivers/input/rmi4/rmi_i2c.c
@@ -17,12 +17,16 @@
* struct rmi_i2c_xport - stores information for i2c communication
*
* @xport: The transport interface structure
+ * @client: The I2C client device structure
*
* @page_mutex: Locks current page to avoid changing pages in unexpected ways.
* @page: Keeps track of the current virtual page
*
* @tx_buf: Buffer used for transmitting data to the sensor over i2c.
* @tx_buf_size: Size of the buffer
+ *
+ * @supplies: Array of voltage regulators
+ * @startup_delay: Milliseconds to pause after powering up the regulators
*/
struct rmi_i2c_xport {
struct rmi_transport_dev xport;
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (13 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 14/20] input: rmi4: rmi_i2c: Provide some missing descriptions for struct members Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:36 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 16/20] input: misc: drv260x: Fix kernel-doc formatting and remove one abuse Lee Jones
` (5 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Ferruh Yigit, Dmitry Torokhov, at www.cypress.com,
linux-input
Fixes the following W=1 kernel build warning(s):
In file included from drivers/input/touchscreen/cyttsp_i2c_common.c:24:
drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
236 | static const char const cyttsp4_tch_abs_string[] = {
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/input/touchscreen/cyttsp4_i2c.c:17:
drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
236 | static const char * const cyttsp4_tch_abs_string[] = {
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/input/touchscreen/cyttsp4_spi.c:17:
drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
236 | static const char * const cyttsp4_tch_abs_string[] = {
| ^~~~~~~~~~~~~~~~~~~~~~
Cc: Ferruh Yigit <fery@cypress.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "at www.cypress.com" <ttdrivers@cypress.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/touchscreen/cyttsp4_core.c | 14 ++++++++++++++
drivers/input/touchscreen/cyttsp4_core.h | 14 --------------
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp4_core.c b/drivers/input/touchscreen/cyttsp4_core.c
index 02a73d9a4defe..dccbcb942fe59 100644
--- a/drivers/input/touchscreen/cyttsp4_core.c
+++ b/drivers/input/touchscreen/cyttsp4_core.c
@@ -30,6 +30,20 @@
#define CY_CORE_STARTUP_RETRY_COUNT 3
+static const char * const cyttsp4_tch_abs_string[] = {
+ [CY_TCH_X] = "X",
+ [CY_TCH_Y] = "Y",
+ [CY_TCH_P] = "P",
+ [CY_TCH_T] = "T",
+ [CY_TCH_E] = "E",
+ [CY_TCH_O] = "O",
+ [CY_TCH_W] = "W",
+ [CY_TCH_MAJ] = "MAJ",
+ [CY_TCH_MIN] = "MIN",
+ [CY_TCH_OR] = "OR",
+ [CY_TCH_NUM_ABS] = "INVALID"
+};
+
static const u8 ldr_exit[] = {
0xFF, 0x01, 0x3B, 0x00, 0x00, 0x4F, 0x6D, 0x17
};
diff --git a/drivers/input/touchscreen/cyttsp4_core.h b/drivers/input/touchscreen/cyttsp4_core.h
index f3e4443594404..6262f6e450751 100644
--- a/drivers/input/touchscreen/cyttsp4_core.h
+++ b/drivers/input/touchscreen/cyttsp4_core.h
@@ -233,20 +233,6 @@ enum cyttsp4_tch_abs { /* for ordering within the extracted touch data array */
CY_TCH_NUM_ABS
};
-static const char * const cyttsp4_tch_abs_string[] = {
- [CY_TCH_X] = "X",
- [CY_TCH_Y] = "Y",
- [CY_TCH_P] = "P",
- [CY_TCH_T] = "T",
- [CY_TCH_E] = "E",
- [CY_TCH_O] = "O",
- [CY_TCH_W] = "W",
- [CY_TCH_MAJ] = "MAJ",
- [CY_TCH_MIN] = "MIN",
- [CY_TCH_OR] = "OR",
- [CY_TCH_NUM_ABS] = "INVALID"
-};
-
struct cyttsp4_touch {
int abs[CY_TCH_NUM_ABS];
};
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 16/20] input: misc: drv260x: Fix kernel-doc formatting and remove one abuse
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (14 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:13 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 17/20] input: misc: drv2665: Fix formatting expected by kernel-doc Lee Jones
` (4 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Dmitry Torokhov, Dan Murphy, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'input_dev' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'client' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'regmap' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'work' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'enable_gpio' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'regulator' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'magnitude' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'mode' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'library' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'rated_voltage' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'overdrive_voltage' not described in 'drv260x_data'
drivers/input/misc/drv260x.c:244: warning: Function parameter or member 'voltage' not described in 'drv260x_calculate_voltage'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/misc/drv260x.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index 79d7fa710a714..fabe106d499d4 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -167,17 +167,17 @@
/**
* struct drv260x_data -
- * @input_dev - Pointer to the input device
- * @client - Pointer to the I2C client
- * @regmap - Register map of the device
- * @work - Work item used to off load the enable/disable of the vibration
- * @enable_gpio - Pointer to the gpio used for enable/disabling
- * @regulator - Pointer to the regulator for the IC
- * @magnitude - Magnitude of the vibration event
- * @mode - The operating mode of the IC (LRA_NO_CAL, ERM or LRA)
- * @library - The vibration library to be used
- * @rated_voltage - The rated_voltage of the actuator
- * @overdriver_voltage - The over drive voltage of the actuator
+ * @input_dev: Pointer to the input device
+ * @client: Pointer to the I2C client
+ * @regmap: Register map of the device
+ * @work: Work item used to off load the enable/disable of the vibration
+ * @enable_gpio: Pointer to the gpio used for enable/disabling
+ * @regulator: Pointer to the regulator for the IC
+ * @magnitude: Magnitude of the vibration event
+ * @mode: The operating mode of the IC (LRA_NO_CAL, ERM or LRA)
+ * @library: The vibration library to be used
+ * @rated_voltage: The rated_voltage of the actuator
+ * @overdriver_voltage: The over drive voltage of the actuator
**/
struct drv260x_data {
struct input_dev *input_dev;
@@ -234,12 +234,12 @@ static const struct reg_default drv260x_reg_defs[] = {
#define DRV260X_DEF_RATED_VOLT 0x90
#define DRV260X_DEF_OD_CLAMP_VOLT 0x90
-/**
+/*
* Rated and Overdriver Voltages:
* Calculated using the formula r = v * 255 / 5.6
* where r is what will be written to the register
* and v is the rated or overdriver voltage of the actuator
- **/
+ */
static int drv260x_calculate_voltage(unsigned int voltage)
{
return (voltage * 255 / 5600);
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 17/20] input: misc: drv2665: Fix formatting expected by kernel-doc
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (15 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 16/20] input: misc: drv260x: Fix kernel-doc formatting and remove one abuse Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:16 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 18/20] input: misc: drv2667: Fix formatting and add missing member docs Lee Jones
` (3 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Dmitry Torokhov, Dan Murphy, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'input_dev' not described in 'drv2665_data'
drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'client' not described in 'drv2665_data'
drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'regmap' not described in 'drv2665_data'
drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'work' not described in 'drv2665_data'
drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'regulator' not described in 'drv2665_data'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/misc/drv2665.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/input/misc/drv2665.c b/drivers/input/misc/drv2665.c
index 918ad9c3fa812..0e65ab180f499 100644
--- a/drivers/input/misc/drv2665.c
+++ b/drivers/input/misc/drv2665.c
@@ -44,11 +44,11 @@
/**
* struct drv2665_data -
- * @input_dev - Pointer to the input device
- * @client - Pointer to the I2C client
- * @regmap - Register map of the device
- * @work - Work item used to off load the enable/disable of the vibration
- * @regulator - Pointer to the regulator for the IC
+ * @input_dev: Pointer to the input device
+ * @client: Pointer to the I2C client
+ * @regmap: Register map of the device
+ * @work: Work item used to off load the enable/disable of the vibration
+ * @regulator: Pointer to the regulator for the IC
*/
struct drv2665_data {
struct input_dev *input_dev;
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 18/20] input: misc: drv2667: Fix formatting and add missing member docs
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (16 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 17/20] input: misc: drv2665: Fix formatting expected by kernel-doc Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:17 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 19/20] input: keyboard: nomadik-ske-keypad: Provide some missing struct " Lee Jones
` (2 subsequent siblings)
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Dmitry Torokhov, Dan Murphy, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'input_dev' not described in 'drv2667_data'
drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'client' not described in 'drv2667_data'
drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'regmap' not described in 'drv2667_data'
drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'work' not described in 'drv2667_data'
drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'regulator' not described in 'drv2667_data'
drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'page' not described in 'drv2667_data'
drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'magnitude' not described in 'drv2667_data'
drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'frequency' not described in 'drv2667_data'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/misc/drv2667.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c
index bb9d5784df17d..dc19eb6a8713f 100644
--- a/drivers/input/misc/drv2667.c
+++ b/drivers/input/misc/drv2667.c
@@ -90,12 +90,14 @@
/**
* struct drv2667_data -
- * @input_dev - Pointer to the input device
- * @client - Pointer to the I2C client
- * @regmap - Register map of the device
- * @work - Work item used to off load the enable/disable of the vibration
- * @regulator - Pointer to the regulator for the IC
- * @magnitude - Magnitude of the vibration event
+ * @input_dev: Pointer to the input device
+ * @client: Pointer to the I2C client
+ * @regmap: Register map of the device
+ * @work: Work item used to off load the enable/disable of the vibration
+ * @regulator: Pointer to the regulator for the IC
+ * @page: Page number
+ * @magnitude: Magnitude of the vibration event
+ * @frequency: Frequency of the vibration event
**/
struct drv2667_data {
struct input_dev *input_dev;
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 19/20] input: keyboard: nomadik-ske-keypad: Provide some missing struct member docs
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (17 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 18/20] input: misc: drv2667: Fix formatting and add missing member docs Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 6:18 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 20/20] input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting Lee Jones
2020-11-06 13:24 ` [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Kumar G, Sundar Iyer, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'pclk' not described in 'ske_keypad'
drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'ske_keypad_lock' not described in 'ske_keypad'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Kumar G <naveen.gaddipati@stericsson.com>
Cc: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/keyboard/nomadik-ske-keypad.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c
index 608446e14614d..0d55a95347f16 100644
--- a/drivers/input/keyboard/nomadik-ske-keypad.c
+++ b/drivers/input/keyboard/nomadik-ske-keypad.c
@@ -58,6 +58,8 @@
* @board: keypad platform device
* @keymap: matrix scan code table for keycodes
* @clk: clock structure pointer
+ * @pclk: clock structure pointer
+ * @ske_keypad_lock: spinlock protecting the keypad read/writes
*/
struct ske_keypad {
int irq;
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 20/20] input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (18 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 19/20] input: keyboard: nomadik-ske-keypad: Provide some missing struct " Lee Jones
@ 2020-11-04 16:24 ` Lee Jones
2020-11-09 22:02 ` Dmitry Torokhov
2020-11-06 13:24 ` [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
20 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-04 16:24 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Dmitry Torokhov, Trilok Soni, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'num_rows' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'num_cols' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'input' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'regmap' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'key_sense_irq' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'key_stuck_irq' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'keycodes' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'dev' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'keystate' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'stuckstate' not described in 'pmic8xxx_kp'
drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'ctrl_reg' not described in 'pmic8xxx_kp'
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Trilok Soni <tsoni@codeaurora.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/keyboard/pmic8xxx-keypad.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c
index 91d5811d6f0e1..36bee6f5a8af0 100644
--- a/drivers/input/keyboard/pmic8xxx-keypad.c
+++ b/drivers/input/keyboard/pmic8xxx-keypad.c
@@ -76,17 +76,17 @@
/**
* struct pmic8xxx_kp - internal keypad data structure
- * @num_cols - number of columns of keypad
- * @num_rows - number of row of keypad
- * @input - input device pointer for keypad
- * @regmap - regmap handle
- * @key_sense_irq - key press/release irq number
- * @key_stuck_irq - key stuck notification irq number
- * @keycodes - array to hold the key codes
- * @dev - parent device pointer
- * @keystate - present key press/release state
- * @stuckstate - present state when key stuck irq
- * @ctrl_reg - control register value
+ * @num_cols: number of columns of keypad
+ * @num_rows: number of row of keypad
+ * @input: input device pointer for keypad
+ * @regmap: regmap handle
+ * @key_sense_irq: key press/release irq number
+ * @key_stuck_irq: key stuck notification irq number
+ * @keycodes: array to hold the key codes
+ * @dev: parent device pointer
+ * @keystate: present key press/release state
+ * @stuckstate: present state when key stuck irq
+ * @ctrl_reg: control register value
*/
struct pmic8xxx_kp {
unsigned int num_rows;
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* Re: [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
2020-11-04 16:24 ` [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param Lee Jones
@ 2020-11-04 17:14 ` Benson Leung
2020-11-09 6:31 ` Dmitry Torokhov
1 sibling, 0 replies; 48+ messages in thread
From: Benson Leung @ 2020-11-04 17:14 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg, Dudley Du,
Daniel Kurtz, Benson Leung, linux-input
[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]
Hi Lee,
On Wed, Nov 04, 2020 at 04:24:09PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' not described in 'cyapa_i2c_write'
> drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' description in 'cyapa_i2c_write'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Dudley Du <dudl@cypress.com>
> Cc: Daniel Kurtz <djkurtz@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/input/mouse/cyapa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
> index c675f156948b5..dacf7c0e43f98 100644
> --- a/drivers/input/mouse/cyapa.c
> +++ b/drivers/input/mouse/cyapa.c
> @@ -119,7 +119,7 @@ static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 reg, size_t len,
> /**
> * cyapa_i2c_write - Execute i2c block data write operation
> * @cyapa: Handle to this driver
> - * @ret: Offset of the data to written in the register map
> + * @reg: Offset of the data to written in the register map
> * @len: number of bytes to write
> * @values: Data to be written
> *
> --
> 2.25.1
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct <name>'
2020-11-04 16:24 ` [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct <name>' Lee Jones
@ 2020-11-04 17:15 ` Benson Leung
0 siblings, 0 replies; 48+ messages in thread
From: Benson Leung @ 2020-11-04 17:15 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Dmitry Torokhov, Benson Leung,
Enric Balletbo i Serra, Guenter Roeck, linux-input
[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]
Hi Lee,
On Wed, Nov 04, 2020 at 04:24:14PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/keyboard/cros_ec_keyb.c:72: warning: cannot understand function prototype: 'struct cros_ec_bs_map '
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/input/keyboard/cros_ec_keyb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 15d17c7170816..fce0c839e1430 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -58,10 +58,9 @@ struct cros_ec_keyb {
> struct notifier_block notifier;
> };
>
> -
> /**
> - * cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch bitmap
> - * #defines
> + * struct cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch
> + * bitmap #defines
> *
> * @ev_type: The type of the input event to generate (e.g., EV_KEY).
> * @code: A linux keycode
> --
> 2.25.1
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused
2020-11-04 16:24 ` [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused Lee Jones
@ 2020-11-04 22:50 ` Dmitry Torokhov
2020-11-05 9:13 ` Lee Jones
2020-11-12 10:44 ` [PATCH] input: mouse: elan_i2c_core: Move header inclusion inside Lee Jones
1 sibling, 1 reply; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-04 22:50 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, dusonlin, KT Liao, linux-input
Hi Lee,
On Wed, Nov 04, 2020 at 04:24:13PM +0000, Lee Jones wrote:
> Some drivers which include 'elan-i2c-ids.h' make use of
> 'elan_acpi_id', but not all do. Tell the compiler that this is
> expected behaviour.
>
> Fixes the following W=1 kernel build warning(s):
>
> include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=]
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: dusonlin@emc.com.tw
> Cc: KT Liao <kt.liao@emc.com.tw>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> include/linux/input/elan-i2c-ids.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/input/elan-i2c-ids.h b/include/linux/input/elan-i2c-ids.h
> index 520858d126808..b6976d99b6b75 100644
> --- a/include/linux/input/elan-i2c-ids.h
> +++ b/include/linux/input/elan-i2c-ids.h
> @@ -23,7 +23,7 @@
>
> #include <linux/mod_devicetable.h>
>
> -static const struct acpi_device_id elan_acpi_id[] = {
> +static const struct acpi_device_id __maybe_unused elan_acpi_id[] = {
> { "ELAN0000", 0 },
> { "ELAN0100", 0 },
> { "ELAN0600", 0 },
I think I'd prefer something like this instead:
diff --git a/drivers/input/mouse/elan_i2c_core.c
b/drivers/input/mouse/elan_i2c_core.c
index c599e21a8478..65d21a050cea 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -34,7 +34,6 @@
#include <linux/completion.h>
#include <linux/of.h>
#include <linux/property.h>
-#include <linux/input/elan-i2c-ids.h>
#include <linux/regulator/consumer.h>
#include <asm/unaligned.h>
@@ -1413,6 +1412,7 @@ static const struct i2c_device_id elan_id[] = {
MODULE_DEVICE_TABLE(i2c, elan_id);
#ifdef CONFIG_ACPI
+#include <linux/input/elan-i2c-ids.h>
MODULE_DEVICE_TABLE(acpi, elan_acpi_id);
#endif
Thanks.
--
Dmitry
^ permalink raw reply related [flat|nested] 48+ messages in thread
* Re: [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused
2020-11-04 22:50 ` Dmitry Torokhov
@ 2020-11-05 9:13 ` Lee Jones
2020-11-06 7:28 ` Dmitry Torokhov
0 siblings, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-05 9:13 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-kernel, dusonlin, KT Liao, linux-input
On Wed, 04 Nov 2020, Dmitry Torokhov wrote:
> Hi Lee,
>
> On Wed, Nov 04, 2020 at 04:24:13PM +0000, Lee Jones wrote:
> > Some drivers which include 'elan-i2c-ids.h' make use of
> > 'elan_acpi_id', but not all do. Tell the compiler that this is
> > expected behaviour.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=]
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: dusonlin@emc.com.tw
> > Cc: KT Liao <kt.liao@emc.com.tw>
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > include/linux/input/elan-i2c-ids.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/input/elan-i2c-ids.h b/include/linux/input/elan-i2c-ids.h
> > index 520858d126808..b6976d99b6b75 100644
> > --- a/include/linux/input/elan-i2c-ids.h
> > +++ b/include/linux/input/elan-i2c-ids.h
> > @@ -23,7 +23,7 @@
> >
> > #include <linux/mod_devicetable.h>
> >
> > -static const struct acpi_device_id elan_acpi_id[] = {
> > +static const struct acpi_device_id __maybe_unused elan_acpi_id[] = {
> > { "ELAN0000", 0 },
> > { "ELAN0100", 0 },
> > { "ELAN0600", 0 },
>
> I think I'd prefer something like this instead:
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c
> b/drivers/input/mouse/elan_i2c_core.c
> index c599e21a8478..65d21a050cea 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -34,7 +34,6 @@
> #include <linux/completion.h>
> #include <linux/of.h>
> #include <linux/property.h>
> -#include <linux/input/elan-i2c-ids.h>
> #include <linux/regulator/consumer.h>
> #include <asm/unaligned.h>
>
> @@ -1413,6 +1412,7 @@ static const struct i2c_device_id elan_id[] = {
> MODULE_DEVICE_TABLE(i2c, elan_id);
>
> #ifdef CONFIG_ACPI
> +#include <linux/input/elan-i2c-ids.h>
> MODULE_DEVICE_TABLE(acpi, elan_acpi_id);
> #endif
Moving an #include file to the bottom of a source file, really?
I can do as you wish, but it's a pretty 'interesting' solution. :)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body
2020-11-04 16:24 ` [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body Lee Jones
@ 2020-11-06 7:26 ` Dmitry Torokhov
2020-11-06 7:40 ` Lee Jones
2020-11-06 7:45 ` Joe Perches
0 siblings, 2 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-06 7:26 UTC (permalink / raw)
To: Lee Jones, joe
Cc: linux-kernel, Henrik Rydberg, Peter Osterlund, Stefan Gmeiner,
C. Scott Ananian, Bruce Kalk, this to
Hi Lee,
On Wed, Nov 04, 2020 at 04:24:17PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
> drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Peter Osterlund <petero2@telia.com>
> Cc: Stefan Gmeiner <riddlebox@freesurf.ch>
> Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu>
> Cc: Bruce Kalk <kall@compass.com>
> Cc: this to <linux-input@vger.kernel.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/input/mouse/synaptics.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 82577095e175e..07835939d83b9 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse)
> num_fingers = hw.w + 2;
> break;
> case 2:
> - if (SYN_MODEL_PEN(info->model_id))
> + if (SYN_MODEL_PEN(info->model_id)) {
> ; /* Nothing, treat a pen as a single finger */
> + }
This gives me:
WARNING: braces {} are not necessary for single statement blocks
from checkpatch.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused
2020-11-05 9:13 ` Lee Jones
@ 2020-11-06 7:28 ` Dmitry Torokhov
2020-11-06 7:37 ` Lee Jones
0 siblings, 1 reply; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-06 7:28 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, dusonlin, KT Liao, linux-input
On Thu, Nov 05, 2020 at 09:13:05AM +0000, Lee Jones wrote:
> On Wed, 04 Nov 2020, Dmitry Torokhov wrote:
>
> > Hi Lee,
> >
> > On Wed, Nov 04, 2020 at 04:24:13PM +0000, Lee Jones wrote:
> > > Some drivers which include 'elan-i2c-ids.h' make use of
> > > 'elan_acpi_id', but not all do. Tell the compiler that this is
> > > expected behaviour.
> > >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=]
> > >
> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > Cc: dusonlin@emc.com.tw
> > > Cc: KT Liao <kt.liao@emc.com.tw>
> > > Cc: linux-input@vger.kernel.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > > include/linux/input/elan-i2c-ids.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/input/elan-i2c-ids.h b/include/linux/input/elan-i2c-ids.h
> > > index 520858d126808..b6976d99b6b75 100644
> > > --- a/include/linux/input/elan-i2c-ids.h
> > > +++ b/include/linux/input/elan-i2c-ids.h
> > > @@ -23,7 +23,7 @@
> > >
> > > #include <linux/mod_devicetable.h>
> > >
> > > -static const struct acpi_device_id elan_acpi_id[] = {
> > > +static const struct acpi_device_id __maybe_unused elan_acpi_id[] = {
> > > { "ELAN0000", 0 },
> > > { "ELAN0100", 0 },
> > > { "ELAN0600", 0 },
> >
> > I think I'd prefer something like this instead:
> >
> > diff --git a/drivers/input/mouse/elan_i2c_core.c
> > b/drivers/input/mouse/elan_i2c_core.c
> > index c599e21a8478..65d21a050cea 100644
> > --- a/drivers/input/mouse/elan_i2c_core.c
> > +++ b/drivers/input/mouse/elan_i2c_core.c
> > @@ -34,7 +34,6 @@
> > #include <linux/completion.h>
> > #include <linux/of.h>
> > #include <linux/property.h>
> > -#include <linux/input/elan-i2c-ids.h>
> > #include <linux/regulator/consumer.h>
> > #include <asm/unaligned.h>
> >
> > @@ -1413,6 +1412,7 @@ static const struct i2c_device_id elan_id[] = {
> > MODULE_DEVICE_TABLE(i2c, elan_id);
> >
> > #ifdef CONFIG_ACPI
> > +#include <linux/input/elan-i2c-ids.h>
> > MODULE_DEVICE_TABLE(acpi, elan_acpi_id);
> > #endif
>
> Moving an #include file to the bottom of a source file, really?
>
> I can do as you wish, but it's a pretty 'interesting' solution. :)
I see absolutely nothing wrong with it, and if you check kernel sources
you will see #includes used this way.
What is your concern?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused
2020-11-06 7:28 ` Dmitry Torokhov
@ 2020-11-06 7:37 ` Lee Jones
0 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-06 7:37 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-kernel, dusonlin, KT Liao, linux-input
On Thu, 05 Nov 2020, Dmitry Torokhov wrote:
> On Thu, Nov 05, 2020 at 09:13:05AM +0000, Lee Jones wrote:
> > On Wed, 04 Nov 2020, Dmitry Torokhov wrote:
> >
> > > Hi Lee,
> > >
> > > On Wed, Nov 04, 2020 at 04:24:13PM +0000, Lee Jones wrote:
> > > > Some drivers which include 'elan-i2c-ids.h' make use of
> > > > 'elan_acpi_id', but not all do. Tell the compiler that this is
> > > > expected behaviour.
> > > >
> > > > Fixes the following W=1 kernel build warning(s):
> > > >
> > > > include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=]
> > > >
> > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > Cc: dusonlin@emc.com.tw
> > > > Cc: KT Liao <kt.liao@emc.com.tw>
> > > > Cc: linux-input@vger.kernel.org
> > > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > > ---
> > > > include/linux/input/elan-i2c-ids.h | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/include/linux/input/elan-i2c-ids.h b/include/linux/input/elan-i2c-ids.h
> > > > index 520858d126808..b6976d99b6b75 100644
> > > > --- a/include/linux/input/elan-i2c-ids.h
> > > > +++ b/include/linux/input/elan-i2c-ids.h
> > > > @@ -23,7 +23,7 @@
> > > >
> > > > #include <linux/mod_devicetable.h>
> > > >
> > > > -static const struct acpi_device_id elan_acpi_id[] = {
> > > > +static const struct acpi_device_id __maybe_unused elan_acpi_id[] = {
> > > > { "ELAN0000", 0 },
> > > > { "ELAN0100", 0 },
> > > > { "ELAN0600", 0 },
> > >
> > > I think I'd prefer something like this instead:
> > >
> > > diff --git a/drivers/input/mouse/elan_i2c_core.c
> > > b/drivers/input/mouse/elan_i2c_core.c
> > > index c599e21a8478..65d21a050cea 100644
> > > --- a/drivers/input/mouse/elan_i2c_core.c
> > > +++ b/drivers/input/mouse/elan_i2c_core.c
> > > @@ -34,7 +34,6 @@
> > > #include <linux/completion.h>
> > > #include <linux/of.h>
> > > #include <linux/property.h>
> > > -#include <linux/input/elan-i2c-ids.h>
> > > #include <linux/regulator/consumer.h>
> > > #include <asm/unaligned.h>
> > >
> > > @@ -1413,6 +1412,7 @@ static const struct i2c_device_id elan_id[] = {
> > > MODULE_DEVICE_TABLE(i2c, elan_id);
> > >
> > > #ifdef CONFIG_ACPI
> > > +#include <linux/input/elan-i2c-ids.h>
> > > MODULE_DEVICE_TABLE(acpi, elan_acpi_id);
> > > #endif
> >
> > Moving an #include file to the bottom of a source file, really?
> >
> > I can do as you wish, but it's a pretty 'interesting' solution. :)
>
> I see absolutely nothing wrong with it, and if you check kernel sources
> you will see #includes used this way.
>
> What is your concern?
I guess just the unfamiliarity of it.
It's the first time I've seen such a solution.
Will fix.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body
2020-11-06 7:26 ` Dmitry Torokhov
@ 2020-11-06 7:40 ` Lee Jones
2020-11-06 7:45 ` Joe Perches
1 sibling, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-06 7:40 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: joe, linux-kernel, Henrik Rydberg, Peter Osterlund,
Stefan Gmeiner, C. Scott Ananian, Bruce Kalk, this to
On Thu, 05 Nov 2020, Dmitry Torokhov wrote:
> Hi Lee,
>
> On Wed, Nov 04, 2020 at 04:24:17PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
> > drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Henrik Rydberg <rydberg@bitmath.org>
> > Cc: Peter Osterlund <petero2@telia.com>
> > Cc: Stefan Gmeiner <riddlebox@freesurf.ch>
> > Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu>
> > Cc: Bruce Kalk <kall@compass.com>
> > Cc: this to <linux-input@vger.kernel.org>
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/input/mouse/synaptics.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> > index 82577095e175e..07835939d83b9 100644
> > --- a/drivers/input/mouse/synaptics.c
> > +++ b/drivers/input/mouse/synaptics.c
> > @@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse)
> > num_fingers = hw.w + 2;
> > break;
> > case 2:
> > - if (SYN_MODEL_PEN(info->model_id))
> > + if (SYN_MODEL_PEN(info->model_id)) {
> > ; /* Nothing, treat a pen as a single finger */
> > + }
>
> This gives me:
>
> WARNING: braces {} are not necessary for single statement blocks
>
> from checkpatch.
Yes, because checkpatch just sees it as a normal single statement,
rather than an empty one. It complains about macros that can be
compiled out too, which is even more dangerous.
GCC wins this one though, as it *knows* it's an empty statement.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body
2020-11-06 7:26 ` Dmitry Torokhov
2020-11-06 7:40 ` Lee Jones
@ 2020-11-06 7:45 ` Joe Perches
2020-11-06 8:18 ` Lee Jones
1 sibling, 1 reply; 48+ messages in thread
From: Joe Perches @ 2020-11-06 7:45 UTC (permalink / raw)
To: Dmitry Torokhov, Lee Jones
Cc: linux-kernel, Henrik Rydberg, Peter Osterlund, Stefan Gmeiner,
C. Scott Ananian, Bruce Kalk, this to
On Thu, 2020-11-05 at 23:26 -0800, Dmitry Torokhov wrote:
> On Wed, Nov 04, 2020 at 04:24:17PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
> > drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
[]
> > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
[]
> > @@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse)
> > num_fingers = hw.w + 2;
> > break;
> > case 2:
> > - if (SYN_MODEL_PEN(info->model_id))
> > + if (SYN_MODEL_PEN(info->model_id)) {
> > ; /* Nothing, treat a pen as a single finger */
> > + }
>
> This gives me:
>
> WARNING: braces {} are not necessary for single statement blocks
>
> from checkpatch.
As the entire case 2 is effectively a noop, why not just comment it better
and remove the if (SYN_MODEL_PEN(...)) test altogether.
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body
2020-11-06 7:45 ` Joe Perches
@ 2020-11-06 8:18 ` Lee Jones
0 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-06 8:18 UTC (permalink / raw)
To: Joe Perches
Cc: Dmitry Torokhov, linux-kernel, Henrik Rydberg, Peter Osterlund,
Stefan Gmeiner, C. Scott Ananian, Bruce Kalk, this to
On Thu, 05 Nov 2020, Joe Perches wrote:
> On Thu, 2020-11-05 at 23:26 -0800, Dmitry Torokhov wrote:
> > On Wed, Nov 04, 2020 at 04:24:17PM +0000, Lee Jones wrote:
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
> > > drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> []
> > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> []
> > > @@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse)
> > > num_fingers = hw.w + 2;
> > > break;
> > > case 2:
> > > - if (SYN_MODEL_PEN(info->model_id))
> > > + if (SYN_MODEL_PEN(info->model_id)) {
> > > ; /* Nothing, treat a pen as a single finger */
> > > + }
> >
> > This gives me:
> >
> > WARNING: braces {} are not necessary for single statement blocks
> >
> > from checkpatch.
>
> As the entire case 2 is effectively a noop, why not just comment it better
> and remove the if (SYN_MODEL_PEN(...)) test altogether.
Happy to do that if that's okay with Dmitry.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
` (19 preceding siblings ...)
2020-11-04 16:24 ` [PATCH 20/20] input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting Lee Jones
@ 2020-11-06 13:24 ` Lee Jones
20 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-06 13:24 UTC (permalink / raw)
To: linux-kernel, Andrew Duggan, Arjan Opmeer, at www.cypress.com,
Benson Leung, Bruce Kalk, Christopher Heiny, C. Scott Ananian,
Daniel Kurtz, Dan Murphy, David Jander, Dmitry Torokhov,
Dudley Du, dusonlin, Enric Balletbo i Serra, Eugen Hristev,
Ferruh Yigit, Guenter Roeck, Gustavo A. R. Silva, Hans de Goede,
Henrik Rydberg, KT Liao, Kumar G, linux-input, Peter Osterlund,
Phil Blundell, Stefan Gmeiner, Sundar Iyer, Trilok Soni,
Vincent Huang
On Wed, 04 Nov 2020, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> This is the first of 2 sets.
>
> Lee Jones (20):
> input: rmi4: rmi_bus: Fix misnaming of
> '__rmi_register_function_handler's 'owner' param
> input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
> input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format
> input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc
> header
> input: rmi4: rmi_f01: Struct headers are expected to start with
> 'struct <name>'
> include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused
> input: keyboard: cros_ec_keyb: Struct headers should start with
> 'struct <name>'
> input: rmi4: rmi_f11: Struct headers are expected to start with
> 'struct <name>'
> input: touchscreen: resistive-adc-touch: Struct headers should start
> with 'struct <name>'
> input: mouse: synaptics: Place braces around empty if() body
> input: keyboard: gpio_keys: Fix misnamed function parameter 'dev'
> input: mouse: elantech: Demote obvious abuse of kernel-doc header
> input: rmi4: rmi_f54: Provide some missing 'REPORT_TYPE' enums
> input: rmi4: rmi_i2c: Provide some missing descriptions for struct
> members
> input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to
> the only file that references it
> input: misc: drv260x: Fix kernel-doc formatting and remove one abuse
> input: misc: drv2665: Fix formatting expected by kernel-doc
> input: misc: drv2667: Fix formatting and add missing member docs
> input: keyboard: nomadik-ske-keypad: Provide some missing struct
> member docs
> input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting
Dmitry,
Seeing as these changes are orthogonal, it would probably be easier
and certainly cause a lot less mailing list churn if you would be kind
enough to apply patches that do not need re-spinning.
I will rebase, rework and re-submit the remainder early next week.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 16/20] input: misc: drv260x: Fix kernel-doc formatting and remove one abuse
2020-11-04 16:24 ` [PATCH 16/20] input: misc: drv260x: Fix kernel-doc formatting and remove one abuse Lee Jones
@ 2020-11-09 6:13 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:13 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Dan Murphy, linux-input
On Wed, Nov 04, 2020 at 04:24:23PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'input_dev' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'client' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'regmap' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'work' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'enable_gpio' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'regulator' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'magnitude' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'mode' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'library' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'rated_voltage' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'overdrive_voltage' not described in 'drv260x_data'
> drivers/input/misc/drv260x.c:244: warning: Function parameter or member 'voltage' not described in 'drv260x_calculate_voltage'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/input/misc/drv260x.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
> index 79d7fa710a714..fabe106d499d4 100644
> --- a/drivers/input/misc/drv260x.c
> +++ b/drivers/input/misc/drv260x.c
> @@ -167,17 +167,17 @@
>
> /**
> * struct drv260x_data -
> - * @input_dev - Pointer to the input device
> - * @client - Pointer to the I2C client
> - * @regmap - Register map of the device
> - * @work - Work item used to off load the enable/disable of the vibration
> - * @enable_gpio - Pointer to the gpio used for enable/disabling
> - * @regulator - Pointer to the regulator for the IC
> - * @magnitude - Magnitude of the vibration event
> - * @mode - The operating mode of the IC (LRA_NO_CAL, ERM or LRA)
> - * @library - The vibration library to be used
> - * @rated_voltage - The rated_voltage of the actuator
> - * @overdriver_voltage - The over drive voltage of the actuator
> + * @input_dev: Pointer to the input device
> + * @client: Pointer to the I2C client
> + * @regmap: Register map of the device
> + * @work: Work item used to off load the enable/disable of the vibration
> + * @enable_gpio: Pointer to the gpio used for enable/disabling
> + * @regulator: Pointer to the regulator for the IC
> + * @magnitude: Magnitude of the vibration event
> + * @mode: The operating mode of the IC (LRA_NO_CAL, ERM or LRA)
> + * @library: The vibration library to be used
> + * @rated_voltage: The rated_voltage of the actuator
> + * @overdriver_voltage: The over drive voltage of the actuator
Applied with this typo fixed as well.
> **/
> struct drv260x_data {
> struct input_dev *input_dev;
> @@ -234,12 +234,12 @@ static const struct reg_default drv260x_reg_defs[] = {
> #define DRV260X_DEF_RATED_VOLT 0x90
> #define DRV260X_DEF_OD_CLAMP_VOLT 0x90
>
> -/**
> +/*
> * Rated and Overdriver Voltages:
> * Calculated using the formula r = v * 255 / 5.6
> * where r is what will be written to the register
> * and v is the rated or overdriver voltage of the actuator
> - **/
> + */
> static int drv260x_calculate_voltage(unsigned int voltage)
> {
> return (voltage * 255 / 5600);
> --
> 2.25.1
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 17/20] input: misc: drv2665: Fix formatting expected by kernel-doc
2020-11-04 16:24 ` [PATCH 17/20] input: misc: drv2665: Fix formatting expected by kernel-doc Lee Jones
@ 2020-11-09 6:16 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:16 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Dan Murphy, linux-input
On Wed, Nov 04, 2020 at 04:24:24PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'input_dev' not described in 'drv2665_data'
> drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'client' not described in 'drv2665_data'
> drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'regmap' not described in 'drv2665_data'
> drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'work' not described in 'drv2665_data'
> drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'regulator' not described in 'drv2665_data'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 18/20] input: misc: drv2667: Fix formatting and add missing member docs
2020-11-04 16:24 ` [PATCH 18/20] input: misc: drv2667: Fix formatting and add missing member docs Lee Jones
@ 2020-11-09 6:17 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:17 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Dan Murphy, linux-input
On Wed, Nov 04, 2020 at 04:24:25PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'input_dev' not described in 'drv2667_data'
> drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'client' not described in 'drv2667_data'
> drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'regmap' not described in 'drv2667_data'
> drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'work' not described in 'drv2667_data'
> drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'regulator' not described in 'drv2667_data'
> drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'page' not described in 'drv2667_data'
> drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'magnitude' not described in 'drv2667_data'
> drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'frequency' not described in 'drv2667_data'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 19/20] input: keyboard: nomadik-ske-keypad: Provide some missing struct member docs
2020-11-04 16:24 ` [PATCH 19/20] input: keyboard: nomadik-ske-keypad: Provide some missing struct " Lee Jones
@ 2020-11-09 6:18 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:18 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Kumar G, Sundar Iyer, linux-input
On Wed, Nov 04, 2020 at 04:24:26PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'pclk' not described in 'ske_keypad'
> drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'ske_keypad_lock' not described in 'ske_keypad'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Kumar G <naveen.gaddipati@stericsson.com>
> Cc: Sundar Iyer <sundar.iyer@stericsson.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 11/20] input: keyboard: gpio_keys: Fix misnamed function parameter 'dev'
2020-11-04 16:24 ` [PATCH 11/20] input: keyboard: gpio_keys: Fix misnamed function parameter 'dev' Lee Jones
@ 2020-11-09 6:25 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:25 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Gustavo A. R. Silva, David Jander, Phil Blundell,
linux-input
On Wed, Nov 04, 2020 at 04:24:18PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/keyboard/gpio_keys.c:119: warning: Function parameter or member 'dev' not described in 'get_bm_events_by_type'
> drivers/input/keyboard/gpio_keys.c:119: warning: Excess function parameter 'input' description in 'get_bm_events_by_type'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: David Jander <david@protonic.nl>
> Cc: Phil Blundell <pb@handhelds.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 12/20] input: mouse: elantech: Demote obvious abuse of kernel-doc header
2020-11-04 16:24 ` [PATCH 12/20] input: mouse: elantech: Demote obvious abuse of kernel-doc header Lee Jones
@ 2020-11-09 6:25 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:25 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Henrik Rydberg, Arjan Opmeer, linux-input
On Wed, Nov 04, 2020 at 04:24:19PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'psmouse' not described in 'elantech_setup_smbus'
> drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'info' not described in 'elantech_setup_smbus'
> drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'leave_breadcrumbs' not described in 'elantech_setup_smbus'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Arjan Opmeer <arjan@opmeer.net>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
2020-11-04 16:24 ` [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param Lee Jones
2020-11-04 17:14 ` Benson Leung
@ 2020-11-09 6:31 ` Dmitry Torokhov
1 sibling, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:31 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Henrik Rydberg, Dudley Du, Daniel Kurtz,
Benson Leung, linux-input
On Wed, Nov 04, 2020 at 04:24:09PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' not described in 'cyapa_i2c_write'
> drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' description in 'cyapa_i2c_write'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Dudley Du <dudl@cypress.com>
> Cc: Daniel Kurtz <djkurtz@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 03/20] input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format
2020-11-04 16:24 ` [PATCH 03/20] input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format Lee Jones
@ 2020-11-09 6:32 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:32 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Henrik Rydberg, Gustavo A. R. Silva, Dudley Du,
linux-input
On Wed, Nov 04, 2020 at 04:24:10PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'cyapa' not described in 'cyapa_i2c_pip_write'
> drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'buf' not described in 'cyapa_i2c_pip_write'
> drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'size' not described in 'cyapa_i2c_pip_write'
> drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'cyapa' not described in 'cyapa_empty_pip_output_data'
> drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'buf' not described in 'cyapa_empty_pip_output_data'
> drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'len' not described in 'cyapa_empty_pip_output_data'
> drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'func' not described in 'cyapa_empty_pip_output_data'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: Dudley Du <dudl@cypress.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 04/20] input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc header
2020-11-04 16:24 ` [PATCH 04/20] input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc header Lee Jones
@ 2020-11-09 6:32 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:32 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Sundar Iyer, linux-input
On Wed, Nov 04, 2020 at 04:24:11PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/misc/ab8500-ponkey.c:32: warning: Function parameter or member 'idev' not described in 'ab8500_ponkey'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Sundar Iyer <sundar.iyer@stericsson.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 09/20] input: touchscreen: resistive-adc-touch: Struct headers should start with 'struct <name>'
2020-11-04 16:24 ` [PATCH 09/20] input: touchscreen: resistive-adc-touch: Struct headers should " Lee Jones
@ 2020-11-09 6:33 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:33 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Eugen Hristev, linux-input
On Wed, Nov 04, 2020 at 04:24:16PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/touchscreen/resistive-adc-touch.c:34: warning: cannot understand function prototype: 'struct grts_state '
>
> Cc: Eugen Hristev <eugen.hristev@microchip.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it
2020-11-04 16:24 ` [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it Lee Jones
@ 2020-11-09 6:36 ` Dmitry Torokhov
2020-11-09 9:17 ` Lee Jones
0 siblings, 1 reply; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 6:36 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Ferruh Yigit, at www.cypress.com, linux-input
On Wed, Nov 04, 2020 at 04:24:22PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/input/touchscreen/cyttsp_i2c_common.c:24:
> drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> 236 | static const char const cyttsp4_tch_abs_string[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/input/touchscreen/cyttsp4_i2c.c:17:
> drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> 236 | static const char * const cyttsp4_tch_abs_string[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/input/touchscreen/cyttsp4_spi.c:17:
> drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> 236 | static const char * const cyttsp4_tch_abs_string[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Cc: Ferruh Yigit <fery@cypress.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: "at www.cypress.com" <ttdrivers@cypress.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it
2020-11-09 6:36 ` Dmitry Torokhov
@ 2020-11-09 9:17 ` Lee Jones
0 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2020-11-09 9:17 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-kernel, Ferruh Yigit, at www.cypress.com, linux-input
On Sun, 08 Nov 2020, Dmitry Torokhov wrote:
> On Wed, Nov 04, 2020 at 04:24:22PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > In file included from drivers/input/touchscreen/cyttsp_i2c_common.c:24:
> > drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> > 236 | static const char const cyttsp4_tch_abs_string[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > In file included from drivers/input/touchscreen/cyttsp4_i2c.c:17:
> > drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> > 236 | static const char * const cyttsp4_tch_abs_string[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > In file included from drivers/input/touchscreen/cyttsp4_spi.c:17:
> > drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> > 236 | static const char * const cyttsp4_tch_abs_string[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> >
> > Cc: Ferruh Yigit <fery@cypress.com>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: "at www.cypress.com" <ttdrivers@cypress.com>
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Applied, thank you.
Thanks for this Dmitry.
I'll rebase in a couple of days and fix the stragglers.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 20/20] input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting
2020-11-04 16:24 ` [PATCH 20/20] input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting Lee Jones
@ 2020-11-09 22:02 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-09 22:02 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Trilok Soni, linux-input
On Wed, Nov 04, 2020 at 04:24:27PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'num_rows' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'num_cols' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'input' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'regmap' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'key_sense_irq' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'key_stuck_irq' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'keycodes' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'dev' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'keystate' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'stuckstate' not described in 'pmic8xxx_kp'
> drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'ctrl_reg' not described in 'pmic8xxx_kp'
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Trilok Soni <tsoni@codeaurora.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 05/20] input: rmi4: rmi_f01: Struct headers are expected to start with 'struct <name>'
2020-11-04 16:24 ` [PATCH 05/20] input: rmi4: rmi_f01: Struct headers are expected to start with 'struct <name>' Lee Jones
@ 2020-11-10 0:49 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-10 0:49 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, linux-input
Hi Lee,
On Wed, Nov 04, 2020 at 04:24:12PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/rmi4/rmi_f01.c:106: warning: Cannot understand * @ctrl0 - see the bit definitions above.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
I folded all RMI4 patches together and added more missing field
descriptions/fixed a few things, and applied.
Thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH] input: mouse: elan_i2c_core: Move header inclusion inside
2020-11-04 16:24 ` [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused Lee Jones
2020-11-04 22:50 ` Dmitry Torokhov
@ 2020-11-12 10:44 ` Lee Jones
2020-11-18 0:33 ` Dmitry Torokhov
1 sibling, 1 reply; 48+ messages in thread
From: Lee Jones @ 2020-11-12 10:44 UTC (permalink / raw)
To: linux-kernel, Dmitry Torokhov, dusonlin, KT Liao, linux-input
The same clause as its use.
Fixes the following W=1 kernel build warning(s):
include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=]
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jingle Wu <jingle.wu@emc.com.tw>
Cc: dusonlin@emc.com.tw
Cc: KT Liao <kt.liao@emc.com.tw>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/mouse/elan_i2c_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index c599e21a84784..65d21a050cea0 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -34,7 +34,6 @@
#include <linux/completion.h>
#include <linux/of.h>
#include <linux/property.h>
-#include <linux/input/elan-i2c-ids.h>
#include <linux/regulator/consumer.h>
#include <asm/unaligned.h>
@@ -1413,6 +1412,7 @@ static const struct i2c_device_id elan_id[] = {
MODULE_DEVICE_TABLE(i2c, elan_id);
#ifdef CONFIG_ACPI
+#include <linux/input/elan-i2c-ids.h>
MODULE_DEVICE_TABLE(acpi, elan_acpi_id);
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 48+ messages in thread
* Re: [PATCH] input: mouse: elan_i2c_core: Move header inclusion inside
2020-11-12 10:44 ` [PATCH] input: mouse: elan_i2c_core: Move header inclusion inside Lee Jones
@ 2020-11-18 0:33 ` Dmitry Torokhov
0 siblings, 0 replies; 48+ messages in thread
From: Dmitry Torokhov @ 2020-11-18 0:33 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, dusonlin, KT Liao, linux-input
On Thu, Nov 12, 2020 at 10:44:20AM +0000, Lee Jones wrote:
> The same clause as its use.
>
> Fixes the following W=1 kernel build warning(s):
>
> include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=]
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Jingle Wu <jingle.wu@emc.com.tw>
> Cc: dusonlin@emc.com.tw
> Cc: KT Liao <kt.liao@emc.com.tw>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 48+ messages in thread
end of thread, other threads:[~2020-11-18 0:33 UTC | newest]
Thread overview: 48+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 16:24 [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
2020-11-04 16:24 ` [PATCH 01/20] input: rmi4: rmi_bus: Fix misnaming of '__rmi_register_function_handler's 'owner' param Lee Jones
2020-11-04 16:24 ` [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param Lee Jones
2020-11-04 17:14 ` Benson Leung
2020-11-09 6:31 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 03/20] input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format Lee Jones
2020-11-09 6:32 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 04/20] input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc header Lee Jones
2020-11-09 6:32 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 05/20] input: rmi4: rmi_f01: Struct headers are expected to start with 'struct <name>' Lee Jones
2020-11-10 0:49 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused Lee Jones
2020-11-04 22:50 ` Dmitry Torokhov
2020-11-05 9:13 ` Lee Jones
2020-11-06 7:28 ` Dmitry Torokhov
2020-11-06 7:37 ` Lee Jones
2020-11-12 10:44 ` [PATCH] input: mouse: elan_i2c_core: Move header inclusion inside Lee Jones
2020-11-18 0:33 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct <name>' Lee Jones
2020-11-04 17:15 ` Benson Leung
2020-11-04 16:24 ` [PATCH 08/20] input: rmi4: rmi_f11: Struct headers are expected to " Lee Jones
2020-11-04 16:24 ` [PATCH 09/20] input: touchscreen: resistive-adc-touch: Struct headers should " Lee Jones
2020-11-09 6:33 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body Lee Jones
2020-11-06 7:26 ` Dmitry Torokhov
2020-11-06 7:40 ` Lee Jones
2020-11-06 7:45 ` Joe Perches
2020-11-06 8:18 ` Lee Jones
2020-11-04 16:24 ` [PATCH 11/20] input: keyboard: gpio_keys: Fix misnamed function parameter 'dev' Lee Jones
2020-11-09 6:25 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 12/20] input: mouse: elantech: Demote obvious abuse of kernel-doc header Lee Jones
2020-11-09 6:25 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 13/20] input: rmi4: rmi_f54: Provide some missing 'REPORT_TYPE' enums Lee Jones
2020-11-04 16:24 ` [PATCH 14/20] input: rmi4: rmi_i2c: Provide some missing descriptions for struct members Lee Jones
2020-11-04 16:24 ` [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it Lee Jones
2020-11-09 6:36 ` Dmitry Torokhov
2020-11-09 9:17 ` Lee Jones
2020-11-04 16:24 ` [PATCH 16/20] input: misc: drv260x: Fix kernel-doc formatting and remove one abuse Lee Jones
2020-11-09 6:13 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 17/20] input: misc: drv2665: Fix formatting expected by kernel-doc Lee Jones
2020-11-09 6:16 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 18/20] input: misc: drv2667: Fix formatting and add missing member docs Lee Jones
2020-11-09 6:17 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 19/20] input: keyboard: nomadik-ske-keypad: Provide some missing struct " Lee Jones
2020-11-09 6:18 ` Dmitry Torokhov
2020-11-04 16:24 ` [PATCH 20/20] input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting Lee Jones
2020-11-09 22:02 ` Dmitry Torokhov
2020-11-06 13:24 ` [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).