* [PATCH] Input: ads7846 - fix unaligned access on 7845
@ 2020-11-12 1:27 Dmitry Torokhov
2020-11-12 8:04 ` Oleksij Rempel
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2020-11-12 1:27 UTC (permalink / raw)
To: linux-input; +Cc: Oleksij Rempel, Anatolij Gustschin, linux-kernel
req->sample[1] is not naturally aligned at word boundary, and therefore
we should use get_unaligned_be16() when accessing it.
Fixes: 3eac5c7e44f3 ("Input: ads7846 - extend the driver for ads7845 controller support")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Not tested on hardware, so if somebody has the controller and can verify
that would be great.
drivers/input/touchscreen/ads7846.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 95e89f675ad5..35d14bc44aff 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -33,6 +33,7 @@
#include <linux/regulator/consumer.h>
#include <linux/module.h>
#include <asm/irq.h>
+#include <asm/unaligned.h>
/*
* This code has been heavily tested on a Nokia 770, and lightly
@@ -443,7 +444,7 @@ static int ads7845_read12_ser(struct device *dev, unsigned command)
if (status == 0) {
/* BE12 value, then padding */
- status = be16_to_cpu(*((u16 *)&req->sample[1]));
+ status = get_unaligned_be16(&req->sample[1]);
status = status >> 3;
status &= 0x0fff;
}
--
2.29.2.222.g5d2a92d10f8-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: ads7846 - fix unaligned access on 7845
2020-11-12 1:27 [PATCH] Input: ads7846 - fix unaligned access on 7845 Dmitry Torokhov
@ 2020-11-12 8:04 ` Oleksij Rempel
2020-11-18 0:32 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Oleksij Rempel @ 2020-11-12 8:04 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input
Cc: Anatolij Gustschin, linux-kernel, Oleksij Rempel
Hello Dmitry,
Am 12.11.20 um 02:27 schrieb Dmitry Torokhov:
> req->sample[1] is not naturally aligned at word boundary, and therefore
> we should use get_unaligned_be16() when accessing it.
>
> Fixes: 3eac5c7e44f3 ("Input: ads7846 - extend the driver for ads7845 controller support")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
I do not have ads7845, but i assume i need to resend my patch with the same fix. Correct?
> ---
>
> Not tested on hardware, so if somebody has the controller and can verify
> that would be great.
>
>
> drivers/input/touchscreen/ads7846.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
> index 95e89f675ad5..35d14bc44aff 100644
> --- a/drivers/input/touchscreen/ads7846.c
> +++ b/drivers/input/touchscreen/ads7846.c
> @@ -33,6 +33,7 @@
> #include <linux/regulator/consumer.h>
> #include <linux/module.h>
> #include <asm/irq.h>
> +#include <asm/unaligned.h>
>
> /*
> * This code has been heavily tested on a Nokia 770, and lightly
> @@ -443,7 +444,7 @@ static int ads7845_read12_ser(struct device *dev, unsigned command)
>
> if (status == 0) {
> /* BE12 value, then padding */
> - status = be16_to_cpu(*((u16 *)&req->sample[1]));
> + status = get_unaligned_be16(&req->sample[1]);
> status = status >> 3;
> status &= 0x0fff;
> }
>
--
Regards,
Oleksij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: ads7846 - fix unaligned access on 7845
2020-11-12 8:04 ` Oleksij Rempel
@ 2020-11-18 0:32 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2020-11-18 0:32 UTC (permalink / raw)
To: Oleksij Rempel
Cc: linux-input, Anatolij Gustschin, linux-kernel, Oleksij Rempel
On Thu, Nov 12, 2020 at 09:04:23AM +0100, Oleksij Rempel wrote:
> Hello Dmitry,
>
> Am 12.11.20 um 02:27 schrieb Dmitry Torokhov:
> > req->sample[1] is not naturally aligned at word boundary, and therefore
> > we should use get_unaligned_be16() when accessing it.
> >
> > Fixes: 3eac5c7e44f3 ("Input: ads7846 - extend the driver for ads7845 controller support")
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> I do not have ads7845, but i assume i need to resend my patch with the same fix. Correct?
I do not think your patches are affected, so I just applied it together
with yours.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-18 0:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 1:27 [PATCH] Input: ads7846 - fix unaligned access on 7845 Dmitry Torokhov
2020-11-12 8:04 ` Oleksij Rempel
2020-11-18 0:32 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).