From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Sangwon Jee <jeesw@melfas.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org
Subject: [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables
Date: Thu, 26 Nov 2020 13:36:05 +0000 [thread overview]
Message-ID: <20201126133607.3212484-3-lee.jones@linaro.org> (raw)
In-Reply-To: <20201126133607.3212484-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]
Cc: Sangwon Jee <jeesw@melfas.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/touchscreen/melfas_mip4.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index f67efdd040b24..9c98759098c7a 100644
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)
static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
{
int id;
- bool hover;
- bool palm;
bool state;
u16 x, y;
- u8 pressure_stage = 0;
u8 pressure;
- u8 size;
u8 touch_major;
u8 touch_minor;
@@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
case 1:
/* Touch only */
state = packet[0] & BIT(7);
- hover = packet[0] & BIT(5);
- palm = packet[0] & BIT(4);
id = (packet[0] & 0x0F) - 1;
x = ((packet[1] & 0x0F) << 8) | packet[2];
y = (((packet[1] >> 4) & 0x0F) << 8) |
packet[3];
pressure = packet[4];
- size = packet[5];
if (ts->event_format == 0) {
touch_major = packet[5];
touch_minor = packet[5];
@@ -501,14 +494,10 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
default:
/* Touch + Force(Pressure) */
id = (packet[0] & 0x0F) - 1;
- hover = packet[1] & BIT(2);
- palm = packet[1] & BIT(1);
state = packet[1] & BIT(0);
x = ((packet[2] & 0x0F) << 8) | packet[3];
y = (((packet[2] >> 4) & 0x0F) << 8) |
packet[4];
- size = packet[6];
- pressure_stage = (packet[7] & 0xF0) >> 4;
pressure = ((packet[7] & 0x0F) << 8) |
packet[8];
touch_major = packet[9];
--
2.25.1
next prev parent reply other threads:[~2020-11-26 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 13:36 [PATCH v2 0/4] [Set 2/2] Rid W=1 issues from Input Lee Jones
2020-11-26 13:36 ` [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary Lee Jones
2020-11-26 13:36 ` Lee Jones [this message]
2020-11-29 2:59 ` [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Dmitry Torokhov
2020-11-26 13:36 ` [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Lee Jones
2020-11-29 2:59 ` Dmitry Torokhov
2020-11-29 8:27 ` Lee Jones
2020-11-26 13:36 ` [PATCH v2 4/4] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126133607.3212484-3-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeesw@melfas.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).