From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Henrik Rydberg <rydberg@bitmath.org>,
James Hilliard <james.hilliard1@gmail.com>,
Daniel Ritz <daniel.ritz@gmx.ch>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
Date: Sun, 29 Nov 2020 08:27:40 +0000 [thread overview]
Message-ID: <20201129082740.GB3857718@dell> (raw)
In-Reply-To: <20201129025959.GJ2034289@dtor-ws>
On Sat, 28 Nov 2020, Dmitry Torokhov wrote:
> Hi Lee,
>
> On Thu, Nov 26, 2020 at 01:36:06PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’:
> > drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Henrik Rydberg <rydberg@bitmath.org>
> > Cc: James Hilliard <james.hilliard1@gmail.com>
> > Cc: Daniel Ritz <daniel.ritz@gmx.ch>
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/input/touchscreen/usbtouchscreen.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
> > index 397cb1d3f481b..c3b7130cd9033 100644
> > --- a/drivers/input/touchscreen/usbtouchscreen.c
> > +++ b/drivers/input/touchscreen/usbtouchscreen.c
> > @@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
> > unsigned int data_len = be16_to_cpu(packet->data_len);
> > unsigned int x_len = be16_to_cpu(packet->x_len);
> > unsigned int y_len = be16_to_cpu(packet->y_len);
> > - int x, y, begin_x, begin_y, end_x, end_y, w, h, ret;
> > + int x, y, begin_x, begin_y, end_x, end_y, w, h;
> >
> > /* got touch data? */
> > if ((pkt[0] & 0xe0) != 0xe0)
> > @@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
> > x_len -= 0x80;
> >
> > /* send ACK */
> > - ret = usb_submit_urb(priv->ack, GFP_ATOMIC);
> > + usb_submit_urb(priv->ack, GFP_ATOMIC);
>
> I thought you were going to add error handling here?
Hmm... I thought I handed all of the review comments!
Will look into this again on Monday.
> > if (!usbtouch->type->max_xc) {
> > usbtouch->type->max_xc = 2 * x_len;
>
> Thanks.
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-11-29 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 13:36 [PATCH v2 0/4] [Set 2/2] Rid W=1 issues from Input Lee Jones
2020-11-26 13:36 ` [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary Lee Jones
2020-11-26 13:36 ` [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Lee Jones
2020-11-29 2:59 ` Dmitry Torokhov
2020-11-26 13:36 ` [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Lee Jones
2020-11-29 2:59 ` Dmitry Torokhov
2020-11-29 8:27 ` Lee Jones [this message]
2020-11-26 13:36 ` [PATCH v2 4/4] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201129082740.GB3857718@dell \
--to=lee.jones@linaro.org \
--cc=daniel.ritz@gmx.ch \
--cc=dmitry.torokhov@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).