* [PATCH RESEND v2] virtio-input: add multi-touch support
@ 2020-12-08 21:01 Vasyl Vavrychuk
2020-12-08 22:05 ` Dmitry Torokhov
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vasyl Vavrychuk @ 2020-12-08 21:01 UTC (permalink / raw)
To: virtualization, linux-kernel, linux-input, stable
Cc: Michael S. Tsirkin, Jason Wang, Gerd Hoffmann, Henrik Rydberg,
Mathias Crombez, Vasyl Vavrychuk
From: Mathias Crombez <mathias.crombez@faurecia.com>
Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by
input_handle_abs_event.
Signed-off-by: Mathias Crombez <mathias.crombez@faurecia.com>
Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
Tested-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
---
v2: fix patch corrupted by corporate email server
drivers/virtio/Kconfig | 11 +++++++++++
drivers/virtio/virtio_input.c | 8 ++++++++
2 files changed, 19 insertions(+)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 7b41130d3f35..2cfd5b01d96d 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -111,6 +111,17 @@ config VIRTIO_INPUT
If unsure, say M.
+config VIRTIO_INPUT_MULTITOUCH_SLOTS
+ depends on VIRTIO_INPUT
+ int "Number of multitouch slots"
+ range 0 64
+ default 10
+ help
+ Define the number of multitouch slots used. Default to 10.
+ This parameter is unused if there is no multitouch capability.
+
+ 0 will disable the feature.
+
config VIRTIO_MMIO
tristate "Platform bus driver for memory mapped virtio devices"
depends on HAS_IOMEM && HAS_DMA
diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
index f1f6208edcf5..13f3d90e6c30 100644
--- a/drivers/virtio/virtio_input.c
+++ b/drivers/virtio/virtio_input.c
@@ -7,6 +7,7 @@
#include <uapi/linux/virtio_ids.h>
#include <uapi/linux/virtio_input.h>
+#include <linux/input/mt.h>
struct virtio_input {
struct virtio_device *vdev;
@@ -205,6 +206,7 @@ static int virtinput_probe(struct virtio_device *vdev)
unsigned long flags;
size_t size;
int abs, err;
+ bool is_mt = false;
if (!virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
return -ENODEV;
@@ -287,9 +289,15 @@ static int virtinput_probe(struct virtio_device *vdev)
for (abs = 0; abs < ABS_CNT; abs++) {
if (!test_bit(abs, vi->idev->absbit))
continue;
+ if (input_is_mt_value(abs))
+ is_mt = true;
virtinput_cfg_abs(vi, abs);
}
}
+ if (is_mt)
+ input_mt_init_slots(vi->idev,
+ CONFIG_VIRTIO_INPUT_MULTITOUCH_SLOTS,
+ INPUT_MT_DIRECT);
virtio_device_ready(vdev);
vi->ready = true;
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH RESEND v2] virtio-input: add multi-touch support
2020-12-08 21:01 [PATCH RESEND v2] virtio-input: add multi-touch support Vasyl Vavrychuk
@ 2020-12-08 22:05 ` Dmitry Torokhov
2020-12-18 23:20 ` Vasyl Vavrychuk
2020-12-09 7:01 ` Greg KH
2020-12-09 8:28 ` Michael S. Tsirkin
2 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2020-12-08 22:05 UTC (permalink / raw)
To: Vasyl Vavrychuk
Cc: virtualization, linux-kernel, linux-input, stable,
Michael S. Tsirkin, Jason Wang, Gerd Hoffmann, Henrik Rydberg,
Mathias Crombez
Hi Vasyl,
On Tue, Dec 08, 2020 at 11:01:50PM +0200, Vasyl Vavrychuk wrote:
> From: Mathias Crombez <mathias.crombez@faurecia.com>
>
> Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by
> input_handle_abs_event.
>
> Signed-off-by: Mathias Crombez <mathias.crombez@faurecia.com>
> Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> Tested-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> ---
> v2: fix patch corrupted by corporate email server
>
> drivers/virtio/Kconfig | 11 +++++++++++
> drivers/virtio/virtio_input.c | 8 ++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 7b41130d3f35..2cfd5b01d96d 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -111,6 +111,17 @@ config VIRTIO_INPUT
>
> If unsure, say M.
>
> +config VIRTIO_INPUT_MULTITOUCH_SLOTS
> + depends on VIRTIO_INPUT
> + int "Number of multitouch slots"
> + range 0 64
> + default 10
> + help
> + Define the number of multitouch slots used. Default to 10.
> + This parameter is unused if there is no multitouch capability.
I believe the number of slots should be communicated to the guest by
the host, similarly to how the rest of input device capabilities is
transferred, instead of having static compile-time option.
> +
> + 0 will disable the feature.
> +
> config VIRTIO_MMIO
> tristate "Platform bus driver for memory mapped virtio devices"
> depends on HAS_IOMEM && HAS_DMA
> diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
> index f1f6208edcf5..13f3d90e6c30 100644
> --- a/drivers/virtio/virtio_input.c
> +++ b/drivers/virtio/virtio_input.c
> @@ -7,6 +7,7 @@
>
> #include <uapi/linux/virtio_ids.h>
> #include <uapi/linux/virtio_input.h>
> +#include <linux/input/mt.h>
>
> struct virtio_input {
> struct virtio_device *vdev;
> @@ -205,6 +206,7 @@ static int virtinput_probe(struct virtio_device *vdev)
> unsigned long flags;
> size_t size;
> int abs, err;
> + bool is_mt = false;
>
> if (!virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
> return -ENODEV;
> @@ -287,9 +289,15 @@ static int virtinput_probe(struct virtio_device *vdev)
> for (abs = 0; abs < ABS_CNT; abs++) {
> if (!test_bit(abs, vi->idev->absbit))
> continue;
> + if (input_is_mt_value(abs))
> + is_mt = true;
> virtinput_cfg_abs(vi, abs);
> }
> }
> + if (is_mt)
> + input_mt_init_slots(vi->idev,
> + CONFIG_VIRTIO_INPUT_MULTITOUCH_SLOTS,
> + INPUT_MT_DIRECT);
Here errors need to be handled.
>
> virtio_device_ready(vdev);
> vi->ready = true;
> --
> 2.23.0
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH RESEND v2] virtio-input: add multi-touch support
2020-12-08 22:05 ` Dmitry Torokhov
@ 2020-12-18 23:20 ` Vasyl Vavrychuk
0 siblings, 0 replies; 6+ messages in thread
From: Vasyl Vavrychuk @ 2020-12-18 23:20 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: virtualization, linux-kernel, linux-input, Michael S. Tsirkin,
Jason Wang, Gerd Hoffmann, Henrik Rydberg, Mathias Crombez
Hi, Dmitry,
Thanks for you suggestion. I have sent v3 version of the patch where I
have applied it.
Kind regards,
Vasyl
On 09.12.20 00:05, Dmitry Torokhov wrote:
> CAUTION: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
> Hi Vasyl,
>
> On Tue, Dec 08, 2020 at 11:01:50PM +0200, Vasyl Vavrychuk wrote:
>> From: Mathias Crombez <mathias.crombez@faurecia.com>
>>
>> Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by
>> input_handle_abs_event.
>>
>> Signed-off-by: Mathias Crombez <mathias.crombez@faurecia.com>
>> Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
>> Tested-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
>> ---
>> v2: fix patch corrupted by corporate email server
>>
>> drivers/virtio/Kconfig | 11 +++++++++++
>> drivers/virtio/virtio_input.c | 8 ++++++++
>> 2 files changed, 19 insertions(+)
>>
>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>> index 7b41130d3f35..2cfd5b01d96d 100644
>> --- a/drivers/virtio/Kconfig
>> +++ b/drivers/virtio/Kconfig
>> @@ -111,6 +111,17 @@ config VIRTIO_INPUT
>>
>> If unsure, say M.
>>
>> +config VIRTIO_INPUT_MULTITOUCH_SLOTS
>> + depends on VIRTIO_INPUT
>> + int "Number of multitouch slots"
>> + range 0 64
>> + default 10
>> + help
>> + Define the number of multitouch slots used. Default to 10.
>> + This parameter is unused if there is no multitouch capability.
>
> I believe the number of slots should be communicated to the guest by
> the host, similarly to how the rest of input device capabilities is
> transferred, instead of having static compile-time option.
>
>> +
>> + 0 will disable the feature.
>> +
>> config VIRTIO_MMIO
>> tristate "Platform bus driver for memory mapped virtio devices"
>> depends on HAS_IOMEM && HAS_DMA
>> diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
>> index f1f6208edcf5..13f3d90e6c30 100644
>> --- a/drivers/virtio/virtio_input.c
>> +++ b/drivers/virtio/virtio_input.c
>> @@ -7,6 +7,7 @@
>>
>> #include <uapi/linux/virtio_ids.h>
>> #include <uapi/linux/virtio_input.h>
>> +#include <linux/input/mt.h>
>>
>> struct virtio_input {
>> struct virtio_device *vdev;
>> @@ -205,6 +206,7 @@ static int virtinput_probe(struct virtio_device *vdev)
>> unsigned long flags;
>> size_t size;
>> int abs, err;
>> + bool is_mt = false;
>>
>> if (!virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
>> return -ENODEV;
>> @@ -287,9 +289,15 @@ static int virtinput_probe(struct virtio_device *vdev)
>> for (abs = 0; abs < ABS_CNT; abs++) {
>> if (!test_bit(abs, vi->idev->absbit))
>> continue;
>> + if (input_is_mt_value(abs))
>> + is_mt = true;
>> virtinput_cfg_abs(vi, abs);
>> }
>> }
>> + if (is_mt)
>> + input_mt_init_slots(vi->idev,
>> + CONFIG_VIRTIO_INPUT_MULTITOUCH_SLOTS,
>> + INPUT_MT_DIRECT);
>
> Here errors need to be handled.
>
>>
>> virtio_device_ready(vdev);
>> vi->ready = true;
>> --
>> 2.23.0
>>
>
> Thanks.
>
> --
> Dmitry
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND v2] virtio-input: add multi-touch support
2020-12-08 21:01 [PATCH RESEND v2] virtio-input: add multi-touch support Vasyl Vavrychuk
2020-12-08 22:05 ` Dmitry Torokhov
@ 2020-12-09 7:01 ` Greg KH
2020-12-09 8:28 ` Michael S. Tsirkin
2 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-12-09 7:01 UTC (permalink / raw)
To: Vasyl Vavrychuk
Cc: virtualization, linux-kernel, linux-input, stable,
Michael S. Tsirkin, Jason Wang, Gerd Hoffmann, Henrik Rydberg,
Mathias Crombez
On Tue, Dec 08, 2020 at 11:01:50PM +0200, Vasyl Vavrychuk wrote:
> From: Mathias Crombez <mathias.crombez@faurecia.com>
>
> Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by
> input_handle_abs_event.
>
> Signed-off-by: Mathias Crombez <mathias.crombez@faurecia.com>
> Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> Tested-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> ---
> v2: fix patch corrupted by corporate email server
>
> drivers/virtio/Kconfig | 11 +++++++++++
> drivers/virtio/virtio_input.c | 8 ++++++++
> 2 files changed, 19 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH RESEND v2] virtio-input: add multi-touch support
2020-12-08 21:01 [PATCH RESEND v2] virtio-input: add multi-touch support Vasyl Vavrychuk
2020-12-08 22:05 ` Dmitry Torokhov
2020-12-09 7:01 ` Greg KH
@ 2020-12-09 8:28 ` Michael S. Tsirkin
2020-12-18 23:25 ` Vasyl Vavrychuk
2 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2020-12-09 8:28 UTC (permalink / raw)
To: Vasyl Vavrychuk
Cc: virtualization, linux-kernel, linux-input, stable, Jason Wang,
Gerd Hoffmann, Henrik Rydberg, Mathias Crombez
On Tue, Dec 08, 2020 at 11:01:50PM +0200, Vasyl Vavrychuk wrote:
> From: Mathias Crombez <mathias.crombez@faurecia.com>
> Cc: stable@vger.kernel.org
I don't believe this is appropriate for stable, looks like
a new feature to me.
>
> Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by
> input_handle_abs_event.
>
> Signed-off-by: Mathias Crombez <mathias.crombez@faurecia.com>
> Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> Tested-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> ---
> v2: fix patch corrupted by corporate email server
>
> drivers/virtio/Kconfig | 11 +++++++++++
> drivers/virtio/virtio_input.c | 8 ++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 7b41130d3f35..2cfd5b01d96d 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -111,6 +111,17 @@ config VIRTIO_INPUT
>
> If unsure, say M.
>
> +config VIRTIO_INPUT_MULTITOUCH_SLOTS
> + depends on VIRTIO_INPUT
> + int "Number of multitouch slots"
> + range 0 64
> + default 10
> + help
> + Define the number of multitouch slots used. Default to 10.
> + This parameter is unused if there is no multitouch capability.
> +
> + 0 will disable the feature.
> +
Most people won't be using this config so the defaults matter. So why 10? 10 fingers?
And where does 64 come from?
> config VIRTIO_MMIO
> tristate "Platform bus driver for memory mapped virtio devices"
> depends on HAS_IOMEM && HAS_DMA
> diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
> index f1f6208edcf5..13f3d90e6c30 100644
> --- a/drivers/virtio/virtio_input.c
> +++ b/drivers/virtio/virtio_input.c
> @@ -7,6 +7,7 @@
>
> #include <uapi/linux/virtio_ids.h>
> #include <uapi/linux/virtio_input.h>
> +#include <linux/input/mt.h>
>
> struct virtio_input {
> struct virtio_device *vdev;
> @@ -205,6 +206,7 @@ static int virtinput_probe(struct virtio_device *vdev)
> unsigned long flags;
> size_t size;
> int abs, err;
> + bool is_mt = false;
>
> if (!virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
> return -ENODEV;
> @@ -287,9 +289,15 @@ static int virtinput_probe(struct virtio_device *vdev)
> for (abs = 0; abs < ABS_CNT; abs++) {
> if (!test_bit(abs, vi->idev->absbit))
> continue;
> + if (input_is_mt_value(abs))
> + is_mt = true;
> virtinput_cfg_abs(vi, abs);
> }
> }
> + if (is_mt)
> + input_mt_init_slots(vi->idev,
> + CONFIG_VIRTIO_INPUT_MULTITOUCH_SLOTS,
> + INPUT_MT_DIRECT);
Do we need the number in config space maybe? And maybe with a feature
bit so host can find out whether guest supports MT?
>
> virtio_device_ready(vdev);
> vi->ready = true;
> --
> 2.23.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH RESEND v2] virtio-input: add multi-touch support
2020-12-09 8:28 ` Michael S. Tsirkin
@ 2020-12-18 23:25 ` Vasyl Vavrychuk
0 siblings, 0 replies; 6+ messages in thread
From: Vasyl Vavrychuk @ 2020-12-18 23:25 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: virtualization, linux-kernel, linux-input, stable, Jason Wang,
Gerd Hoffmann, Henrik Rydberg, Mathias Crombez
On 09.12.20 10:28, Michael S. Tsirkin wrote:
> On Tue, Dec 08, 2020 at 11:01:50PM +0200, Vasyl Vavrychuk wrote:
>> From: Mathias Crombez <mathias.crombez@faurecia.com>
>> Cc: stable@vger.kernel.org
>
> I don't believe this is appropriate for stable, looks like
> a new feature to me.
Agree, removed.
>>
>> +config VIRTIO_INPUT_MULTITOUCH_SLOTS
>> + depends on VIRTIO_INPUT
>> + int "Number of multitouch slots"
>> + range 0 64
>> + default 10
>> + help
>> + Define the number of multitouch slots used. Default to 10.
>> + This parameter is unused if there is no multitouch capability.
>> +
>> + 0 will disable the feature.
>> +
>
> Most people won't be using this config so the defaults matter. So why 10? 10 fingers?
>
> And where does 64 come from?
I have sent v3 version where number of slots it obtained from the host.
>> + if (is_mt)
>> + input_mt_init_slots(vi->idev,
>> + CONFIG_VIRTIO_INPUT_MULTITOUCH_SLOTS,
>> + INPUT_MT_DIRECT);
>
>
> Do we need the number in config space maybe? And maybe with a feature
> bit so host can find out whether guest supports MT?
I think it is not applicable in v3 which I sent, because number of slots
is commit from the host. So, now host controls whether guest support MT.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-18 23:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 21:01 [PATCH RESEND v2] virtio-input: add multi-touch support Vasyl Vavrychuk
2020-12-08 22:05 ` Dmitry Torokhov
2020-12-18 23:20 ` Vasyl Vavrychuk
2020-12-09 7:01 ` Greg KH
2020-12-09 8:28 ` Michael S. Tsirkin
2020-12-18 23:25 ` Vasyl Vavrychuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).