From: Douglas Anderson <dianders@chromium.org>
To: jkosina@suse.cz, benjamin.tissoires@redhat.com,
gregkh@linuxfoundation.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: hdegoede@redhat.com, swboyd@chromium.org, robh+dt@kernel.org,
linux-input@vger.kernel.org, andrea@borgia.bo.it,
kai.heng.feng@canonical.com,
"Douglas Anderson" <dianders@chromium.org>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Coiby Xu" <coiby.xu@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Guido Günther" <agx@sigxcpu.org>,
"Jiri Kosina" <jikos@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Max Krummenacher" <max.oss.09@gmail.com>,
"Michael Walle" <michael@walle.cc>,
"Pavel Balan" <admin@kryma.net>,
"Shawn Guo" <shawnguo@kernel.org>,
"Will Deacon" <will@kernel.org>,
"Xiaofei Tan" <tanxiaofei@huawei.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v7 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p
Date: Fri, 11 Dec 2020 09:35:22 -0800 [thread overview]
Message-ID: <20201211173526.1516653-1-dianders@chromium.org> (raw)
The goal of this series is to support the Goodix GT7375P touchscreen.
This touchscreen is special because it has power sequencing
requirements that necessitate driving a reset GPIO.
To do this, we totally rejigger the way i2c-hid is organized so that
it's easier to jam the Goodix support in there.
This series was:
- Tested on a device that uses normal i2c-hid.
- Tested on a device that has a Goodix i2c-hid device.
- Tested on an ACPI device, but an earlier version of the series.
I believe the plan is for Benjamin to land the whole series. Will
said this about the arm64 defconfig change (and provided his Ack):
> ...there are a few things I really care about
> in defconfig (e.g. things like page size!), generally speaking we don't
> need to Ack everything that changes in there.
>
> That said, might be worth checking whether arm-soc have any defconfig
> changes queued in -next so you don't end up with conflicts.
Changes in v7:
- Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...")
Changes in v6:
- ACPI probe function should have been "static"
- Don't export suspend/resume, just export dev_pm_ops from core.
- Fixed crash in ACPI module (missing init of "client")
- No need for regulator include in the core.
- Removed i2c_device_id table from ACPI module.
- Suspend/resume are no longer exported from the core.
Changes in v5:
- Add shutdown_tail op and use it in ACPI.
- Added mention of i2c-hid in the yaml itself as per Rob.
- Adjusted subject as per Rob.
- i2chid_subclass_data => i2chid_ops.
- power_up_device => power_up (same with power_down).
- subclass => ops.
Changes in v4:
- ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4.
- Fully rejigger so ACPI and OF are full subclasses.
- Totally redid based on the new subclass system.
Changes in v3:
- Fixed compatible in example.
- Removed Benjamin as a maintainer.
- Rework to use subclassing.
- Updated description.
Changes in v2:
- ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2.
- Get timings based on the compatible string.
- Use a separate compatible string for this new touchscreen.
Douglas Anderson (4):
HID: i2c-hid: Reorganize so ACPI and OF are separate modules
arm64: defconfig: Update config names for i2c-hid rejigger
dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix
GT7375P
HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core
.../bindings/input/goodix,gt7375p.yaml | 65 +++++
arch/arm64/configs/defconfig | 3 +-
drivers/hid/Makefile | 2 +-
drivers/hid/i2c-hid/Kconfig | 47 +++-
drivers/hid/i2c-hid/Makefile | 6 +-
drivers/hid/i2c-hid/i2c-hid-acpi.c | 159 +++++++++++
drivers/hid/i2c-hid/i2c-hid-core.c | 254 +++---------------
drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 116 ++++++++
drivers/hid/i2c-hid/i2c-hid-of.c | 143 ++++++++++
drivers/hid/i2c-hid/i2c-hid.h | 22 ++
include/linux/platform_data/i2c-hid.h | 41 ---
11 files changed, 596 insertions(+), 262 deletions(-)
create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c
create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c
create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c
delete mode 100644 include/linux/platform_data/i2c-hid.h
--
2.29.2.576.ga3fc446d84-goog
next reply other threads:[~2020-12-11 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 17:35 Douglas Anderson [this message]
2020-12-11 17:35 ` [PATCH v7 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules Douglas Anderson
[not found] ` <202012120310.liZcXbuL-lkp@intel.com>
2020-12-11 22:24 ` Doug Anderson
2020-12-11 17:35 ` [PATCH v7 2/4] arm64: defconfig: Update config names for i2c-hid rejigger Douglas Anderson
2020-12-11 17:35 ` [PATCH v7 3/4] dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Douglas Anderson
2020-12-11 17:35 ` [PATCH v7 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211173526.1516653-1-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=Anson.Huang@nxp.com \
--cc=admin@kryma.net \
--cc=agx@sigxcpu.org \
--cc=andrea@borgia.bo.it \
--cc=arnd@arndb.de \
--cc=benjamin.tissoires@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=coiby.xu@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=max.oss.09@gmail.com \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=swboyd@chromium.org \
--cc=tanxiaofei@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).