From: Alexey Dobriyan <adobriyan@gmail.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, po-hsu.lin@canonical.com
Subject: [PATCH] input, i8042: unbreak Pegatron C15B
Date: Mon, 28 Dec 2020 10:23:35 +0300
Message-ID: <20201228072335.GA27766@localhost.localdomain> (raw)
g++ reports
drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list
C99 semantics is that last duplicated initialiser wins,
so DMI entry gets overwritten.
Fixes: a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/input/serio/i8042-x86ia64io.h | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -219,6 +219,8 @@ static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
DMI_MATCH(DMI_SYS_VENDOR, "PEGATRON CORPORATION"),
DMI_MATCH(DMI_PRODUCT_NAME, "C15B"),
},
+ },
+ {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "ByteSpeed LLC"),
DMI_MATCH(DMI_PRODUCT_NAME, "ByteSpeed Laptop C15B"),
next reply index
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 7:23 Alexey Dobriyan [this message]
2020-12-28 7:48 ` ACK: " Po-Hsu Lin
2021-01-04 22:56 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228072335.GA27766@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=po-hsu.lin@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux Input Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
linux-input@vger.kernel.org
public-inbox-index linux-input
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git