[PATCH] HID: asus: Filter keyboard EC for old ROG keyboard

[PATCH] HID: asus: Filter keyboard EC for old ROG keyboard

[Luke D Jones]

Older ROG keyboards emit a similar stream of bytes to the new
N-Key keyboards and require filtering to prevent a lot of
unmapped key warnings showing. As all the ROG keyboards use
QUIRK_USE_KBD_BACKLIGHT this is now used to branch to filtering
in asus_raw_event.

Signed-off-by: Luke D Jones <luke@ljones.dev>
---
 drivers/hid/hid-asus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 2ab22b925941..1ed1c05c3d54 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -335,7 +335,7 @@ static int asus_raw_event(struct hid_device *hdev,
 	if (drvdata->quirks & QUIRK_MEDION_E1239T)
 		return asus_e1239t_event(drvdata, data, size);
 
-	if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) {
+	if (drvdata->quirks & QUIRK_USE_KBD_BACKLIGHT) {
 		/*
 		 * Skip these report ID, the device emits a continuous stream associated
 		 * with the AURA mode it is in which looks like an 'echo'.
-- 
2.30.1

Re: [PATCH] HID: asus: Filter keyboard EC for old ROG keyboard

[Luke Jones]

Hi all,

Can I get a status on this patch please? I've not had feedback.
I can verify that the same changed in a dkms module used by
hundreds of others is working quite well.

Cheers,
Luke

On Fri, 19 Feb 2021, at 10:38 AM, Luke D Jones wrote:
> Older ROG keyboards emit a similar stream of bytes to the new
> N-Key keyboards and require filtering to prevent a lot of
> unmapped key warnings showing. As all the ROG keyboards use
> QUIRK_USE_KBD_BACKLIGHT this is now used to branch to filtering
> in asus_raw_event.
> 
> Signed-off-by: Luke D Jones <luke@ljones.dev <mailto:luke%40ljones.dev>>
> ---
> drivers/hid/hid-asus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 2ab22b925941..1ed1c05c3d54 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -335,7 +335,7 @@ static int asus_raw_event(struct hid_device *hdev,
> if (drvdata->quirks & QUIRK_MEDION_E1239T)
> return asus_e1239t_event(drvdata, data, size);
>  
> - if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) {
> + if (drvdata->quirks & QUIRK_USE_KBD_BACKLIGHT) {
> /*
> * Skip these report ID, the device emits a continuous stream associated
> * with the AURA mode it is in which looks like an 'echo'.
> -- 
> 2.30.1
> 
> 

Re: [PATCH] HID: asus: Filter keyboard EC for old ROG keyboard

[Jiri Kosina]

On Fri, 19 Feb 2021, Luke D Jones wrote:

> Older ROG keyboards emit a similar stream of bytes to the new
> N-Key keyboards and require filtering to prevent a lot of
> unmapped key warnings showing. As all the ROG keyboards use
> QUIRK_USE_KBD_BACKLIGHT this is now used to branch to filtering
> in asus_raw_event.
> 
> Signed-off-by: Luke D Jones <luke@ljones.dev>

Applied now, thanks.

-- 
Jiri Kosina
SUSE Labs