[PATCH for-next 0/2] Fixes to amd_sfh driver

[PATCH for-next 0/2] Fixes to amd_sfh driver

[Basavaraj Natikar]

Changes includes to handle "no sensors" case and fix of implicit
declaration error on i386.

Link: https://lore.kernel.org/all/92ed10f9-2c84-ad42-20d1-f8a101f78f08@infradead.org/
'''
From: Randy Dunlap <rdunlap@infradead.org>
Changes since 20220721:

on i386:

../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c: In function ‘amd_stop_sensor’:
../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c:48:9: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration]
   48 |         writeq(0x0, privdata->mmio + AMD_C2P_MSG(1));
      |         ^~~~~~
      |         writel
'''

Basavaraj Natikar (2):
  HID: amd_sfh: Fix implicit declaration error on i386
  HID: amd_sfh: Handle condition of "no sensors"

 drivers/hid/amd-sfh-hid/amd_sfh_client.c           | 2 ++
 drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c | 2 ++
 2 files changed, 4 insertions(+)

-- 
2.25.1

[PATCH for-next 1/2] HID: amd_sfh: Fix implicit declaration error on i386

[Basavaraj Natikar]

Add depended header file to fix error on i386 due to implicit
declaration of function ‘writeq’.

Fixes: 93ce5e0231d7 ("HID: amd_sfh: Implement SFH1.1 functionality")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
---
 drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c
index 14a1578055b6..c6df959ec725 100644
--- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c
+++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c
@@ -7,7 +7,9 @@
  *
  * Author: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
  */
+#include <linux/io-64-nonatomic-lo-hi.h>
 #include <linux/iopoll.h>
+
 #include "amd_sfh_interface.h"
 
 static int amd_sfh_wait_response(struct amd_mp2_dev *mp2, u8 sid, u32 cmd_id)
-- 
2.25.1

[PATCH for-next 2/2] HID: amd_sfh: Handle condition of "no sensors"

[Basavaraj Natikar]

Add a check for num_hid_devices to handle special case the situation
of "no sensors".

Fixes: 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor Fusion Hub (SFH)")
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
---
 drivers/hid/amd-sfh-hid/amd_sfh_client.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_client.c b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
index f95e623040f3..8275bba63611 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_client.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
@@ -225,6 +225,8 @@ int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata)
 	mp2_ops->resume = amd_sfh_resume;
 
 	cl_data->num_hid_devices = amd_mp2_get_sensor_num(privdata, &cl_data->sensor_idx[0]);
+	if (cl_data->num_hid_devices == 0)
+		return -ENODEV;
 
 	INIT_DELAYED_WORK(&cl_data->work, amd_sfh_work);
 	INIT_DELAYED_WORK(&cl_data->work_buffer, amd_sfh_work_buffer);
-- 
2.25.1

Re: [PATCH for-next 0/2] Fixes to amd_sfh driver

[Jiri Kosina]

On Sat, 23 Jul 2022, Basavaraj Natikar wrote:

> Changes includes to handle "no sensors" case and fix of implicit
> declaration error on i386.
> 
> Link: https://lore.kernel.org/all/92ed10f9-2c84-ad42-20d1-f8a101f78f08@infradead.org/
> '''
> From: Randy Dunlap <rdunlap@infradead.org>
> Changes since 20220721:
> 
> on i386:
> 
> ../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c: In function ‘amd_stop_sensor’:
> ../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c:48:9: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration]
>    48 |         writeq(0x0, privdata->mmio + AMD_C2P_MSG(1));
>       |         ^~~~~~
>       |         writel
> '''
> 
> Basavaraj Natikar (2):
>   HID: amd_sfh: Fix implicit declaration error on i386
>   HID: amd_sfh: Handle condition of "no sensors"
> 
>  drivers/hid/amd-sfh-hid/amd_sfh_client.c           | 2 ++
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c | 2 ++
>  2 files changed, 4 insertions(+)

Queued in hid.git, thanks.

-- 
Jiri Kosina
SUSE Labs