* [PATCH v2] HID: Add Mapping for System Microphone Mute
@ 2022-12-13 22:53 Jingyuan Liang
2022-12-20 14:33 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Jingyuan Liang @ 2022-12-13 22:53 UTC (permalink / raw)
To: LKML, linux-input
Cc: seobrien, dtor, hbarnor, Jingyuan Liang, Benjamin Tissoires, Jiri Kosina
HUTRR110 added a new usage code for a key that is supposed to
mute/unmute microphone system-wide.
Map the new usage code(0x01 0xa9) to keycode KEY_MICMUTE.
Additionally hid-debug is adjusted to recognize this keycode as well.
Signed-off-by: Jingyuan Liang <jingyliang@chromium.org>
---
V1 -> V2: Replaced "This patch maps" with "Map" in commit message and
addressed review comments
---
drivers/hid/hid-debug.c | 1 +
drivers/hid/hid-input.c | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index 2ca6ab600bc9..15e35702773c 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -972,6 +972,7 @@ static const char *keys[KEY_MAX + 1] = {
[KEY_KBD_LAYOUT_NEXT] = "KbdLayoutNext",
[KEY_EMOJI_PICKER] = "EmojiPicker",
[KEY_DICTATE] = "Dictate",
+ [KEY_MICMUTE] = "MicrophoneMute",
[KEY_BRIGHTNESS_MIN] = "BrightnessMin",
[KEY_BRIGHTNESS_MAX] = "BrightnessMax",
[KEY_BRIGHTNESS_AUTO] = "BrightnessAuto",
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 859aeb07542e..6396ed434b37 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -781,6 +781,14 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
break;
}
+ if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
+ switch (usage->hid & 0xf) {
+ case 0x9: map_key_clear(KEY_MICMUTE); break;
+ default: goto ignore;
+ }
+ break;
+ }
+
if ((usage->hid & 0xf0) == 0xb0) { /* SC - Display */
switch (usage->hid & 0xf) {
case 0x05: map_key_clear(KEY_SWITCHVIDEOMODE); break;
--
2.39.0.rc1.256.g54fd8350bd-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] HID: Add Mapping for System Microphone Mute
2022-12-13 22:53 [PATCH v2] HID: Add Mapping for System Microphone Mute Jingyuan Liang
@ 2022-12-20 14:33 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2022-12-20 14:33 UTC (permalink / raw)
To: Jingyuan Liang
Cc: LKML, linux-input, seobrien, dtor, hbarnor, Benjamin Tissoires
On Tue, 13 Dec 2022, Jingyuan Liang wrote:
> HUTRR110 added a new usage code for a key that is supposed to
> mute/unmute microphone system-wide.
>
> Map the new usage code(0x01 0xa9) to keycode KEY_MICMUTE.
> Additionally hid-debug is adjusted to recognize this keycode as well.
>
> Signed-off-by: Jingyuan Liang <jingyliang@chromium.org>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-20 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-13 22:53 [PATCH v2] HID: Add Mapping for System Microphone Mute Jingyuan Liang
2022-12-20 14:33 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).