From: Roderick Colenbrander <roderick@gaikai.com>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org,
Roderick Colenbrander <roderick.colenbrander@sony.com>,
Abaci Robot <abaci@linux.alibaba.com>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <error27@gmail.com>
Subject: [PATCH 1/5] HID: playstation: fix DualShock4 unreachable calibration code.
Date: Thu, 5 Jan 2023 17:59:06 -0800 [thread overview]
Message-ID: <20230106015910.3031670-2-roderick.colenbrander@sony.com> (raw)
In-Reply-To: <20230106015910.3031670-1-roderick.colenbrander@sony.com>
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Reported-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
---
drivers/hid/hid-playstation.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index f399bf0d3c8c..866cc4e94320 100644
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -1759,11 +1759,10 @@ static int dualshock4_get_calibration_data(struct dualshock4 *ds4)
if (retries < 2) {
hid_warn(hdev, "Retrying DualShock 4 get calibration report (0x02) request\n");
continue;
- } else {
- ret = -EILSEQ;
- goto err_free;
}
+
hid_err(hdev, "Failed to retrieve DualShock4 calibration info: %d\n", ret);
+ ret = -EILSEQ;
goto err_free;
} else {
break;
--
2.38.1
next prev parent reply other threads:[~2023-01-06 1:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 1:59 [PATCH 0/5] HID: playstation: various DS4 and DualSense fixes Roderick Colenbrander
2023-01-06 1:59 ` Roderick Colenbrander [this message]
2023-01-18 9:11 ` [PATCH 1/5] HID: playstation: fix DualShock4 unreachable calibration code Jiri Kosina
2023-01-06 1:59 ` [PATCH 2/5] HID: playstation: sanity check DualShock4 calibration data Roderick Colenbrander
2023-01-18 9:10 ` Jiri Kosina
2023-01-06 1:59 ` [PATCH 3/5] HID: playstation: sanity check DualSense " Roderick Colenbrander
2023-01-18 9:11 ` Jiri Kosina
2023-01-06 1:59 ` [PATCH 4/5] HID: playstation: correct DualShock4 gyro bias handling Roderick Colenbrander
2023-01-18 9:12 ` Jiri Kosina
2023-01-06 1:59 ` [PATCH 5/5] HID: playstation: correct DualSense " Roderick Colenbrander
2023-01-18 9:12 ` Jiri Kosina
2023-01-18 9:13 ` [PATCH 0/5] HID: playstation: various DS4 and DualSense fixes Jiri Kosina
2023-01-18 18:42 ` Roderick Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106015910.3031670-2-roderick.colenbrander@sony.com \
--to=roderick@gaikai.com \
--cc=abaci@linux.alibaba.com \
--cc=benjamin.tissoires@redhat.com \
--cc=error27@gmail.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lkp@intel.com \
--cc=roderick.colenbrander@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).