From: Jiri Kosina <jikos@kernel.org>
To: Roderick Colenbrander <roderick@gaikai.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH 0/5] HID: playstation: various DS4 and DualSense fixes
Date: Wed, 18 Jan 2023 10:13:32 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2301181013030.1734@cbobk.fhfr.pm> (raw)
In-Reply-To: <20230106015910.3031670-1-roderick.colenbrander@sony.com>
On Thu, 5 Jan 2023, Roderick Colenbrander wrote:
> Hi,
>
> This patch set contains a number of small fixes and stability improvements.
>
> The stability patches are most critical as they prevent kernel crashes.
> Over the years there have been various buggy devices usually clone devices,
> but now apparently some official devices with wiped calibration data.
> It is hard to handle all permutations of devices as some have constants,
> some have broken constants (e.g. wrong sign of a coefficient). We disable
> calibration when we see an invalid 0 denominator. The patch adds the same
> logic to both the DualShock4 and DualSense code.
>
> As part of the calibration stability improvements, a thorough review was
> performed of the calibration code as it was suspected it was potentially
> incorrect. It was found to be only slightly wrong for the handling of the
> bias of the gyroscopes. Two patches fix this for both DualShock4 and DualSense.
> There is only a marginal impact on practical values as the bias values
> tend to be quite small.
>
> Thanks,
> Roderick Colenbrander
> Sony Interactive Entertainment, LLC
I am splitting the stability ones (for 6.2) from the small improvements /
cleanups (for 6.3).
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2023-01-18 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 1:59 [PATCH 0/5] HID: playstation: various DS4 and DualSense fixes Roderick Colenbrander
2023-01-06 1:59 ` [PATCH 1/5] HID: playstation: fix DualShock4 unreachable calibration code Roderick Colenbrander
2023-01-18 9:11 ` Jiri Kosina
2023-01-06 1:59 ` [PATCH 2/5] HID: playstation: sanity check DualShock4 calibration data Roderick Colenbrander
2023-01-18 9:10 ` Jiri Kosina
2023-01-06 1:59 ` [PATCH 3/5] HID: playstation: sanity check DualSense " Roderick Colenbrander
2023-01-18 9:11 ` Jiri Kosina
2023-01-06 1:59 ` [PATCH 4/5] HID: playstation: correct DualShock4 gyro bias handling Roderick Colenbrander
2023-01-18 9:12 ` Jiri Kosina
2023-01-06 1:59 ` [PATCH 5/5] HID: playstation: correct DualSense " Roderick Colenbrander
2023-01-18 9:12 ` Jiri Kosina
2023-01-18 9:13 ` Jiri Kosina [this message]
2023-01-18 18:42 ` [PATCH 0/5] HID: playstation: various DS4 and DualSense fixes Roderick Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2301181013030.1734@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).