* [PATCH 1/4] HID: steelseries: explicitly include linux/leds.h
2023-02-15 1:03 [PATCH 0/4] HID: explicitly include linux/leds.h Thomas Weißschuh
@ 2023-02-15 1:03 ` Thomas Weißschuh
2023-02-15 1:03 ` [PATCH 2/4] HID: lg-g15: " Thomas Weißschuh
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Thomas Weißschuh @ 2023-02-15 1:03 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Hans de Goede
Cc: linux-input, linux-kernel, Thomas Weißschuh
Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hid/hid-steelseries.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-steelseries.c
index 37353c41cba7..aae3afc4107a 100644
--- a/drivers/hid/hid-steelseries.c
+++ b/drivers/hid/hid-steelseries.c
@@ -11,6 +11,7 @@
#include <linux/device.h>
#include <linux/hid.h>
#include <linux/module.h>
+#include <linux/leds.h>
#include "hid-ids.h"
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/4] HID: lg-g15: explicitly include linux/leds.h
2023-02-15 1:03 [PATCH 0/4] HID: explicitly include linux/leds.h Thomas Weißschuh
2023-02-15 1:03 ` [PATCH 1/4] HID: steelseries: " Thomas Weißschuh
@ 2023-02-15 1:03 ` Thomas Weißschuh
2023-02-15 1:03 ` [PATCH 3/4] HID: asus: " Thomas Weißschuh
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Thomas Weißschuh @ 2023-02-15 1:03 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Hans de Goede
Cc: linux-input, linux-kernel, Thomas Weißschuh
Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hid/hid-lg-g15.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-lg-g15.c b/drivers/hid/hid-lg-g15.c
index c8f82bcbf1ab..acbec1dcf196 100644
--- a/drivers/hid/hid-lg-g15.c
+++ b/drivers/hid/hid-lg-g15.c
@@ -7,6 +7,7 @@
#include <linux/device.h>
#include <linux/hid.h>
+#include <linux/leds.h>
#include <linux/module.h>
#include <linux/random.h>
#include <linux/sched.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/4] HID: asus: explicitly include linux/leds.h
2023-02-15 1:03 [PATCH 0/4] HID: explicitly include linux/leds.h Thomas Weißschuh
2023-02-15 1:03 ` [PATCH 1/4] HID: steelseries: " Thomas Weißschuh
2023-02-15 1:03 ` [PATCH 2/4] HID: lg-g15: " Thomas Weißschuh
@ 2023-02-15 1:03 ` Thomas Weißschuh
2023-02-15 1:03 ` [PATCH 4/4] HID: apple: " Thomas Weißschuh
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Thomas Weißschuh @ 2023-02-15 1:03 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Hans de Goede
Cc: linux-input, linux-kernel, Thomas Weißschuh
Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hid/hid-asus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index f99752b998f3..44074c9efa00 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -30,6 +30,7 @@
#include <linux/input/mt.h>
#include <linux/usb.h> /* For to_usb_interface for T100 touchpad intf check */
#include <linux/power_supply.h>
+#include <linux/leds.h>
#include "hid-ids.h"
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/4] HID: apple: explicitly include linux/leds.h
2023-02-15 1:03 [PATCH 0/4] HID: explicitly include linux/leds.h Thomas Weißschuh
` (2 preceding siblings ...)
2023-02-15 1:03 ` [PATCH 3/4] HID: asus: " Thomas Weißschuh
@ 2023-02-15 1:03 ` Thomas Weißschuh
2023-03-20 22:18 ` [PATCH 0/4] HID: " Thomas Weißschuh
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Thomas Weißschuh @ 2023-02-15 1:03 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Hans de Goede
Cc: linux-input, linux-kernel, Thomas Weißschuh
Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hid/hid-apple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index 1ccab8aa326c..c5b45cd1e44d 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/timer.h>
#include <linux/string.h>
+#include <linux/leds.h>
#include "hid-ids.h"
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/4] HID: explicitly include linux/leds.h
2023-02-15 1:03 [PATCH 0/4] HID: explicitly include linux/leds.h Thomas Weißschuh
` (3 preceding siblings ...)
2023-02-15 1:03 ` [PATCH 4/4] HID: apple: " Thomas Weißschuh
@ 2023-03-20 22:18 ` Thomas Weißschuh
2023-04-13 15:11 ` Benjamin Tissoires
2023-04-13 15:04 ` (subset) " Benjamin Tissoires
2023-04-13 15:10 ` Benjamin Tissoires
6 siblings, 1 reply; 9+ messages in thread
From: Thomas Weißschuh @ 2023-03-20 22:18 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Hans de Goede; +Cc: linux-input, linux-kernel
Friendly ping,
this seems to have fallen through the cracks.
Thanks,
Thomas
On Wed, Feb 15, 2023 at 01:03:33AM +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (4):
> HID: steelseries: explicitly include linux/leds.h
> HID: lg-g15: explicitly include linux/leds.h
> HID: asus: explicitly include linux/leds.h
> HID: apple: explicitly include linux/leds.h
>
> drivers/hid/hid-apple.c | 1 +
> drivers/hid/hid-asus.c | 1 +
> drivers/hid/hid-lg-g15.c | 1 +
> drivers/hid/hid-steelseries.c | 1 +
> 4 files changed, 4 insertions(+)
> ---
> base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
> change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/4] HID: explicitly include linux/leds.h
2023-03-20 22:18 ` [PATCH 0/4] HID: " Thomas Weißschuh
@ 2023-04-13 15:11 ` Benjamin Tissoires
0 siblings, 0 replies; 9+ messages in thread
From: Benjamin Tissoires @ 2023-04-13 15:11 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: Jiri Kosina, Hans de Goede, linux-input, linux-kernel
On Mar 20 2023, Thomas Weißschuh wrote:
> Friendly ping,
>
> this seems to have fallen through the cracks.
Sorry for the delay.
I have applied them now, as should have told you the automatic
notifications.
Cheers,
Benjamin
>
> Thanks,
> Thomas
>
> On Wed, Feb 15, 2023 at 01:03:33AM +0000, Thomas Weißschuh wrote:
> > Instead of relying on an accidental, transitive inclusion of linux/leds.h
> > use it directly.
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> > Thomas Weißschuh (4):
> > HID: steelseries: explicitly include linux/leds.h
> > HID: lg-g15: explicitly include linux/leds.h
> > HID: asus: explicitly include linux/leds.h
> > HID: apple: explicitly include linux/leds.h
> >
> > drivers/hid/hid-apple.c | 1 +
> > drivers/hid/hid-asus.c | 1 +
> > drivers/hid/hid-lg-g15.c | 1 +
> > drivers/hid/hid-steelseries.c | 1 +
> > 4 files changed, 4 insertions(+)
> > ---
> > base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
> > change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf
> >
> > Best regards,
> > --
> > Thomas Weißschuh <linux@weissschuh.net>
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 0/4] HID: explicitly include linux/leds.h
2023-02-15 1:03 [PATCH 0/4] HID: explicitly include linux/leds.h Thomas Weißschuh
` (4 preceding siblings ...)
2023-03-20 22:18 ` [PATCH 0/4] HID: " Thomas Weißschuh
@ 2023-04-13 15:04 ` Benjamin Tissoires
2023-04-13 15:10 ` Benjamin Tissoires
6 siblings, 0 replies; 9+ messages in thread
From: Benjamin Tissoires @ 2023-04-13 15:04 UTC (permalink / raw)
To: Jiri Kosina, Hans de Goede, Thomas Weißschuh
Cc: linux-input, linux-kernel
On Wed, 15 Feb 2023 01:03:33 +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
>
>
Applied to hid/hid.git (for-6.4/apple), thanks!
[4/4] HID: apple: explicitly include linux/leds.h
https://git.kernel.org/hid/hid/c/6c89c1160321
Cheers,
--
Benjamin Tissoires <benjamin.tissoires@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: (subset) [PATCH 0/4] HID: explicitly include linux/leds.h
2023-02-15 1:03 [PATCH 0/4] HID: explicitly include linux/leds.h Thomas Weißschuh
` (5 preceding siblings ...)
2023-04-13 15:04 ` (subset) " Benjamin Tissoires
@ 2023-04-13 15:10 ` Benjamin Tissoires
6 siblings, 0 replies; 9+ messages in thread
From: Benjamin Tissoires @ 2023-04-13 15:10 UTC (permalink / raw)
To: Jiri Kosina, Hans de Goede, Thomas Weißschuh
Cc: linux-input, linux-kernel
On Wed, 15 Feb 2023 01:03:33 +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
>
>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.4/led-includes), thanks!
[1/4] HID: steelseries: explicitly include linux/leds.h
https://git.kernel.org/hid/hid/c/f28bb5ce4f15
[2/4] HID: lg-g15: explicitly include linux/leds.h
https://git.kernel.org/hid/hid/c/21c5bd5b4b06
[3/4] HID: asus: explicitly include linux/leds.h
https://git.kernel.org/hid/hid/c/a2654c1f640c
Cheers,
--
Benjamin Tissoires <benjamin.tissoires@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread