* [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes
@ 2022-10-04 8:08 Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
` (10 more replies)
0 siblings, 11 replies; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
This is a first round of trivial bindings & DT fixes for the MDM9615 platform.
This first round focuses on trivial changes, the remaining work will
mainly be .txt to .yaml transition of old qcom pmic & co device bindings.
To: Andy Gross <agross@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Lee Jones <lee@kernel.org>
To: Satya Priya <quic_c_skakit@quicinc.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alessandro Zummo <a.zummo@towertech.it>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: linux-input@vger.kernel.org
Cc: linux-rtc@vger.kernel.org
Dependencies: None
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v2:
- patch 1: switch to move from swir.txt to qcom.yaml
- patch 2: use MIT licence instead of X11 licence
- patch 3: move reg after compatible
- patch 4: added Krzysztof's review
- patch 5: split into 5 changes:
- document qcom,pm8921 as fallback of qcom,pm8018
- convert qcom,pm8921-pwrkey to dt-schema
- document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc
- drop unused PM8018 compatible
- drop unused pm8018 RTC compatible
- patch 6: None
- patch 7: Reworded commit log based on Dmitry's wording on similar patches
- Link to v1: https://lore.kernel.org/r/20220928-mdm9615-dt-schema-fixes-v1-0-b6e63a7df1e8@linaro.org
---
Neil Armstrong (11):
dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml
arm: dts: qcom: mdm9615*: add SPDX-License-Identifier
arm: dts: qcom: mdm9615: add missing reg in cpu@0 node
arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node
dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018
dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema
dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc
mfd: qcom-pm8xxx: drop unused PM8018 compatible
rtc: pm8xxx: drop unused pm8018 compatible
arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes
arm: dts: qcom: mdm9615: remove useless amba subnode
Documentation/devicetree/bindings/arm/qcom.yaml | 6 +
Documentation/devicetree/bindings/arm/swir.txt | 12 --
.../bindings/input/qcom,pm8921-pwrkey.yaml | 77 +++++++++++++
.../bindings/input/qcom,pm8xxx-pwrkey.txt | 46 --------
.../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 45 +++++++-
.../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 16 ++-
.../boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 39 +------
arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi | 39 +------
arch/arm/boot/dts/qcom-mdm9615.dtsi | 121 +++++++--------------
drivers/mfd/qcom-pm8xxx.c | 1 -
drivers/rtc/rtc-pm8xxx.c | 1 -
11 files changed, 173 insertions(+), 230 deletions(-)
---
base-commit: f76349cf41451c5c42a99f18a9163377e4b364ff
change-id: 20220928-mdm9615-dt-schema-fixes-66d4d0ccb7c7
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 8:51 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
` (9 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
Document into the main qcom.yaml as conversion from swir.txt to dt-schema.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index fb1d00bcc847..e9f38f0cef19 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -262,6 +262,12 @@ properties:
- qcom,ipq8074-hk10-c2
- const: qcom,ipq8074
+ - description: Sierra Wireless MangOH Green with WP8548 Module
+ items:
+ - const: swir,mangoh-green-wp8548
+ - const: swir,wp8548
+ - const: qcom,mdm9615
+
- description: Qualcomm Technologies, Inc. SC7180 IDP
items:
- enum:
diff --git a/Documentation/devicetree/bindings/arm/swir.txt b/Documentation/devicetree/bindings/arm/swir.txt
deleted file mode 100644
index 042be73a95d3..000000000000
--- a/Documentation/devicetree/bindings/arm/swir.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-Sierra Wireless Modules device tree bindings
---------------------------------------------
-
-Supported Modules :
- - WP8548 : Includes MDM9615 and PM8018 in a module
-
-Sierra Wireless modules shall have the following properties :
- Required root node property
- - compatible: "swir,wp8548" for the WP8548 CF3 Module
-
-Board compatible values:
- - "swir,mangoh-green-wp8548" for the mangOH green board with the WP8548 module
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 8:52 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
` (8 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
Replace the licence blob by a clean SPDX-License-Identifier
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
index 0827de5426c1..4e53b3d70195 100644
--- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
+++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
@@ -1,46 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
/*
* Device Tree Source for mangOH Green Board with WP8548 Module
*
* Copyright (C) 2016 BayLibre, SAS.
* Author : Neil Armstrong <narmstrong@baylibre.com>
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of the
- * License, or (at your option) any later version.
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively,
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without
- * restriction, including without limitation the rights to use,
- * copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
- * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- * OTHER DEALINGS IN THE SOFTWARE.
*/
#include <dt-bindings/input/input.h>
diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi b/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
index 49de1821ac3a..2fe8693dc3cd 100644
--- a/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
@@ -1,46 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
/*
* Device Tree Source for Sierra Wireless WP8548 Module
*
* Copyright (C) 2016 BayLibre, SAS.
* Author : Neil Armstrong <narmstrong@baylibre.com>
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of the
- * License, or (at your option) any later version.
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively,
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without
- * restriction, including without limitation the rights to use,
- * copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
- * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- * OTHER DEALINGS IN THE SOFTWARE.
*/
#include "qcom-mdm9615.dtsi"
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index b47c86412de2..de36e4545e75 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -1,46 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
/*
* Device Tree Source for Qualcomm MDM9615 SoC
*
* Copyright (C) 2016 BayLibre, SAS.
* Author : Neil Armstrong <narmstrong@baylibre.com>
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of the
- * License, or (at your option) any later version.
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively,
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without
- * restriction, including without limitation the rights to use,
- * copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
- * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- * OTHER DEALINGS IN THE SOFTWARE.
*/
/dts-v1/;
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 8:53 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
` (7 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
Fixes cpu@0: 'reg' is a required property from dtbs check.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index de36e4545e75..eaa3236f62db 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -27,6 +27,7 @@ cpus {
cpu0: cpu@0 {
compatible = "arm,cortex-a5";
+ reg = <0>;
device_type = "cpu";
next-level-cache = <&L2>;
};
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (2 preceding siblings ...)
2022-10-04 8:08 ` [PATCH v2 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
` (6 subsequent siblings)
10 siblings, 0 replies; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
The spi-max-frequency property has nothing to do in the controller's node,
remove it and fix the 'spi-max-frequency' was unexpected dtbs check error.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index eaa3236f62db..366241dee522 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -170,7 +170,6 @@ gsbi3_spi: spi@16280000 {
#size-cells = <0>;
reg = <0x16280000 0x1000>;
interrupts = <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>;
- spi-max-frequency = <24000000>;
clocks = <&gcc GSBI3_QUP_CLK>, <&gcc GSBI3_H_CLK>;
clock-names = "core", "iface";
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (3 preceding siblings ...)
2022-10-04 8:08 ` [PATCH v2 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 8:55 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
` (5 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
The PM8018 is used as compatible with PM8921 on the MDM9615, document this situation,
and an example section to validate this change.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
index 61bd0b3ce02f..24d71918ff8a 100644
--- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
@@ -15,11 +15,15 @@ description: |
properties:
compatible:
- enum:
- - qcom,pm8018
- - qcom,pm8058
- - qcom,pm8821
- - qcom,pm8921
+ oneOf:
+ - enum:
+ - qcom,pm8058
+ - qcom,pm8821
+ - qcom,pm8921
+ - items:
+ - enum:
+ - qcom,pm8018
+ - const: qcom,pm8921
reg:
maxItems: 1
@@ -52,4 +56,35 @@ required:
- interrupt-controller
additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ ssbi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pmic@0 {
+ compatible = "qcom,pm8921";
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <32 IRQ_TYPE_EDGE_RISING>;
+ };
+
+ pmic@1 {
+ compatible = "qcom,pm8018", "qcom,pm8921";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <33 IRQ_TYPE_EDGE_RISING>;
+ };
+ };
...
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (4 preceding siblings ...)
2022-10-04 8:08 ` [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 8:59 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
` (4 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that
the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
new file mode 100644
index 000000000000..ae38c4ef4932
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/qcom,pm8921-pwrkey.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PM8921 PMIC Power Key
+
+maintainers:
+ - Andy Gross <agross@kernel.org>
+ - Bjorn Andersson <andersson@kernel.org>
+
+allOf:
+ - $ref: input.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - qcom,pm8921-pwrkey
+ - qcom,pm8058-pwrkey
+ - items:
+ - enum:
+ - qcom,pm8018-pwrkey
+ - const: qcom,pm8921-pwrkey
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 2
+ description: |
+ The first interrupt specifies the key release interrupt
+ and the second interrupt specifies the key press interrupt.
+
+ debounce:
+ description: |
+ Time in microseconds that key must be pressed or
+ released for state change interrupt to trigger.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ pull-up:
+ description: |
+ Presence of this property indicates that the KPDPWR_N
+ pin should be configured for pull up.
+ $ref: /schemas/types.yaml#/definitions/flag
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ ssbi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@0 {
+ reg = <0x0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pwrkey@1c {
+ compatible = "qcom,pm8921-pwrkey";
+ reg = <0x1c>;
+ interrupt-parent = <&pmicint>;
+ interrupts = <50 1>, <51 1>;
+ debounce = <15625>;
+ pull-up;
+ };
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
deleted file mode 100644
index 588536cc96ed..000000000000
--- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
+++ /dev/null
@@ -1,46 +0,0 @@
-Qualcomm PM8xxx PMIC Power Key
-
-PROPERTIES
-
-- compatible:
- Usage: required
- Value type: <string>
- Definition: must be one of:
- "qcom,pm8058-pwrkey"
- "qcom,pm8921-pwrkey"
-
-- reg:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: address of power key control register
-
-- interrupts:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: the first interrupt specifies the key release interrupt
- and the second interrupt specifies the key press interrupt.
- The format of the specifier is defined by the binding
- document describing the node's interrupt parent.
-
-- debounce:
- Usage: optional
- Value type: <u32>
- Definition: time in microseconds that key must be pressed or release
- for state change interrupt to trigger.
-
-- pull-up:
- Usage: optional
- Value type: <empty>
- Definition: presence of this property indicates that the KPDPWR_N pin
- should be configured for pull up.
-
-EXAMPLE
-
- pwrkey@1c {
- compatible = "qcom,pm8921-pwrkey";
- reg = <0x1c>;
- interrupt-parent = <&pmicintc>;
- interrupts = <50 1>, <51 1>;
- debounce = <15625>;
- pull-up;
- };
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (5 preceding siblings ...)
2022-10-04 8:08 ` [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 9:00 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
` (3 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
The PM8018 RTC is used as compatible with PM8921 RTC on the MDM9615, document this situation.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
index 23ab5bb4f395..0a7aa29563c1 100644
--- a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
@@ -11,12 +11,16 @@ maintainers:
properties:
compatible:
- enum:
- - qcom,pm8058-rtc
- - qcom,pm8921-rtc
- - qcom,pm8941-rtc
- - qcom,pm8018-rtc
- - qcom,pmk8350-rtc
+ oneOf:
+ - enum:
+ - qcom,pm8058-rtc
+ - qcom,pm8921-rtc
+ - qcom,pm8941-rtc
+ - qcom,pmk8350-rtc
+ - items:
+ - enum:
+ - qcom,pm8018-rtc
+ - const: qcom,pm8921-rtc
reg:
minItems: 1
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (6 preceding siblings ...)
2022-10-04 8:08 ` [PATCH v2 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 9:02 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
` (2 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
The PM8921 compatible is used as fallback when PM8018 is available,
then remove PM8018 compatible.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
index 2f2734ba5273..601106580e2e 100644
--- a/drivers/mfd/qcom-pm8xxx.c
+++ b/drivers/mfd/qcom-pm8xxx.c
@@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = {
};
static const struct of_device_id pm8xxx_id_table[] = {
- { .compatible = "qcom,pm8018", .data = &pm8xxx_data},
{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
{ .compatible = "qcom,pm8821", .data = &pm8821_data},
{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 09/11] rtc: pm8xxx: drop unused pm8018 compatible
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (7 preceding siblings ...)
2022-10-04 8:08 ` [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 9:02 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
The PM8921 compatible is used as fallback when PM8018 is available,
then remove the PM8018 compatible.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index dc6d1476baa5..716e5d9ad74d 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -461,7 +461,6 @@ static const struct pm8xxx_rtc_regs pmk8350_regs = {
*/
static const struct of_device_id pm8xxx_id_table[] = {
{ .compatible = "qcom,pm8921-rtc", .data = &pm8921_regs },
- { .compatible = "qcom,pm8018-rtc", .data = &pm8921_regs },
{ .compatible = "qcom,pm8058-rtc", .data = &pm8058_regs },
{ .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },
{ .compatible = "qcom,pmk8350-rtc", .data = &pmk8350_regs },
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (8 preceding siblings ...)
2022-10-04 8:08 ` [PATCH v2 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
10 siblings, 0 replies; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
This solves the 'interrupt-names' was unexpected dtbs check error.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index 366241dee522..9d950f96280d 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -325,7 +325,6 @@ sdcc1: mmc@12180000 {
arm,primecell-periphid = <0x00051180>;
reg = <0x12180000 0x2000>;
interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "cmd_irq";
clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
clock-names = "mclk", "apb_pclk";
bus-width = <8>;
@@ -345,7 +344,6 @@ sdcc2: mmc@12140000 {
status = "disabled";
reg = <0x12140000 0x2000>;
interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "cmd_irq";
clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
clock-names = "mclk", "apb_pclk";
bus-width = <4>;
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (9 preceding siblings ...)
2022-10-04 8:08 ` [PATCH v2 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
@ 2022-10-04 8:08 ` Neil Armstrong
2022-10-04 9:03 ` Krzysztof Kozlowski
10 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Satya Priya, Andy Gross,
Alexandre Belloni, Rob Herring, Konrad Dybcio, Lee Jones,
Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, Bjorn Andersson, linux-input,
Krzysztof Kozlowski, Neil Armstrong, linux-arm-msm, linux-rtc
The separate amba device node doesn't add anything significant to the
DT. The OF parsing code already creates amba_device or platform_device
depending on the compatibility lists.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index 9d950f96280d..482fd246321c 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -314,49 +314,43 @@ sdcc2bam: dma-controller@12142000{
qcom,ee = <0>;
};
- amba {
- compatible = "simple-bus";
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
- sdcc1: mmc@12180000 {
- status = "disabled";
- compatible = "arm,pl18x", "arm,primecell";
- arm,primecell-periphid = <0x00051180>;
- reg = <0x12180000 0x2000>;
- interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
- clock-names = "mclk", "apb_pclk";
- bus-width = <8>;
- max-frequency = <48000000>;
- cap-sd-highspeed;
- cap-mmc-highspeed;
- vmmc-supply = <&vsdcc_fixed>;
- dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
- dma-names = "tx", "rx";
- assigned-clocks = <&gcc SDC1_CLK>;
- assigned-clock-rates = <400000>;
- };
+ sdcc1: mmc@12180000 {
+ status = "disabled";
+ compatible = "arm,pl18x", "arm,primecell";
+ arm,primecell-periphid = <0x00051180>;
+ reg = <0x12180000 0x2000>;
+ interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
+ clock-names = "mclk", "apb_pclk";
+ bus-width = <8>;
+ max-frequency = <48000000>;
+ cap-sd-highspeed;
+ cap-mmc-highspeed;
+ vmmc-supply = <&vsdcc_fixed>;
+ dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
+ dma-names = "tx", "rx";
+ assigned-clocks = <&gcc SDC1_CLK>;
+ assigned-clock-rates = <400000>;
+ };
- sdcc2: mmc@12140000 {
- compatible = "arm,pl18x", "arm,primecell";
- arm,primecell-periphid = <0x00051180>;
- status = "disabled";
- reg = <0x12140000 0x2000>;
- interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
- clock-names = "mclk", "apb_pclk";
- bus-width = <4>;
- cap-sd-highspeed;
- cap-mmc-highspeed;
- max-frequency = <48000000>;
- no-1-8-v;
- vmmc-supply = <&vsdcc_fixed>;
- dmas = <&sdcc2bam 2>, <&sdcc2bam 1>;
- dma-names = "tx", "rx";
- assigned-clocks = <&gcc SDC2_CLK>;
- assigned-clock-rates = <400000>;
- };
+ sdcc2: mmc@12140000 {
+ compatible = "arm,pl18x", "arm,primecell";
+ arm,primecell-periphid = <0x00051180>;
+ status = "disabled";
+ reg = <0x12140000 0x2000>;
+ interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
+ clock-names = "mclk", "apb_pclk";
+ bus-width = <4>;
+ cap-sd-highspeed;
+ cap-mmc-highspeed;
+ max-frequency = <48000000>;
+ no-1-8-v;
+ vmmc-supply = <&vsdcc_fixed>;
+ dmas = <&sdcc2bam 2>, <&sdcc2bam 1>;
+ dma-names = "tx", "rx";
+ assigned-clocks = <&gcc SDC2_CLK>;
+ assigned-clock-rates = <400000>;
};
tcsr: syscon@1a400000 {
--
b4 0.10.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml
2022-10-04 8:08 ` [PATCH v2 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
@ 2022-10-04 8:51 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 8:51 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> Document into the main qcom.yaml as conversion from swir.txt to dt-schema.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier
2022-10-04 8:08 ` [PATCH v2 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
@ 2022-10-04 8:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 8:52 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> Replace the licence blob by a clean SPDX-License-Identifier
typo: license
Please mention that the text of license is MIT, even though comment said
about X11.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node
2022-10-04 8:08 ` [PATCH v2 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
@ 2022-10-04 8:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 8:53 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> Fixes cpu@0: 'reg' is a required property from dtbs check.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018
2022-10-04 8:08 ` [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
@ 2022-10-04 8:55 ` Krzysztof Kozlowski
2022-10-04 9:38 ` Neil Armstrong
0 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 8:55 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> The PM8018 is used as compatible with PM8921 on the MDM9615, document this situation,
> and an example section to validate this change.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> index 61bd0b3ce02f..24d71918ff8a 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> @@ -15,11 +15,15 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - qcom,pm8018
> - - qcom,pm8058
> - - qcom,pm8821
> - - qcom,pm8921
> + oneOf:
> + - enum:
> + - qcom,pm8058
> + - qcom,pm8821
> + - qcom,pm8921
> + - items:
> + - enum:
> + - qcom,pm8018
> + - const: qcom,pm8921
>
> reg:
> maxItems: 1
> @@ -52,4 +56,35 @@ required:
> - interrupt-controller
>
> additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + ssbi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pmic@0 {
> + compatible = "qcom,pm8921";
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <32 IRQ_TYPE_EDGE_RISING>;
> + };
> +
> + pmic@1 {
> + compatible = "qcom,pm8018", "qcom,pm8921";
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <33 IRQ_TYPE_EDGE_RISING>;
> + };
These two pmics are exactly the same (except compatible), so just keep
one example... unless both are coming from the same, real DTS?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema
2022-10-04 8:08 ` [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
@ 2022-10-04 8:59 ` Krzysztof Kozlowski
2022-10-04 9:41 ` Neil Armstrong
0 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 8:59 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that
> the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
You miss diffstat... but I guess it's result of b4?
> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
> new file mode 100644
> index 000000000000..ae38c4ef4932
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/qcom,pm8921-pwrkey.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm PM8921 PMIC Power Key
> +
> +maintainers:
> + - Andy Gross <agross@kernel.org>
> + - Bjorn Andersson <andersson@kernel.org>
Keep only Bjorn. Andy did not review much for some time.
> +
> +allOf:
> + - $ref: input.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - qcom,pm8921-pwrkey
> + - qcom,pm8058-pwrkey
> + - items:
> + - enum:
> + - qcom,pm8018-pwrkey
> + - const: qcom,pm8921-pwrkey
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 2
> + description: |
> + The first interrupt specifies the key release interrupt
> + and the second interrupt specifies the key press interrupt.
In such case better to drop maxItems and description and write it:
items:
- description: key release interrupt
- description: key press interrupt
(maybe even the "interrupt" word could be skipped...)
> +
> + debounce:
> + description: |
> + Time in microseconds that key must be pressed or
> + released for state change interrupt to trigger.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pull-up:
> + description: |
> + Presence of this property indicates that the KPDPWR_N
> + pin should be configured for pull up.
> + $ref: /schemas/types.yaml#/definitions/flag
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + ssbi {
> + #address-cells = <1>;
> + #size-cells = <0>;
Messed indentation.
> +
> + pmic@0 {
> + reg = <0x0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pwrkey@1c {
> + compatible = "qcom,pm8921-pwrkey";
Messed up indentation. For entire DTS example keep 2 or 4 spaces.
> + reg = <0x1c>;
> + interrupt-parent = <&pmicint>;
> + interrupts = <50 1>, <51 1>;
Use defines for interrupt flags.
> + debounce = <15625>;
> + pull-up;
> + };
> + };
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc
2022-10-04 8:08 ` [PATCH v2 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
@ 2022-10-04 9:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 9:00 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> The PM8018 RTC is used as compatible with PM8921 RTC on the MDM9615, document this situation.
Please wrap commit message according to Linux coding style / submission
process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
With wrapping fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible
2022-10-04 8:08 ` [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
@ 2022-10-04 9:02 ` Krzysztof Kozlowski
2022-10-04 9:42 ` Neil Armstrong
0 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 9:02 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> The PM8921 compatible is used as fallback when PM8018 is available,
> then remove PM8018 compatible.
s/then/so/
But it's a bit confusing because PM8018 is not "available". It is
"present" or "is" instead, so rather:
"The PM8018 compatible is always used with PM8921 fallback, so PM8018
compatible can be safely removed from device ID table".
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 09/11] rtc: pm8xxx: drop unused pm8018 compatible
2022-10-04 8:08 ` [PATCH v2 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
@ 2022-10-04 9:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 9:02 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> The PM8921 compatible is used as fallback when PM8018 is available,
> then remove the PM8018 compatible.
Similar comments about msg.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode
2022-10-04 8:08 ` [PATCH v2 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
@ 2022-10-04 9:03 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 9:03 UTC (permalink / raw)
To: Neil Armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:08, Neil Armstrong wrote:
> The separate amba device node doesn't add anything significant to the
> DT. The OF parsing code already creates amba_device or platform_device
> depending on the compatibility lists.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018
2022-10-04 8:55 ` Krzysztof Kozlowski
@ 2022-10-04 9:38 ` Neil Armstrong
2022-10-04 10:03 ` Krzysztof Kozlowski
0 siblings, 1 reply; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 9:38 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 10:55, Krzysztof Kozlowski wrote:
> On 04/10/2022 10:08, Neil Armstrong wrote:
>> The PM8018 is used as compatible with PM8921 on the MDM9615, document this situation,
>> and an example section to validate this change.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>
<snip>
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + ssbi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + pmic@0 {
>> + compatible = "qcom,pm8921";
>> + reg = <0>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> +
>> + interrupt-parent = <&tlmm>;
>> + interrupts = <32 IRQ_TYPE_EDGE_RISING>;
>> + };
>> +
>> + pmic@1 {
>> + compatible = "qcom,pm8018", "qcom,pm8921";
>> + reg = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> +
>> + interrupt-parent = <&tlmm>;
>> + interrupts = <33 IRQ_TYPE_EDGE_RISING>;
>> + };
>
> These two pmics are exactly the same (except compatible), so just keep
> one example... unless both are coming from the same, real DTS?
It was mainly to exercise the fallback, but it's useless as-is so I'll remove in v3.
>
> Best regards,
> Krzysztof
>
Thanks,
Neil
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema
2022-10-04 8:59 ` Krzysztof Kozlowski
@ 2022-10-04 9:41 ` Neil Armstrong
0 siblings, 0 replies; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 9:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
Hi,
On 04/10/2022 10:59, Krzysztof Kozlowski wrote:
> On 04/10/2022 10:08, Neil Armstrong wrote:
>> Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that
>> the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>
>
> You miss diffstat... but I guess it's result of b4?
Yep, I'll update with last release to get it back.
>
>> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
>> new file mode 100644
>> index 000000000000..ae38c4ef4932
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
>> @@ -0,0 +1,77 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/input/qcom,pm8921-pwrkey.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm PM8921 PMIC Power Key
>> +
>> +maintainers:
>> + - Andy Gross <agross@kernel.org>
>> + - Bjorn Andersson <andersson@kernel.org>
>
> Keep only Bjorn. Andy did not review much for some time.
Ack
>
>> +
>> +allOf:
>> + - $ref: input.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - enum:
>> + - qcom,pm8921-pwrkey
>> + - qcom,pm8058-pwrkey
>> + - items:
>> + - enum:
>> + - qcom,pm8018-pwrkey
>> + - const: qcom,pm8921-pwrkey
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 2
>> + description: |
>> + The first interrupt specifies the key release interrupt
>> + and the second interrupt specifies the key press interrupt.
>
> In such case better to drop maxItems and description and write it:
>
> items:
> - description: key release interrupt
> - description: key press interrupt
>
> (maybe even the "interrupt" word could be skipped...)
Ack, will do that without the interrupt word
>
>> +
>> + debounce:
>> + description: |
>> + Time in microseconds that key must be pressed or
>> + released for state change interrupt to trigger.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + pull-up:
>> + description: |
>> + Presence of this property indicates that the KPDPWR_N
>> + pin should be configured for pull up.
>> + $ref: /schemas/types.yaml#/definitions/flag
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + ssbi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> Messed indentation.
>> +
>> + pmic@0 {
>> + reg = <0x0>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + pwrkey@1c {
>> + compatible = "qcom,pm8921-pwrkey";
>
> Messed up indentation. For entire DTS example keep 2 or 4 spaces.
>
>> + reg = <0x1c>;
>> + interrupt-parent = <&pmicint>;
>> + interrupts = <50 1>, <51 1>;
>
> Use defines for interrupt flags.
>
>> + debounce = <15625>;
>> + pull-up;
>> + };
>> + };
>> + };
Will fix the example,
>
> Best regards,
> Krzysztof
>
Thanks,
Neil
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible
2022-10-04 9:02 ` Krzysztof Kozlowski
@ 2022-10-04 9:42 ` Neil Armstrong
0 siblings, 0 replies; 25+ messages in thread
From: Neil Armstrong @ 2022-10-04 9:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 11:02, Krzysztof Kozlowski wrote:
> On 04/10/2022 10:08, Neil Armstrong wrote:
>> The PM8921 compatible is used as fallback when PM8018 is available,
>> then remove PM8018 compatible.
>
> s/then/so/
>
> But it's a bit confusing because PM8018 is not "available". It is
> "present" or "is" instead, so rather:
> "The PM8018 compatible is always used with PM8921 fallback, so PM8018
> compatible can be safely removed from device ID table".
Thx for the suggestion, will use this wording, same in patch 9.
>
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Thanks,
Neil
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018
2022-10-04 9:38 ` Neil Armstrong
@ 2022-10-04 10:03 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-04 10:03 UTC (permalink / raw)
To: neil.armstrong, Krzysztof Kozlowski, Bjorn Andersson,
Satya Priya, Andy Gross, Alexandre Belloni, Rob Herring,
Konrad Dybcio, Lee Jones, Dmitry Torokhov, Alessandro Zummo
Cc: linux-kernel, devicetree, linux-input, linux-arm-msm, linux-rtc
On 04/10/2022 11:38, Neil Armstrong wrote:
>>> + compatible = "qcom,pm8018", "qcom,pm8921";
>>> + reg = <1>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + interrupt-controller;
>>> + #interrupt-cells = <2>;
>>> +
>>> + interrupt-parent = <&tlmm>;
>>> + interrupts = <33 IRQ_TYPE_EDGE_RISING>;
>>> + };
>>
>> These two pmics are exactly the same (except compatible), so just keep
>> one example... unless both are coming from the same, real DTS?
>
> It was mainly to exercise the fallback, but it's useless as-is so I'll remove in v3.
No need to test different compatibles.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2022-10-04 10:03 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 8:08 [PATCH v2 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
2022-10-04 8:51 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
2022-10-04 8:52 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
2022-10-04 8:53 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
2022-10-04 8:55 ` Krzysztof Kozlowski
2022-10-04 9:38 ` Neil Armstrong
2022-10-04 10:03 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
2022-10-04 8:59 ` Krzysztof Kozlowski
2022-10-04 9:41 ` Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
2022-10-04 9:00 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
2022-10-04 9:02 ` Krzysztof Kozlowski
2022-10-04 9:42 ` Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
2022-10-04 9:02 ` Krzysztof Kozlowski
2022-10-04 8:08 ` [PATCH v2 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-10-04 8:08 ` [PATCH v2 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
2022-10-04 9:03 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).