* [PATCH 5/5] input: make xenbus device id constant
@ 2010-01-09 12:56 Németh Márton
0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-09 12:56 UTC (permalink / raw)
To: Dmitry Torokhov, Jeremy Fitzhardinge, Chris Wright, Markus Armbruster
Cc: xen-devel, linux-input, LKML
From: Márton Németh <nm127@freemail.hu>
The ids field of the struct xenbus_device_id is constant in <linux/xen/xenbus.h>
so it is worth to make xenkbd_ids also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/input/xen-kbdfront.c b/drivers/input/xen-kbdfront.c
--- a/drivers/input/xen-kbdfront.c 2010-01-07 19:08:40.000000000 +0100
+++ b/drivers/input/xen-kbdfront.c 2010-01-08 19:23:27.000000000 +0100
@@ -321,7 +321,7 @@ InitWait:
}
}
-static struct xenbus_device_id xenkbd_ids[] = {
+static const struct xenbus_device_id xenkbd_ids[] = {
{ "vkbd" },
{ "" }
};
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-09 12:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-09 12:56 [PATCH 5/5] input: make xenbus device id constant Németh Márton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).