From: "Filipe Laíns" <lains@archlinux.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Nestor Lopez Casado <nlopezcasad@logitech.com>
Subject: Re: [PATCH] HID: logitech-dj: add support for the static device in the Powerplay mat/receiver
Date: Wed, 12 Feb 2020 13:56:58 +0000 [thread overview]
Message-ID: <5a93677bd6238a9d7928e4fd16a8915faeb5f19e.camel@archlinux.org> (raw)
In-Reply-To: <nycvar.YFH.7.76.2002121449191.3144@cbobk.fhfr.pm>
[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]
On Wed, 2020-02-12 at 14:50 +0100, Jiri Kosina wrote:
> On Wed, 15 Jan 2020, Filipe Laíns wrote:
>
> > The Logitech G Powerplay has a lightspeed receiver with a static HID++
> > device with ID 7 attached to it to. It is used to configure the led on
> > the mat. For this reason I increased the max number of devices.
> >
> > Signed-off-by: Filipe Laíns <lains@archlinux.org>
> > ---
> > drivers/hid/hid-logitech-dj.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> > index bb50d6e7745b..79294b873057 100644
> > --- a/drivers/hid/hid-logitech-dj.c
> > +++ b/drivers/hid/hid-logitech-dj.c
> > @@ -16,11 +16,11 @@
> > #include <asm/unaligned.h>
> > #include "hid-ids.h"
> >
> > -#define DJ_MAX_PAIRED_DEVICES 6
> > +#define DJ_MAX_PAIRED_DEVICES 7
> > #define DJ_MAX_NUMBER_NOTIFS 8
> > #define DJ_RECEIVER_INDEX 0
> > #define DJ_DEVICE_INDEX_MIN 1
> > -#define DJ_DEVICE_INDEX_MAX 6
> > +#define DJ_DEVICE_INDEX_MAX 7
> >
> > #define DJREPORT_SHORT_LENGTH 15
> > #define DJREPORT_LONG_LENGTH 32
> > @@ -980,6 +980,11 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
> > break;
> > }
> >
> > + /* custom receiver device (eg. powerplay) */
> > + if (hidpp_report->device_index == 7) {
> > + workitem.reports_supported |= HIDPP;
> > + }
> > +
>
> I guess we can't do anything else than to trust Logitech that they will
> not assign conflicting device_index ID in the future to something that
> will not be HID++, right?
>
> Or is this properly documented somewhere?
>
> Thanks,
CCing Nestor
Yes, we need to trust Logitech on this. There's isn't anything
documented regarding this AFAIK.
Even if Logitech released a device with index 7 that didn't support
HID++, it wouldn't be that big of an issue. We would just end up with a
hidraw node which would export a vendor page report descriptor but the
device wouldn't actually reply to anything.
Regards,
Filipe Laíns
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-02-12 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:18 [PATCH] HID: logitech-dj: add support for the static device in the Powerplay mat/receiver Filipe Laíns
2020-02-08 19:07 ` Filipe Laíns
2020-02-12 13:50 ` Jiri Kosina
2020-02-12 13:56 ` Filipe Laíns [this message]
2020-03-10 13:22 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a93677bd6238a9d7928e4fd16a8915faeb5f19e.camel@archlinux.org \
--to=lains@archlinux.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).