From: Jiri Kosina <jikos@kernel.org>
To: "Filipe Laíns" <lains@archlinux.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Nestor Lopez Casado <nlopezcasad@logitech.com>
Subject: Re: [PATCH] HID: logitech-dj: add support for the static device in the Powerplay mat/receiver
Date: Tue, 10 Mar 2020 14:22:16 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2003101301280.19500@cbobk.fhfr.pm> (raw)
In-Reply-To: <5a93677bd6238a9d7928e4fd16a8915faeb5f19e.camel@archlinux.org>
On Wed, 12 Feb 2020, Filipe Laíns wrote:
> > > + /* custom receiver device (eg. powerplay) */
> > > + if (hidpp_report->device_index == 7) {
> > > + workitem.reports_supported |= HIDPP;
> > > + }
> > > +
> >
> > I guess we can't do anything else than to trust Logitech that they will
> > not assign conflicting device_index ID in the future to something that
> > will not be HID++, right?
> >
> > Or is this properly documented somewhere?
> >
> > Thanks,
>
>
> CCing Nestor
>
> Yes, we need to trust Logitech on this. There's isn't anything
> documented regarding this AFAIK.
>
> Even if Logitech released a device with index 7 that didn't support
> HID++, it wouldn't be that big of an issue. We would just end up with a
> hidraw node which would export a vendor page report descriptor but the
> device wouldn't actually reply to anything.
Given the silence from Nestor, I guess we can just apply this for 5.7;
pushing to for-5.7/logitech branch.
Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2020-03-10 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:18 [PATCH] HID: logitech-dj: add support for the static device in the Powerplay mat/receiver Filipe Laíns
2020-02-08 19:07 ` Filipe Laíns
2020-02-12 13:50 ` Jiri Kosina
2020-02-12 13:56 ` Filipe Laíns
2020-03-10 13:22 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2003101301280.19500@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).