From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH resend 2/2] Input: silead - Add pen support
Date: Sun, 12 Dec 2021 13:36:04 +0100 [thread overview]
Message-ID: <5e2253c6-0d1f-51ec-9817-0c83fff2724e@redhat.com> (raw)
In-Reply-To: <YbQWDAPw/zpO0y9x@google.com>
Hi Dmitry,
On 12/11/21 04:07, Dmitry Torokhov wrote:
> Hi Hans,
>
> On Mon, Nov 22, 2021 at 11:06:37PM +0100, Hans de Goede wrote:
>> + input_set_capability(data->pen_input, EV_KEY, BTN_TOUCH);
>> + input_set_capability(data->pen_input, EV_KEY, BTN_TOOL_PEN);
>> + /*
>> + * We never report BTN_STYLUS but userspace want to see this in order
>> + * for the device to be recognized as a pen / drawing-tablet.
>> + */
>
> What userspace is that? I see that udev recognizes devices with either
> stylus or pen as tablets since at least 2015.
>
> I am really hesitant adding synthetic capabilities that do not have real
> events behind them.
You are completely right, I added this when GNOME3 / libinput would not
recognize the pen (looking at other stylus/pen drivers) but IIRC things
then still did not work and then I also added code to set the resolution.
I just tested without setting BTN_STYLUS and things still work fine,
so the comment and the line setting BTN_STYLUS can be dropped while
merging this. Let me know if you want me to do a new version with this
dropped instead.
Regards,
Hans
next prev parent reply other threads:[~2021-12-12 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 22:06 [PATCH resend 0/2] Input: silead - Pen support Hans de Goede
2021-11-22 22:06 ` [PATCH resend 1/2] Input: silead - Add support for EFI-embedded fw using different min/max coordinates Hans de Goede
2021-12-13 5:11 ` Dmitry Torokhov
2021-11-22 22:06 ` [PATCH resend 2/2] Input: silead - Add pen support Hans de Goede
2021-12-11 3:07 ` Dmitry Torokhov
2021-12-12 12:36 ` Hans de Goede [this message]
2021-12-13 5:11 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e2253c6-0d1f-51ec-9817-0c83fff2724e@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).