From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH resend 2/2] Input: silead - Add pen support
Date: Fri, 10 Dec 2021 19:07:56 -0800 [thread overview]
Message-ID: <YbQWDAPw/zpO0y9x@google.com> (raw)
In-Reply-To: <20211122220637.11386-3-hdegoede@redhat.com>
Hi Hans,
On Mon, Nov 22, 2021 at 11:06:37PM +0100, Hans de Goede wrote:
> + input_set_capability(data->pen_input, EV_KEY, BTN_TOUCH);
> + input_set_capability(data->pen_input, EV_KEY, BTN_TOOL_PEN);
> + /*
> + * We never report BTN_STYLUS but userspace want to see this in order
> + * for the device to be recognized as a pen / drawing-tablet.
> + */
What userspace is that? I see that udev recognizes devices with either
stylus or pen as tablets since at least 2015.
I am really hesitant adding synthetic capabilities that do not have real
events behind them.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-12-11 3:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 22:06 [PATCH resend 0/2] Input: silead - Pen support Hans de Goede
2021-11-22 22:06 ` [PATCH resend 1/2] Input: silead - Add support for EFI-embedded fw using different min/max coordinates Hans de Goede
2021-12-13 5:11 ` Dmitry Torokhov
2021-11-22 22:06 ` [PATCH resend 2/2] Input: silead - Add pen support Hans de Goede
2021-12-11 3:07 ` Dmitry Torokhov [this message]
2021-12-12 12:36 ` Hans de Goede
2021-12-13 5:11 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbQWDAPw/zpO0y9x@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).