* [PATCH] Input: synaptics-rmi4: Fix SPI device ID
@ 2022-12-19 13:37 Rayyan Ansari
2023-01-24 10:07 ` Mattijs Korpershoek
2023-02-04 0:55 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Rayyan Ansari @ 2022-12-19 13:37 UTC (permalink / raw)
To: linux-input
Cc: ~postmarketos/upstreaming, Rayyan Ansari, Dmitry Torokhov, linux-kernel
Currently, the ID being set to "rmi4_spi" causes this warning:
"SPI driver rmi4_spi has no spi_device_id for syna,rmi4-spi"
Change the ID to rmi4-spi to stop this warning.
Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
drivers/input/rmi4/rmi_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4/rmi_spi.c
index c82edda66b23..aa3a6a8544d4 100644
--- a/drivers/input/rmi4/rmi_spi.c
+++ b/drivers/input/rmi4/rmi_spi.c
@@ -510,7 +510,7 @@ static const struct dev_pm_ops rmi_spi_pm = {
};
static const struct spi_device_id rmi_id[] = {
- { "rmi4_spi", 0 },
+ { "rmi4-spi", 0 },
{ }
};
MODULE_DEVICE_TABLE(spi, rmi_id);
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics-rmi4: Fix SPI device ID
2022-12-19 13:37 [PATCH] Input: synaptics-rmi4: Fix SPI device ID Rayyan Ansari
@ 2023-01-24 10:07 ` Mattijs Korpershoek
2023-02-04 0:55 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2023-01-24 10:07 UTC (permalink / raw)
To: Rayyan Ansari, linux-input
Cc: ~postmarketos/upstreaming, Rayyan Ansari, Dmitry Torokhov, linux-kernel
On Mon, Dec 19, 2022 at 13:37, Rayyan Ansari <rayyan@ansari.sh> wrote:
> Currently, the ID being set to "rmi4_spi" causes this warning:
> "SPI driver rmi4_spi has no spi_device_id for syna,rmi4-spi"
>
> Change the ID to rmi4-spi to stop this warning.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/input/rmi4/rmi_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4/rmi_spi.c
> index c82edda66b23..aa3a6a8544d4 100644
> --- a/drivers/input/rmi4/rmi_spi.c
> +++ b/drivers/input/rmi4/rmi_spi.c
> @@ -510,7 +510,7 @@ static const struct dev_pm_ops rmi_spi_pm = {
> };
>
> static const struct spi_device_id rmi_id[] = {
> - { "rmi4_spi", 0 },
> + { "rmi4-spi", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(spi, rmi_id);
> --
> 2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics-rmi4: Fix SPI device ID
2022-12-19 13:37 [PATCH] Input: synaptics-rmi4: Fix SPI device ID Rayyan Ansari
2023-01-24 10:07 ` Mattijs Korpershoek
@ 2023-02-04 0:55 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2023-02-04 0:55 UTC (permalink / raw)
To: Rayyan Ansari; +Cc: linux-input, ~postmarketos/upstreaming, linux-kernel
On Mon, Dec 19, 2022 at 01:37:15PM +0000, Rayyan Ansari wrote:
> Currently, the ID being set to "rmi4_spi" causes this warning:
> "SPI driver rmi4_spi has no spi_device_id for syna,rmi4-spi"
>
> Change the ID to rmi4-spi to stop this warning.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-04 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-19 13:37 [PATCH] Input: synaptics-rmi4: Fix SPI device ID Rayyan Ansari
2023-01-24 10:07 ` Mattijs Korpershoek
2023-02-04 0:55 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).