linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@dowhile0.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ferruh Yigit <fery@cypress.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Henrik Rydberg <rydberg@bitmath.org>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 2/7] Input: cyttsp - Obtain regulators
Date: Tue, 30 Mar 2021 12:54:08 +0200	[thread overview]
Message-ID: <CABxcv=nWUsKyDBKqsW_mTnJctWpgyTrk96V0p5PjVn=r6F1tpQ@mail.gmail.com> (raw)
In-Reply-To: <20210330085424.2244653-3-linus.walleij@linaro.org>

On Tue, Mar 30, 2021 at 10:54 AM Linus Walleij <linus.walleij@linaro.org> wrote:

[snip]

>
> +       struct regulator_bulk_data regulators[2];
>         struct gpio_desc *reset_gpio;
>         bool use_hndshk;
>         u8 act_dist;

Wonder if it is worth adding a constant macro for the 2.

Patch looks good to me:

Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>

Best regards,
Javier

  reply	other threads:[~2021-03-30 10:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  8:54 [PATCH 0/7] Input: cyttsp - First round of modernizations Linus Walleij
2021-03-30  8:54 ` [PATCH 1/7] Input: cyttsp - Probe from compatibles Linus Walleij
2021-03-30 10:51   ` Javier Martinez Canillas
2021-03-30  8:54 ` [PATCH 2/7] Input: cyttsp - Obtain regulators Linus Walleij
2021-03-30 10:54   ` Javier Martinez Canillas [this message]
2021-03-30  8:54 ` [PATCH 3/7] Input: cyttsp - Error message on boot mode exit error Linus Walleij
2021-03-30 10:56   ` Javier Martinez Canillas
2021-03-30  8:54 ` [PATCH 4/7] Input: cyttsp - Reduce reset pulse timings Linus Walleij
2021-03-30 10:57   ` Javier Martinez Canillas
2021-03-30  8:54 ` [PATCH 5/7] Input: cyttsp - Drop the phys path Linus Walleij
2021-03-30 11:00   ` Javier Martinez Canillas
2021-03-30  8:54 ` [PATCH 6/7] Input: cyttsp - Set abs params for ABS_MT_TOUCH_MAJOR Linus Walleij
2021-03-30 11:00   ` Javier Martinez Canillas
2021-03-30  8:54 ` [PATCH 7/7] Input: cyttsp - Flag the device properly Linus Walleij
2021-03-30 11:01   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABxcv=nWUsKyDBKqsW_mTnJctWpgyTrk96V0p5PjVn=r6F1tpQ@mail.gmail.com' \
    --to=javier@dowhile0.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fery@cypress.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).