* [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key
@ 2020-03-13 18:03 Rajat Jain
2020-03-13 18:05 ` Harry Cutts
2020-03-18 3:56 ` Dmitry Torokhov
0 siblings, 2 replies; 5+ messages in thread
From: Rajat Jain @ 2020-03-13 18:03 UTC (permalink / raw)
To: Dmitry Torokhov, Harry Cutts, linux-input, linux-kernel, dtor
Cc: Rajat Jain, rajatxjain
New chromeos keyboards have a "snip" key that is basically a selective
screenshot (allows a user to select an area of screen to be copied).
Allocate a keycode for it.
Signed-off-by: Rajat Jain <rajatja@google.com>
---
v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
include/uapi/linux/input-event-codes.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 0f1db1cccc3fd..c4dbe2ee9c098 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -652,6 +652,8 @@
/* Electronic privacy screen control */
#define KEY_PRIVACY_SCREEN_TOGGLE 0x279
+#define KEY_SELECTIVE_SCREENSHOT 0x280
+
/*
* Some keyboards have keys which do not have a defined meaning, these keys
* are intended to be programmed / bound to macros by the user. For most
--
2.25.1.481.gfbce0eb801-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key
2020-03-13 18:03 [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key Rajat Jain
@ 2020-03-13 18:05 ` Harry Cutts
2020-03-18 3:56 ` Dmitry Torokhov
1 sibling, 0 replies; 5+ messages in thread
From: Harry Cutts @ 2020-03-13 18:05 UTC (permalink / raw)
To: Rajat Jain
Cc: Dmitry Torokhov, linux-input, lkml, Dmitry Torokhov, rajatxjain
On Fri, 13 Mar 2020 at 11:03, Rajat Jain <rajatja@google.com> wrote:
>
> New chromeos keyboards have a "snip" key that is basically a selective
> screenshot (allows a user to select an area of screen to be copied).
> Allocate a keycode for it.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
Reviewed-by: Harry Cutts <hcutts@chromium.org>
Harry Cutts
Chrome OS Touch/Input team
> ---
> v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
>
> include/uapi/linux/input-event-codes.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -652,6 +652,8 @@
> /* Electronic privacy screen control */
> #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
>
> +#define KEY_SELECTIVE_SCREENSHOT 0x280
> +
> /*
> * Some keyboards have keys which do not have a defined meaning, these keys
> * are intended to be programmed / bound to macros by the user. For most
> --
> 2.25.1.481.gfbce0eb801-goog
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key
2020-03-13 18:03 [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key Rajat Jain
2020-03-13 18:05 ` Harry Cutts
@ 2020-03-18 3:56 ` Dmitry Torokhov
2020-03-18 4:12 ` Rajat Jain
1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2020-03-18 3:56 UTC (permalink / raw)
To: Rajat Jain; +Cc: Harry Cutts, linux-input, linux-kernel, dtor, rajatxjain
On Fri, Mar 13, 2020 at 11:03:33AM -0700, Rajat Jain wrote:
> New chromeos keyboards have a "snip" key that is basically a selective
> screenshot (allows a user to select an area of screen to be copied).
> Allocate a keycode for it.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
Applied, thank you.
> ---
> v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
>
> include/uapi/linux/input-event-codes.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -652,6 +652,8 @@
> /* Electronic privacy screen control */
> #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
>
> +#define KEY_SELECTIVE_SCREENSHOT 0x280
> +
> /*
> * Some keyboards have keys which do not have a defined meaning, these keys
> * are intended to be programmed / bound to macros by the user. For most
> --
> 2.25.1.481.gfbce0eb801-goog
>
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key
2020-03-18 3:56 ` Dmitry Torokhov
@ 2020-03-18 4:12 ` Rajat Jain
2020-03-18 4:13 ` Rajat Jain
0 siblings, 1 reply; 5+ messages in thread
From: Rajat Jain @ 2020-03-18 4:12 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Harry Cutts, linux-input, Linux Kernel Mailing List,
Dmitry Torokhov, Rajat Jain
On Tue, Mar 17, 2020 at 8:56 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Fri, Mar 13, 2020 at 11:03:33AM -0700, Rajat Jain wrote:
> > New chromeos keyboards have a "snip" key that is basically a selective
> > screenshot (allows a user to select an area of screen to be copied).
> > Allocate a keycode for it.
> >
> > Signed-off-by: Rajat Jain <rajatja@google.com>
>
> Applied, thank you.
I just noticed that I had by mistake used KEY_SELECTIVE_SNAPSHOT
instead of intended KEY_SELECTIVE_SCREENSHOT in the commit message. My
apologies. Can you please fix the commit message if not already
pushed. Otherwise I can send a follow up patch if you'd like.
Thanks & Best Regards,
Rajat
>
> > ---
> > v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> > V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
> >
> > include/uapi/linux/input-event-codes.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -652,6 +652,8 @@
> > /* Electronic privacy screen control */
> > #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
> >
> > +#define KEY_SELECTIVE_SCREENSHOT 0x280
> > +
> > /*
> > * Some keyboards have keys which do not have a defined meaning, these keys
> > * are intended to be programmed / bound to macros by the user. For most
> > --
> > 2.25.1.481.gfbce0eb801-goog
> >
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key
2020-03-18 4:12 ` Rajat Jain
@ 2020-03-18 4:13 ` Rajat Jain
0 siblings, 0 replies; 5+ messages in thread
From: Rajat Jain @ 2020-03-18 4:13 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Harry Cutts, linux-input, Linux Kernel Mailing List,
Dmitry Torokhov, Rajat Jain
On Tue, Mar 17, 2020 at 9:12 PM Rajat Jain <rajatja@google.com> wrote:
>
> On Tue, Mar 17, 2020 at 8:56 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Fri, Mar 13, 2020 at 11:03:33AM -0700, Rajat Jain wrote:
> > > New chromeos keyboards have a "snip" key that is basically a selective
> > > screenshot (allows a user to select an area of screen to be copied).
> > > Allocate a keycode for it.
> > >
> > > Signed-off-by: Rajat Jain <rajatja@google.com>
> >
> > Applied, thank you.
>
> I just noticed that I had by mistake used KEY_SELECTIVE_SNAPSHOT
> instead of intended KEY_SELECTIVE_SCREENSHOT in the commit message. My
> apologies. Can you please fix the commit message if not already
> pushed. Otherwise I can send a follow up patch if you'd like.
Arghhh..... please disregard. I was looking at the wrong place. The
patch was correct. No need to do anything.
Thanks! :-)
Best Regards,
Rajat
>
> Thanks & Best Regards,
>
> Rajat
>
> >
> > > ---
> > > v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> > > V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
> > >
> > > include/uapi/linux/input-event-codes.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > > index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> > > --- a/include/uapi/linux/input-event-codes.h
> > > +++ b/include/uapi/linux/input-event-codes.h
> > > @@ -652,6 +652,8 @@
> > > /* Electronic privacy screen control */
> > > #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
> > >
> > > +#define KEY_SELECTIVE_SCREENSHOT 0x280
> > > +
> > > /*
> > > * Some keyboards have keys which do not have a defined meaning, these keys
> > > * are intended to be programmed / bound to macros by the user. For most
> > > --
> > > 2.25.1.481.gfbce0eb801-goog
> > >
> >
> > --
> > Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-18 4:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 18:03 [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key Rajat Jain
2020-03-13 18:05 ` Harry Cutts
2020-03-18 3:56 ` Dmitry Torokhov
2020-03-18 4:12 ` Rajat Jain
2020-03-18 4:13 ` Rajat Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).