* [PATCH] Input: zinitix - Add BT404 compatible string
@ 2022-02-13 22:52 Linus Walleij
2022-02-14 22:56 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2022-02-13 22:52 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: Linus Walleij, Nikita Travkin
This driver works just fine with the BT404 version of the touchscreen
as well. Tested on the Samsung GT-I8160 (Codina) mobile phone.
Cc: Nikita Travkin <nikita@trvn.ru>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/input/touchscreen/zinitix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/zinitix.c b/drivers/input/touchscreen/zinitix.c
index b7a9c3cbe0b2..dff24899855b 100644
--- a/drivers/input/touchscreen/zinitix.c
+++ b/drivers/input/touchscreen/zinitix.c
@@ -626,6 +626,7 @@ static SIMPLE_DEV_PM_OPS(zinitix_pm_ops, zinitix_suspend, zinitix_resume);
#ifdef CONFIG_OF
static const struct of_device_id zinitix_of_match[] = {
+ { .compatible = "zinitix,bt404" },
{ .compatible = "zinitix,bt532" },
{ .compatible = "zinitix,bt541" },
{ }
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: zinitix - Add BT404 compatible string
2022-02-13 22:52 [PATCH] Input: zinitix - Add BT404 compatible string Linus Walleij
@ 2022-02-14 22:56 ` Dmitry Torokhov
2022-02-14 23:09 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2022-02-14 22:56 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-input, Nikita Travkin
Hi Linus, Nikita,
On Sun, Feb 13, 2022 at 11:52:35PM +0100, Linus Walleij wrote:
> This driver works just fine with the BT404 version of the touchscreen
> as well. Tested on the Samsung GT-I8160 (Codina) mobile phone.
What about all other compatibles that we added to the binding document?
Do we need to prune them or add them to the driver?
>
> Cc: Nikita Travkin <nikita@trvn.ru>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/input/touchscreen/zinitix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/zinitix.c b/drivers/input/touchscreen/zinitix.c
> index b7a9c3cbe0b2..dff24899855b 100644
> --- a/drivers/input/touchscreen/zinitix.c
> +++ b/drivers/input/touchscreen/zinitix.c
> @@ -626,6 +626,7 @@ static SIMPLE_DEV_PM_OPS(zinitix_pm_ops, zinitix_suspend, zinitix_resume);
>
> #ifdef CONFIG_OF
> static const struct of_device_id zinitix_of_match[] = {
> + { .compatible = "zinitix,bt404" },
> { .compatible = "zinitix,bt532" },
> { .compatible = "zinitix,bt541" },
> { }
> --
> 2.34.1
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: zinitix - Add BT404 compatible string
2022-02-14 22:56 ` Dmitry Torokhov
@ 2022-02-14 23:09 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-02-14 23:09 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Nikita Travkin
On Mon, Feb 14, 2022 at 11:56 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Sun, Feb 13, 2022 at 11:52:35PM +0100, Linus Walleij wrote:
> > This driver works just fine with the BT404 version of the touchscreen
> > as well. Tested on the Samsung GT-I8160 (Codina) mobile phone.
>
> What about all other compatibles that we added to the binding document?
> Do we need to prune them or add them to the driver?
The binding document is for any operating system and any touchscreen
so we should not amend it for any Linux-related reasons such as
not having implemented the driver for them.
That said we can certainly add all of them, the only reason I added
just this one is because I can test it and make sure it works with
the driver.
It's a bit of taste, maybe it is better to add them all so people can
easier test if they also work with the driver (which I think they
will mostly do).
I'll revise the patch and add all of them.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-14 23:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 22:52 [PATCH] Input: zinitix - Add BT404 compatible string Linus Walleij
2022-02-14 22:56 ` Dmitry Torokhov
2022-02-14 23:09 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).