[BUG] sysfs: cannot create duplicate filename, with Lenovo keyboard

[BUG] sysfs: cannot create duplicate filename, with Lenovo keyboard

[Frédéric Lamorce]

kernel warning about a duplicate filename in sysfs after a resume.

CPU: AMD 5600H
distro : MX-21.3_ahs_x64 Wildflower September 18  2022 base: Debian
GNU/Linux 11 (bullseye)
kernel tested: 6.1.0-6mx-amd64 ; 6.1.0-7mx-amd64 ;
6.2.10-1-liquorix-amd64 ; 6.2.11-3-liquorix-amd64

I am using a Lenovo TrackPoint Keyboard II, it's a keyboard with an
integrated trackpad. It is paired in bluetooth mode. It is using the
hid-lenovo module.
Bluetooth is using mediatek mt7921e and btusb

After a suspend/resume, sometimes, there is a kernel warning in dmesg.
Maybe because the keyboard and mouse are using the same MAC address
and it tries to re-create the battery info?


[22706.169919] sysfs: cannot create duplicate filename
'/class/power_supply/hid-d8:ab:24:63:e7:77-battery'
[22706.169928] CPU: 2 PID: 41456 Comm: kworker/2:1 Tainted: P
 O       6.2.11-3-liquorix-amd64 #1  liquorix 6.2-16~mx21+1
[22706.169934] Hardware name: AZW SER/SER, BIOS V1.15_P4C7M43_Blink 09/17/2022
[22706.169937] Workqueue: events uhid_device_add_worker [uhid]
[22706.169955] Call Trace:
[22706.169960]  <TASK>
[22706.169962]  dump_stack_lvl+0x44/0x60
[22706.169973]  sysfs_warn_dup+0x57/0x70
[22706.169979]  sysfs_create_link+0xc2/0xd0
[22706.169983]  device_add+0x208/0xb70
[22706.169991]  __power_supply_register+0x27b/0x420
[22706.169999]  hidinput_setup_battery.isra.0+0x19e/0x240
[22706.170007]  hidinput_connect+0x1326/0x4e60
[22706.170016]  hid_connect+0x581/0x5d0
[22706.170021]  hid_hw_start+0x41/0x70
[22706.170025]  lenovo_probe+0x30/0x670 [hid_lenovo]
[22706.170038]  hid_device_probe+0xf4/0x190
[22706.170044]  really_probe+0x1d6/0x3c0
[22706.170050]  __driver_probe_device+0x72/0xe0
[22706.170054]  driver_probe_device+0x1e/0x170
[22706.170058]  __device_attach_driver+0xac/0x160
[22706.170063]  ? __pfx___device_attach_driver+0x10/0x10
[22706.170068]  bus_for_each_drv+0x7e/0xd0
[22706.170073]  device_initial_probe+0xfd/0x1e0
[22706.170079]  bus_probe_device+0xa8/0xc0
[22706.170083]  device_add+0x3ec/0xb70
[22706.170088]  hid_add_device+0xf8/0x3b0
[22706.170092]  ? od_dbs_update+0xb9/0x190
[22706.170099]  uhid_device_add_worker+0x15/0x60 [uhid]
[22706.170108]  process_one_work+0x1dc/0x3e0
[22706.170115]  worker_thread+0x4d/0x460
[22706.170121]  ? __pfx_worker_thread+0x10/0x10
[22706.170126]  kthread+0xd8/0x100
[22706.170131]  ? __pfx_kthread+0x10/0x10
[22706.170134]  ret_from_fork+0x2c/0x50
[22706.170142]  </TASK>
[22706.170168] lenovo 0005:17EF:60E1.001D: can't register power supply: -17
[22706.170305] input: TrackPoint Keyboard II as
/devices/virtual/misc/uhid/0005:17EF:60E1.001D/input/input42
[22706.171437] lenovo 0005:17EF:60E1.001D: input,hidraw4: BLUETOOTH
HID v0.47 Keyboard [TrackPoint Keyboard II] on 4c:d5:77:f0:c3:6c
[22734.816970] Bluetooth: hci0: ACL packet for unknown connection handle 512
[22735.849582] input: SANWA Gravi Mouse as
/devices/virtual/misc/uhid/0005:1915:0040.001E/input/input43
[22735.850012] input: SANWA Gravi Consumer Control as
/devices/virtual/misc/uhid/0005:1915:0040.001E/input/input44
[22735.851199] hid-generic 0005:1915:0040.001E: input,hidraw2:
BLUETOOTH HID v0.01 Mouse [SANWA Gravi] on 4c:d5:77:f0:c3:6c
[22760.786365] sysfs: cannot create duplicate filename
'/class/power_supply/hid-d8:ab:24:63:e7:77-battery'
[22760.786372] CPU: 6 PID: 37516 Comm: kworker/6:2 Tainted: P
 O       6.2.11-3-liquorix-amd64 #1  liquorix 6.2-16~mx21+1
[22760.786378] Hardware name: AZW SER/SER, BIOS V1.15_P4C7M43_Blink 09/17/2022
[22760.786380] Workqueue: events uhid_device_add_worker [uhid]
[22760.786396] Call Trace:
[22760.786400]  <TASK>
[22760.786402]  dump_stack_lvl+0x44/0x60
[22760.786411]  sysfs_warn_dup+0x57/0x70
[22760.786416]  sysfs_create_link+0xc2/0xd0
[22760.786419]  device_add+0x208/0xb70
[22760.786427]  __power_supply_register+0x27b/0x420
[22760.786434]  hidinput_setup_battery.isra.0+0x19e/0x240
[22760.786441]  hidinput_connect+0x1326/0x4e60
[22760.786449]  hid_connect+0x581/0x5d0
[22760.786454]  hid_hw_start+0x41/0x70
[22760.786459]  lenovo_probe+0x30/0x670 [hid_lenovo]
[22760.786469]  hid_device_probe+0xf4/0x190
[22760.786474]  really_probe+0x1d6/0x3c0
[22760.786478]  __driver_probe_device+0x72/0xe0
[22760.786483]  driver_probe_device+0x1e/0x170
[22760.786487]  __device_attach_driver+0xac/0x160
[22760.786491]  ? __pfx___device_attach_driver+0x10/0x10
[22760.786495]  bus_for_each_drv+0x7e/0xd0
[22760.786499]  device_initial_probe+0xfd/0x1e0
[22760.786504]  bus_probe_device+0xa8/0xc0
[22760.786507]  device_add+0x3ec/0xb70
[22760.786513]  hid_add_device+0xf8/0x3b0
[22760.786517]  uhid_device_add_worker+0x15/0x60 [uhid]
[22760.786526]  process_one_work+0x1dc/0x3e0
[22760.786534]  worker_thread+0x4d/0x460
[22760.786540]  ? __pfx_worker_thread+0x10/0x10
[22760.786545]  kthread+0xd8/0x100
[22760.786549]  ? __pfx_kthread+0x10/0x10
[22760.786553]  ret_from_fork+0x2c/0x50
[22760.786561]  </TASK>
[22760.786575] lenovo 0005:17EF:60E1.001F: can't register power supply: -17
[22760.786781] input: TrackPoint Keyboard II as
/devices/virtual/misc/uhid/0005:17EF:60E1.001F/input/input45
[22760.787191] lenovo 0005:17EF:60E1.001F: input,hidraw4: BLUETOOTH
HID v0.47 Keyboard [TrackPoint Keyboard II] on 4c:d5:77:f0:c3:6c