* [PATCH] Input: ims-pcu - drop redundant driver-data assignment
@ 2021-03-18 15:55 Johan Hovold
2021-03-20 3:36 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2021-03-18 15:55 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Johan Hovold
The driver data for the data interface has already been set by
usb_driver_claim_interface() so drop the subsequent redundant
assignment.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/input/misc/ims-pcu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
index 08b9b5cdb943..81de8c4e37d0 100644
--- a/drivers/input/misc/ims-pcu.c
+++ b/drivers/input/misc/ims-pcu.c
@@ -2018,7 +2018,6 @@ static int ims_pcu_probe(struct usb_interface *intf,
}
usb_set_intfdata(pcu->ctrl_intf, pcu);
- usb_set_intfdata(pcu->data_intf, pcu);
error = ims_pcu_buffers_alloc(pcu);
if (error)
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: ims-pcu - drop redundant driver-data assignment
2021-03-18 15:55 [PATCH] Input: ims-pcu - drop redundant driver-data assignment Johan Hovold
@ 2021-03-20 3:36 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2021-03-20 3:36 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-input, linux-kernel
On Thu, Mar 18, 2021 at 04:55:25PM +0100, Johan Hovold wrote:
> The driver data for the data interface has already been set by
> usb_driver_claim_interface() so drop the subsequent redundant
> assignment.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-20 3:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 15:55 [PATCH] Input: ims-pcu - drop redundant driver-data assignment Johan Hovold
2021-03-20 3:36 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).