linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] Input: cros_ec_keyb - Fix kobj_to_dev.cocci warnings
@ 2021-06-07 12:26 YueHaibing
  2021-06-20  5:25 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2021-06-07 12:26 UTC (permalink / raw)
  To: dmitry.torokhov, bleung, enric.balletbo, groeck, philipchen
  Cc: linux-input, linux-kernel, YueHaibing

Use kobj_to_dev() instead of container_of()

Generated by: scripts/coccinelle/api/kobj_to_dev.cocci

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/input/keyboard/cros_ec_keyb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
index 38457d9641bd..fc02c540636e 100644
--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -644,7 +644,7 @@ static umode_t cros_ec_keyb_attr_is_visible(struct kobject *kobj,
 					    struct attribute *attr,
 					    int n)
 {
-	struct device *dev = container_of(kobj, struct device, kobj);
+	struct device *dev = kobj_to_dev(kobj);
 	struct cros_ec_keyb *ckdev = dev_get_drvdata(dev);
 
 	if (attr == &dev_attr_function_row_physmap.attr &&
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] Input: cros_ec_keyb - Fix kobj_to_dev.cocci warnings
  2021-06-07 12:26 [PATCH -next] Input: cros_ec_keyb - Fix kobj_to_dev.cocci warnings YueHaibing
@ 2021-06-20  5:25 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2021-06-20  5:25 UTC (permalink / raw)
  To: YueHaibing
  Cc: bleung, enric.balletbo, groeck, philipchen, linux-input, linux-kernel

On Mon, Jun 07, 2021 at 08:26:16PM +0800, YueHaibing wrote:
> Use kobj_to_dev() instead of container_of()
> 
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci

Ended up picking another incarnation of this same patch, sorry.

> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/input/keyboard/cros_ec_keyb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 38457d9641bd..fc02c540636e 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -644,7 +644,7 @@ static umode_t cros_ec_keyb_attr_is_visible(struct kobject *kobj,
>  					    struct attribute *attr,
>  					    int n)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct cros_ec_keyb *ckdev = dev_get_drvdata(dev);
>  
>  	if (attr == &dev_attr_function_row_physmap.attr &&
> -- 
> 2.17.1
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-20  5:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07 12:26 [PATCH -next] Input: cros_ec_keyb - Fix kobj_to_dev.cocci warnings YueHaibing
2021-06-20  5:25 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).