From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: nick@shmanahar.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: atmel_mxt_ts: Add wake-up support
Date: Wed, 23 Jun 2021 17:41:50 -0700 [thread overview]
Message-ID: <YNPUzjrJaJEnR7vo@google.com> (raw)
In-Reply-To: <1624456597-9486-1-git-send-email-loic.poulain@linaro.org>
Hi Loic,
On Wed, Jun 23, 2021 at 03:56:36PM +0200, Loic Poulain wrote:
> Add capability for the touchscreen to wakeup the host on touch event.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index 05de92c..807f449 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -3223,6 +3223,8 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id)
> return error;
> }
>
> + device_set_wakeup_capable(&client->dev, true);
We do not want to make the touch controller be wakeup source
unconditionally. I2C core recognized "wakeup-source" in device tree,
other platforms may employ different techniques setting I2C_CLIENT_WAKE
when registering I2C devices to mark them as wakeup capable/enabled.
> +
> error = regulator_bulk_enable(ARRAY_SIZE(data->regulators),
> data->regulators);
> if (error) {
> @@ -3309,8 +3311,12 @@ static int __maybe_unused mxt_suspend(struct device *dev)
>
> mutex_lock(&input_dev->mutex);
>
> - if (input_device_enabled(input_dev))
> - mxt_stop(data);
> + if (input_device_enabled(input_dev)) {
> + if (device_may_wakeup(dev))
> + enable_irq_wake(data->irq);
For devices that are registered as I2C_CLIENT_WAKE i2c core ensures that
their interrupts are configured for wakeup when system transitions to
sleep state, so you do not need to call enable_irq_wake() and
disable_irq_wake().
You also need to make sure the controller is powered up when it is
configured for wakeup.
> + else
> + mxt_stop(data);
> + }
>
> mutex_unlock(&input_dev->mutex);
>
> @@ -3332,8 +3338,12 @@ static int __maybe_unused mxt_resume(struct device *dev)
>
> mutex_lock(&input_dev->mutex);
>
> - if (input_device_enabled(input_dev))
> - mxt_start(data);
> + if (input_device_enabled(input_dev)) {
> + if (device_may_wakeup(dev))
> + disable_irq_wake(data->irq);
> + else
> + mxt_start(data);
> + }
>
> mutex_unlock(&input_dev->mutex);
>
> --
> 2.7.4
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-06-24 0:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 13:56 [PATCH 1/2] Input: atmel_mxt_ts: Add wake-up support Loic Poulain
2021-06-23 13:56 ` [PATCH 2/2] Input: atmel_mxt_ts: atmel_mxt_ts: Fix event loss Loic Poulain
2021-06-24 0:48 ` Dmitry Torokhov
2021-06-24 5:57 ` Peter Hutterer
2021-06-24 8:05 ` Loic Poulain
2021-06-24 0:41 ` Dmitry Torokhov [this message]
2021-06-24 7:56 ` [PATCH 1/2] Input: atmel_mxt_ts: Add wake-up support Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNPUzjrJaJEnR7vo@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).