From: Wolfram Sang <wsa@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: jic23@kernel.org, gupt21@gmail.com, linux-input@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 1/5] i2c: muxes: ltc4306: fix future recursive dependencies
Date: Tue, 27 Sep 2022 21:36:54 +0200 [thread overview]
Message-ID: <YzNQ1j30uoVvpkoF@shikoro> (raw)
In-Reply-To: <20220911014048.64235-2-matt.ranostay@konsulko.com>
[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]
On Sat, Sep 10, 2022 at 06:40:44PM -0700, Matt Ranostay wrote:
> When using 'imply IIO' for other configurations which have 'select GPIOLIB'
> the following recursive dependency detected happens for I2C_MUX_LTC4306
>
> Switch from 'select GPIOLIB' to 'depends on GPIOLIB' to avoid this per
> recommendation in kconfig-language.rst
>
> drivers/gpio/Kconfig:14:error: recursive dependency detected!
> drivers/gpio/Kconfig:14: symbol GPIOLIB is selected by I2C_MUX_LTC4306
> drivers/i2c/muxes/Kconfig:47: symbol I2C_MUX_LTC4306 depends on I2C_MUX
> drivers/i2c/Kconfig:62: symbol I2C_MUX is selected by MPU3050_I2C
> drivers/iio/gyro/Kconfig:127: symbol MPU3050_I2C depends on IIO
> drivers/iio/Kconfig:6: symbol IIO is implied by HID_MCP2221
> drivers/hid/Kconfig:1227: symbol HID_MCP2221 depends on GPIOLIB
>
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
The I2C mux maintainer is not on CC. get_maintainer.pl would have
mentioned him.
> ---
> drivers/i2c/muxes/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig
> index ea838dbae32e..7b6a68df4a39 100644
> --- a/drivers/i2c/muxes/Kconfig
> +++ b/drivers/i2c/muxes/Kconfig
> @@ -46,7 +46,7 @@ config I2C_MUX_GPMUX
>
> config I2C_MUX_LTC4306
> tristate "LTC LTC4306/5 I2C multiplexer"
> - select GPIOLIB
> + depends on GPIOLIB
> select REGMAP_I2C
> help
> If you say yes here you get support for the Analog Devices
> --
> 2.37.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-27 19:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 1:40 [PATCH v2 0/5] HID: mcp2221: iio support and device resource management Matt Ranostay
2022-09-11 1:40 ` [PATCH v2 1/5] i2c: muxes: ltc4306: fix future recursive dependencies Matt Ranostay
2022-09-27 19:36 ` Wolfram Sang [this message]
2022-09-11 1:40 ` [PATCH v2 2/5] iio: addac: stx104: " Matt Ranostay
2022-09-11 1:40 ` [PATCH v2 3/5] iio: dac: " Matt Ranostay
2022-09-11 1:40 ` [PATCH v2 4/5] HID: mcp2221: switch i2c registration to devm functions Matt Ranostay
2022-09-11 1:40 ` [PATCH v2 5/5] HID: mcp2221: add ADC/DAC support via iio subsystem Matt Ranostay
2022-09-12 14:43 ` [PATCH v2 0/5] HID: mcp2221: iio support and device resource management Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzNQ1j30uoVvpkoF@shikoro \
--to=wsa@kernel.org \
--cc=gupt21@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).