Re: 2.6.29rc1 breakes usb: hiddev device no longer available

Re: 2.6.29rc1 breakes usb: hiddev device no longer available

[Oliver Neukum]

Am Monday 26 January 2009 19:27:07 schrieb Folkert van Heusden:
> > Since version 2.6.29rc1 querying cleware USb devices no longer works.
> > 2.6.28 works fine. 2.6.29-rc2 also no longer works.
> 

> the is the FAILURE situation (2.6.29-rc*):
> open("/dev/usb/hiddev0", O_RDWR)        = 3
> ioctl(3, HIDIOCGDEVINFO, 0xbf90c0d8)    = 0
> ioctl(3, HIDIOCAPPLICATION, 0)          = -6291455
> ioctl(3, HIDIOCGSTRING, 0x804e2c0)      = -1 ENODEV (No such device)

Please try this patch.

	Regards
		Oliver

--

--- linux-2.6/drivers/hid/usbhid/hiddev.c.alt	2009-01-26 20:03:10.000000000 +0100
+++ linux-2.6/drivers/hid/usbhid/hiddev.c	2009-01-26 20:03:17.000000000 +0100
@@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *fi
 
 	case HIDIOCGSTRING:
 		mutex_lock(&hiddev->existancelock);
-		if (!hiddev->exist)
+		if (hiddev->exist)
 			r = hiddev_ioctl_string(hiddev, cmd, user_arg);
 		else
 			r = -ENODEV;

Re: 2.6.29rc1 breakes usb: hiddev device no longer available

[Folkert van Heusden]

> > > Since version 2.6.29rc1 querying cleware USb devices no longer works.
> > > 2.6.28 works fine. 2.6.29-rc2 also no longer works.
> > 
> 
> > the is the FAILURE situation (2.6.29-rc*):
> > open("/dev/usb/hiddev0", O_RDWR)        = 3
> > ioctl(3, HIDIOCGDEVINFO, 0xbf90c0d8)    = 0
> > ioctl(3, HIDIOCAPPLICATION, 0)          = -6291455
> > ioctl(3, HIDIOCGSTRING, 0x804e2c0)      = -1 ENODEV (No such device)
> Please try this patch.

Yes, that fixes it! Thanks!


Ack-by: folkert@vanheusden.com

> --- linux-2.6/drivers/hid/usbhid/hiddev.c.alt	2009-01-26 20:03:10.000000000 +0100
> +++ linux-2.6/drivers/hid/usbhid/hiddev.c	2009-01-26 20:03:17.000000000 +0100
> @@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *fi
>  
>  	case HIDIOCGSTRING:
>  		mutex_lock(&hiddev->existancelock);
> -		if (!hiddev->exist)
> +		if (hiddev->exist)
>  			r = hiddev_ioctl_string(hiddev, cmd, user_arg);
>  		else
>  			r = -ENODEV;


Folkert van Heusden

-- 
MultiTail è uno flexible tool per seguire di logfiles e effettuazione
di commissioni. Feltrare, provedere da colore, merge, 'diff-view',
etc. http://www.vanheusden.com/multitail/
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 2.6.29rc1 breakes usb: hiddev device no longer available

[Jiri Kosina]

On Tue, 27 Jan 2009, Folkert van Heusden wrote:

> > > > Since version 2.6.29rc1 querying cleware USb devices no longer works.
> > > > 2.6.28 works fine. 2.6.29-rc2 also no longer works.
> > > the is the FAILURE situation (2.6.29-rc*):
> > > open("/dev/usb/hiddev0", O_RDWR)        = 3
> > > ioctl(3, HIDIOCGDEVINFO, 0xbf90c0d8)    = 0
> > > ioctl(3, HIDIOCAPPLICATION, 0)          = -6291455
> > > ioctl(3, HIDIOCGSTRING, 0x804e2c0)      = -1 ENODEV (No such device)
> > Please try this patch.
> Yes, that fixes it! Thanks!

Fixed in Linus' tree now. Thanks,

-- 
Jiri Kosina
SUSE Labs