* [PATCH] Add support for Logitech G923 Xbox Edition steering wheel in hid-logitech-hidpp. We get the same level of features as the regular G920. @ 2023-02-07 19:50 Walt Holman 2023-02-09 14:10 ` Benjamin Tissoires 2023-02-09 14:34 ` Benjamin Tissoires 0 siblings, 2 replies; 4+ messages in thread From: Walt Holman @ 2023-02-07 19:50 UTC (permalink / raw) To: linux-input, linux-kernel; +Cc: benjamin.tissoires, Walt Holman --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-logitech-hidpp.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 0f8c11842a3a..de1f385b0ecc 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -819,6 +819,7 @@ #define USB_DEVICE_ID_LOGITECH_G510_USB_AUDIO 0xc22e #define USB_DEVICE_ID_LOGITECH_G29_WHEEL 0xc24f #define USB_DEVICE_ID_LOGITECH_G920_WHEEL 0xc262 +#define USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL 0xc26e #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D 0xc283 #define USB_DEVICE_ID_LOGITECH_FORCE3D_PRO 0xc286 #define USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940 0xc287 diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index abf2c95e4d0b..4dc833c8a44c 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -4347,6 +4347,9 @@ static const struct hid_device_id hidpp_devices[] = { { /* Logitech G920 Wheel over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL), .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS}, + { /* Logitech G923 Wheel (Xbox version) over USB */ + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL), + .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS }, { /* Logitech G Pro Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, -- 2.37.2 --signed-of-by: Walt Holman (waltholman09@gmail.com) ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Add support for Logitech G923 Xbox Edition steering wheel in hid-logitech-hidpp. We get the same level of features as the regular G920. 2023-02-07 19:50 [PATCH] Add support for Logitech G923 Xbox Edition steering wheel in hid-logitech-hidpp. We get the same level of features as the regular G920 Walt Holman @ 2023-02-09 14:10 ` Benjamin Tissoires 2023-02-09 14:29 ` Walt Holman 2023-02-09 14:34 ` Benjamin Tissoires 1 sibling, 1 reply; 4+ messages in thread From: Benjamin Tissoires @ 2023-02-09 14:10 UTC (permalink / raw) To: Walt Holman; +Cc: linux-input, linux-kernel Hi Walt, we are almost there. I have applied the following to your patch (and will push upstream as soon as the CI says it's fine): * subject must start with the subsystem: "HID: " in our case * in your commit description, you should add a blanck line between the title of the commit and the description. Otherwise, git-format-patch considers everything to be the title, which is a little bit long :) * the Signed-of-by line should be added in the commit description, so right here, before the first '---' so that it gets included in the commit itself * for future submissions, please try to keep them numbered. Here, it should have been '[PATCH v2] HID: ...' and below the first '---' add what changed between v1 and v2. Again, I have fixed everything, so no need to send another version :) Cheers, Benjamin On Feb 07 2023, Walt Holman wrote: > --- > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-logitech-hidpp.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index 0f8c11842a3a..de1f385b0ecc 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -819,6 +819,7 @@ > #define USB_DEVICE_ID_LOGITECH_G510_USB_AUDIO 0xc22e > #define USB_DEVICE_ID_LOGITECH_G29_WHEEL 0xc24f > #define USB_DEVICE_ID_LOGITECH_G920_WHEEL 0xc262 > +#define USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL 0xc26e > #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D 0xc283 > #define USB_DEVICE_ID_LOGITECH_FORCE3D_PRO 0xc286 > #define USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940 0xc287 > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index abf2c95e4d0b..4dc833c8a44c 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4347,6 +4347,9 @@ static const struct hid_device_id hidpp_devices[] = { > { /* Logitech G920 Wheel over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL), > .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS}, > + { /* Logitech G923 Wheel (Xbox version) over USB */ > + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL), > + .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS }, > { /* Logitech G Pro Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, > > -- > 2.37.2 > > --signed-of-by: Walt Holman (waltholman09@gmail.com) > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add support for Logitech G923 Xbox Edition steering wheel in hid-logitech-hidpp. We get the same level of features as the regular G920. 2023-02-09 14:10 ` Benjamin Tissoires @ 2023-02-09 14:29 ` Walt Holman 0 siblings, 0 replies; 4+ messages in thread From: Walt Holman @ 2023-02-09 14:29 UTC (permalink / raw) To: Benjamin Tissoires; +Cc: linux-input, linux-kernel On 2/9/23 08:10, Benjamin Tissoires wrote: > Hi Walt, we are almost there. I have applied the following to your patch > (and will push upstream as soon as the CI says it's fine): > > * subject must start with the subsystem: "HID: " in our case > * in your commit description, you should add a blanck line between the > title of the commit and the description. Otherwise, git-format-patch > considers everything to be the title, which is a little bit long :) > * the Signed-of-by line should be added in the commit description, so > right here, before the first '---' so that it gets included in the > commit itself > * for future submissions, please try to keep them numbered. Here, it > should have been '[PATCH v2] HID: ...' and below the first '---' add > what changed between v1 and v2. > > Again, I have fixed everything, so no need to send another version :) > > Cheers, > Benjamin > Thanks Benjamin! I (obviously) don't submit often, but I'll try to keep these things in mind going forward. Thanks for helping to get this done! -Walt > On Feb 07 2023, Walt Holman wrote: >> --- >> drivers/hid/hid-ids.h | 1 + >> drivers/hid/hid-logitech-hidpp.c | 3 +++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h >> index 0f8c11842a3a..de1f385b0ecc 100644 >> --- a/drivers/hid/hid-ids.h >> +++ b/drivers/hid/hid-ids.h >> @@ -819,6 +819,7 @@ >> #define USB_DEVICE_ID_LOGITECH_G510_USB_AUDIO 0xc22e >> #define USB_DEVICE_ID_LOGITECH_G29_WHEEL 0xc24f >> #define USB_DEVICE_ID_LOGITECH_G920_WHEEL 0xc262 >> +#define USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL 0xc26e >> #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D 0xc283 >> #define USB_DEVICE_ID_LOGITECH_FORCE3D_PRO 0xc286 >> #define USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940 0xc287 >> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c >> index abf2c95e4d0b..4dc833c8a44c 100644 >> --- a/drivers/hid/hid-logitech-hidpp.c >> +++ b/drivers/hid/hid-logitech-hidpp.c >> @@ -4347,6 +4347,9 @@ static const struct hid_device_id hidpp_devices[] = { >> { /* Logitech G920 Wheel over USB */ >> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL), >> .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS}, >> + { /* Logitech G923 Wheel (Xbox version) over USB */ >> + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL), >> + .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS }, >> { /* Logitech G Pro Gaming Mouse over USB */ >> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, >> >> -- >> 2.37.2 >> >> --signed-of-by: Walt Holman (waltholman09@gmail.com) >> > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add support for Logitech G923 Xbox Edition steering wheel in hid-logitech-hidpp. We get the same level of features as the regular G920. 2023-02-07 19:50 [PATCH] Add support for Logitech G923 Xbox Edition steering wheel in hid-logitech-hidpp. We get the same level of features as the regular G920 Walt Holman 2023-02-09 14:10 ` Benjamin Tissoires @ 2023-02-09 14:34 ` Benjamin Tissoires 1 sibling, 0 replies; 4+ messages in thread From: Benjamin Tissoires @ 2023-02-09 14:34 UTC (permalink / raw) To: linux-input, linux-kernel, Walt Holman On Tue, 07 Feb 2023 13:50:52 -0600, Walt Holman wrote: > Applied to hid/hid.git (for-6.3/logitech), thanks! [1/1] Add support for Logitech G923 Xbox Edition steering wheel in hid-logitech-hidpp. We get the same level of features as the regular G920. https://git.kernel.org/hid/hid/c/f1fc9fbc8394 Cheers, -- Benjamin Tissoires <benjamin.tissoires@redhat.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-09 14:35 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-02-07 19:50 [PATCH] Add support for Logitech G923 Xbox Edition steering wheel in hid-logitech-hidpp. We get the same level of features as the regular G920 Walt Holman 2023-02-09 14:10 ` Benjamin Tissoires 2023-02-09 14:29 ` Walt Holman 2023-02-09 14:34 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).