[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

commit 31cec413e534520111716802833675f53ac99b0b
Author: Eric Miao <eric.y.miao@gmail.com>
Date:   Thu Feb 4 16:41:28 2010 -0800

    input: schedule corgi_ssp and corgi_ts to be removed

    Cc: Richard Purdie <rpurdie@rpsys.net>
    Signed-off-by: Eric Miao <eric.y.miao@gmail.com>

diff --git a/Documentation/feature-removal-schedule.txt
b/Documentation/feature-removal-schedule.txt
index 5860583..e16529e 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix
keyboard driver that
 	and so are difficult to maintain.
 Who:	Eric Miao <eric.y.miao@gmail.com>

+----------------------------
+
+What:	corgi_ssp and corgi_ts driver
+When:	2.6.35
+Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
+Why:	The corgi touchscreen is now deprecated in favour of the generic
+	ads7846.c driver. The noise reduction technique used in corgi_ts.c
+	that to wait til vsync before ADC sampling is also inte grated into
+	ads7846 driver now. Provided that the original driver is no generic
+	and difficult to maintain, will be removed later.
+Who:	Eric Miao <eric.y.miao@gmail.com>
+

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Uwe Kleine-König]

Hi Eric,

> diff --git a/Documentation/feature-removal-schedule.txt
> b/Documentation/feature-removal-schedule.txt
> index 5860583..e16529e 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix
> keyboard driver that
>  	and so are difficult to maintain.
>  Who:	Eric Miao <eric.y.miao@gmail.com>
> 
> +----------------------------
> +
> +What:	corgi_ssp and corgi_ts driver
> +When:	2.6.35
> +Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
> +Why:	The corgi touchscreen is now deprecated in favour of the generic
> +	ads7846.c driver. The noise reduction technique used in corgi_ts.c
> +	that to wait til vsync before ADC sampling is also inte grated into
> +	ads7846 driver now. Provided that the original driver is no generic
s/no /not / or s/is no/isn't/

Best regards
Uwe

> +	and difficult to maintain, will be removed later.
> +Who:	Eric Miao <eric.y.miao@gmail.com>
> +

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Sergei Shtylyov]

Hello.

Eric Miao wrote:

> commit 31cec413e534520111716802833675f53ac99b0b
> Author: Eric Miao <eric.y.miao@gmail.com>
> Date:   Thu Feb 4 16:41:28 2010 -0800
>
>     input: schedule corgi_ssp and corgi_ts to be removed
>
>     Cc: Richard Purdie <rpurdie@rpsys.net>
>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>   

   Some grammar nitpicking...

> diff --git a/Documentation/feature-removal-schedule.txt
> b/Documentation/feature-removal-schedule.txt
> index 5860583..e16529e 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix
> keyboard driver that
>  	and so are difficult to maintain.
>  Who:	Eric Miao <eric.y.miao@gmail.com>
>
> +----------------------------
> +
> +What:	corgi_ssp and corgi_ts driver
> +When:	2.6.35
> +Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
> +Why:	The corgi touchscreen is now deprecated in favour of the generic
> +	ads7846.c driver. The noise reduction technique used in corgi_ts.c
> +	that to wait til vsync before ADC sampling is also

   that's?


>  inte grated into
>   

    integrated.

> +	ads7846 driver now. Provided that the original driver is no generic
>   

   not generic

> +	and difficult to maintain, will be removed later.
>   

   it will.

> +Who:	Eric Miao <eric.y.miao@gmail.com>
> +
>   

WBR, Sergei

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

>>
>
>  Some grammar nitpicking...
>

Grrr.... anyone has a good recommendation of English training institute
for me? :-)

Patch updated as below:

From 31cec413e534520111716802833675f53ac99b0b Mon Sep 17 00:00:00 2001
From: Eric Miao <eric.y.miao@gmail.com>
Date: Thu, 4 Feb 2010 16:41:28 -0800
Subject: [PATCH 13/13] input: schedule corgi_ssp and corgi_ts to be removed

Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
---
 Documentation/feature-removal-schedule.txt |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt
b/Documentation/feature-removal-schedule.txt
index 5860583..e16529e 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix
keyboard driver that
 	and so are difficult to maintain.
 Who:	Eric Miao <eric.y.miao@gmail.com>

+----------------------------
+
+What:	corgi_ssp and corgi_ts driver
+When:	2.6.35
+Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
+Why:	The corgi touchscreen is now deprecated in favour of the generic
+	ads7846.c driver. The noise reduction technique used in corgi_ts.c
+	that's to wait til vsync before ADC sampling is also integrated into
+	ads7846 driver now. Provided that the original driver is not generic
+	and difficult to maintain, it will be removed later.
+Who:	Eric Miao <eric.y.miao@gmail.com>
+
-- 
1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Richard Purdie]

On Fri, 2010-02-05 at 03:04 -0800, Eric Miao wrote:
> From 31cec413e534520111716802833675f53ac99b0b Mon Sep 17 00:00:00 2001
> From: Eric Miao <eric.y.miao@gmail.com>
> Date: Thu, 4 Feb 2010 16:41:28 -0800
> Subject: [PATCH 13/13] input: schedule corgi_ssp and corgi_ts to be removed
> 
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>

Acked-by: Richard Purdie <rpurdie@rpsys.net>

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Pavel Machek]

On Thu 2010-02-04 16:45:41, Eric Miao wrote:
> commit 31cec413e534520111716802833675f53ac99b0b
> Author: Eric Miao <eric.y.miao@gmail.com>
> Date:   Thu Feb 4 16:41:28 2010 -0800
> 
>     input: schedule corgi_ssp and corgi_ts to be removed
> 
>     Cc: Richard Purdie <rpurdie@rpsys.net>
>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>

ACK.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
> On Thu 2010-02-04 16:45:41, Eric Miao wrote:
>> commit 31cec413e534520111716802833675f53ac99b0b
>> Author: Eric Miao <eric.y.miao@gmail.com>
>> Date:   Thu Feb 4 16:41:28 2010 -0800
>>
>>     input: schedule corgi_ssp and corgi_ts to be removed
>>
>>     Cc: Richard Purdie <rpurdie@rpsys.net>
>>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>
> ACK.
>

Thanks, guys.

Dmitry, I'm hoping these two patches will go through your tree please?
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Dmitry Torokhov]

On Tue, Feb 09, 2010 at 09:15:38AM +0800, Eric Miao wrote:
> On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
> > On Thu 2010-02-04 16:45:41, Eric Miao wrote:
> >> commit 31cec413e534520111716802833675f53ac99b0b
> >> Author: Eric Miao <eric.y.miao@gmail.com>
> >> Date:   Thu Feb 4 16:41:28 2010 -0800
> >>
> >>     input: schedule corgi_ssp and corgi_ts to be removed
> >>
> >>     Cc: Richard Purdie <rpurdie@rpsys.net>
> >>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> >
> > ACK.
> >
> 
> Thanks, guys.
> 
> Dmitry, I'm hoping these two patches will go through your tree please?

I have it in next, do you want it in .33 instead?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

On Tue, Feb 9, 2010 at 5:09 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tue, Feb 09, 2010 at 09:15:38AM +0800, Eric Miao wrote:
>> On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
>> > On Thu 2010-02-04 16:45:41, Eric Miao wrote:
>> >> commit 31cec413e534520111716802833675f53ac99b0b
>> >> Author: Eric Miao <eric.y.miao@gmail.com>
>> >> Date:   Thu Feb 4 16:41:28 2010 -0800
>> >>
>> >>     input: schedule corgi_ssp and corgi_ts to be removed
>> >>
>> >>     Cc: Richard Purdie <rpurdie@rpsys.net>
>> >>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>> >
>> > ACK.
>> >
>>
>> Thanks, guys.
>>
>> Dmitry, I'm hoping these two patches will go through your tree please?
>
> I have it in next, do you want it in .33 instead?
>

No. -next is good, thanks man.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On Tue, Feb 9, 2010 at 8:23 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
> On Tue, Feb 9, 2010 at 5:09 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>> On Tue, Feb 09, 2010 at 09:15:38AM +0800, Eric Miao wrote:
>>> On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
>>> > On Thu 2010-02-04 16:45:41, Eric Miao wrote:
>>> >> commit 31cec413e534520111716802833675f53ac99b0b
>>> >> Author: Eric Miao <eric.y.miao@gmail.com>
>>> >> Date:   Thu Feb 4 16:41:28 2010 -0800
>>> >>
>>> >>     input: schedule corgi_ssp and corgi_ts to be removed
>>> >>
>>> >>     Cc: Richard Purdie <rpurdie@rpsys.net>
>>> >>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>>> >
>>> > ACK.
>>> >
>>>
>>> Thanks, guys.
>>>
>>> Dmitry, I'm hoping these two patches will go through your tree please?
>>
>> I have it in next, do you want it in .33 instead?
>>
>
> No. -next is good, thanks man.
>

Dmitry,

Attached are the two patches updated, with Pavel's suggestion to make them
default to 'n' and with their Acks. Please consider re-apply, sorry for the
bother.

[-- Attachment #2: 0001-input-mark-corgi-spitz-tosa-kbd-driver-deprecated.patch --]
[-- Type: text/x-patch, Size: 3425 bytes --]

From e7a31dab10f1e0a6332af2a856b706f093249c94 Mon Sep 17 00:00:00 2001
From: Eric Miao <eric.y.miao@gmail.com>
Date: Thu, 4 Feb 2010 16:25:19 -0800
Subject: [PATCH 1/2] input: mark {corgi,spitz,tosa}kbd driver deprecated

Provided that now keyboards on these devices are now fully supported
by generic GPIO based matrix keypad driver, mark these hardcoded, and
difficult to maintain drivers deprecated in favour of this.

Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
---
 Documentation/feature-removal-schedule.txt |   12 ++++++++++++
 drivers/input/keyboard/Kconfig             |   21 +++++++++++++++------
 2 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 0a46833..5860583 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -542,3 +542,15 @@ Why:	Duplicate functionality with the gspca_zc3xx driver, zc0301 only
 	sensors) wich are also supported by the gspca_zc3xx driver
 	(which supports 53 USB-ID's in total)
 Who:	Hans de Goede <hdegoede@redhat.com>
+
+----------------------------
+
+What:	corgikbd, spitzkbd, tosakbd driver
+When:	2.6.35
+Files:	drivers/input/keyboard/{corgi,spitz,tosa}kbd.c
+Why:	We now have a generic GPIO based matrix keyboard driver that
+	are fully capable of handling all the keys on these devices.
+	The original drivers manipulate the GPIO registers directly
+	and so are difficult to maintain.
+Who:	Eric Miao <eric.y.miao@gmail.com>
+
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 02c836e..89b4eb0 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -144,13 +144,16 @@ config KEYBOARD_BFIN
 	  module will be called bf54x-keys.
 
 config KEYBOARD_CORGI
-	tristate "Corgi keyboard"
+	tristate "Corgi keyboard (deprecated)"
 	depends on PXA_SHARPSL
-	default y
+	default n
 	help
 	  Say Y here to enable the keyboard on the Sharp Zaurus SL-C7xx
 	  series of PDAs.
 
+	  This driver is now deprecated, use generic GPIO based matrix
+	  keyboard driver instead.
+
 	  To compile this driver as a module, choose M here: the
 	  module will be called corgikbd.
 
@@ -329,13 +332,16 @@ config KEYBOARD_PXA930_ROTARY
 	  module will be called pxa930_rotary.
 
 config KEYBOARD_SPITZ
-	tristate "Spitz keyboard"
+	tristate "Spitz keyboard (deprecated)"
 	depends on PXA_SHARPSL
-	default y
+	default n
 	help
 	  Say Y here to enable the keyboard on the Sharp Zaurus SL-C1000,
 	  SL-C3000 and Sl-C3100 series of PDAs.
 
+	  This driver is now deprecated, use generic GPIO based matrix
+	  keyboard driver instead.
+
 	  To compile this driver as a module, choose M here: the
 	  module will be called spitzkbd.
 
@@ -402,12 +408,15 @@ config KEYBOARD_TWL4030
 	  module will be called twl4030_keypad.
 
 config KEYBOARD_TOSA
-	tristate "Tosa keyboard"
+	tristate "Tosa keyboard (deprecated)"
 	depends on MACH_TOSA
-	default y
+	default n
 	help
 	  Say Y here to enable the keyboard on the Sharp Zaurus SL-6000x (Tosa)
 
+	  This driver is now deprecated, use generic GPIO based matrix
+	  keyboard driver instead.
+
 	  To compile this driver as a module, choose M here: the
 	  module will be called tosakbd.
 
-- 
1.6.3.3


[-- Attachment #3: 0002-input-schedule-corgi_ssp-and-corgi_ts-to-be-removed.patch --]
[-- Type: text/x-patch, Size: 1420 bytes --]

From ab5fd913ef1b2e41c768e670851af6aee6334c20 Mon Sep 17 00:00:00 2001
From: Eric Miao <eric.y.miao@gmail.com>
Date: Thu, 4 Feb 2010 16:41:28 -0800
Subject: [PATCH 2/2] input: schedule corgi_ssp and corgi_ts to be removed

Acked-by: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
---
 Documentation/feature-removal-schedule.txt |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 5860583..3a2367e 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix keyboard driver that
 	and so are difficult to maintain.
 Who:	Eric Miao <eric.y.miao@gmail.com>
 
+----------------------------
+
+What:	corgi_ssp and corgi_ts driver
+When:	2.6.35
+Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
+Why:	The corgi touchscreen is now deprecated in favour of the generic
+	ads7846.c driver. The noise reduction technique used in corgi_ts.c
+	that's to wait til vsync before ADC sampling is also integrated into
+	ads7846 driver now. Provided that the original driver is not generic
+	and difficult to maintain, it will be removed later.
+Who:	Eric Miao <eric.y.miao@gmail.com>
+
-- 
1.6.3.3


[-- Attachment #4: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Dmitry Torokhov]

On Tue, Feb 09, 2010 at 08:33:49PM +0800, Eric Miao wrote:
> On Tue, Feb 9, 2010 at 8:23 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
> > On Tue, Feb 9, 2010 at 5:09 PM, Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> >> On Tue, Feb 09, 2010 at 09:15:38AM +0800, Eric Miao wrote:
> >>> On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
> >>> > On Thu 2010-02-04 16:45:41, Eric Miao wrote:
> >>> >> commit 31cec413e534520111716802833675f53ac99b0b
> >>> >> Author: Eric Miao <eric.y.miao@gmail.com>
> >>> >> Date:   Thu Feb 4 16:41:28 2010 -0800
> >>> >>
> >>> >>     input: schedule corgi_ssp and corgi_ts to be removed
> >>> >>
> >>> >>     Cc: Richard Purdie <rpurdie@rpsys.net>
> >>> >>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> >>> >
> >>> > ACK.
> >>> >
> >>>
> >>> Thanks, guys.
> >>>
> >>> Dmitry, I'm hoping these two patches will go through your tree please?
> >>
> >> I have it in next, do you want it in .33 instead?
> >>
> >
> > No. -next is good, thanks man.
> >
> 
> Dmitry,
> 
> Attached are the two patches updated, with Pavel's suggestion to make them
> default to 'n' and with their Acks. Please consider re-apply, sorry for the
> bother.

Re-applied (with just removing 'default y' instead of replacing with
'default n' which is the same thing).

Thanks.

-- 
Dmitry

Re: [PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

> Re-applied (with just removing 'default y' instead of replacing with
> 'default n' which is the same thing).
>

Ah, yes, that's much cleaner. Thanks Dmitry.