* [PATCH] HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option
@ 2020-05-07 9:53 Hans de Goede
2020-05-07 11:29 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2020-05-07 9:53 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: Hans de Goede, linux-input, kbuild test robot
Since commit 4bc43a421218 ("HID: asus: Add
hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
fix missing symbols errors in hid-asus when USB_HID is not enabled.
Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 7c89edbd6c5a..9e54dd254613 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -149,6 +149,7 @@ config HID_APPLEIR
config HID_ASUS
tristate "Asus"
+ depends on USB_HID
depends on LEDS_CLASS
depends on ASUS_WMI || ASUS_WMI=n
select POWER_SUPPLY
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option
2020-05-07 9:53 [PATCH] HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option Hans de Goede
@ 2020-05-07 11:29 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2020-05-07 11:29 UTC (permalink / raw)
To: Hans de Goede; +Cc: Benjamin Tissoires, linux-input, kbuild test robot
On Thu, 7 May 2020, Hans de Goede wrote:
> Since commit 4bc43a421218 ("HID: asus: Add
> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
> fix missing symbols errors in hid-asus when USB_HID is not enabled.
>
> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied on top of the for-5.8/asus queue. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-07 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 9:53 [PATCH] HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option Hans de Goede
2020-05-07 11:29 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).