linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: logitech-hidpp: Add PID for MX Anywhere 2
@ 2020-10-21 13:56 Harry Cutts
  2020-10-22  7:13 ` Peter Hutterer
  2020-10-22  9:56 ` Jiri Kosina
  0 siblings, 2 replies; 3+ messages in thread
From: Harry Cutts @ 2020-10-21 13:56 UTC (permalink / raw)
  To: LKML
  Cc: Harry Cutts, Benjamin Tissoires, Jiri Kosina, Peter Hutterer,
	linux-input

It seems that the PID 0x4072 was missing from the list Logitech gave me
for this mouse, as I found one with it in the wild (with which I tested
this patch).

Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice")
Signed-off-by: Harry Cutts <hcutts@chromium.org>
---

 drivers/hid/hid-logitech-hidpp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index b8b53dc95e86b..730036650f7df 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -3947,6 +3947,7 @@ static const struct hid_device_id hidpp_devices[] = {
 	  LDJ_DEVICE(0x405e), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
 	{ /* Mouse Logitech MX Anywhere 2 */
 	  LDJ_DEVICE(0x404a), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
+	{ LDJ_DEVICE(0x4072), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
 	{ LDJ_DEVICE(0xb013), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
 	{ LDJ_DEVICE(0xb018), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
 	{ LDJ_DEVICE(0xb01f), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
-- 
2.29.0.rc1.297.gfa9743e501-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] HID: logitech-hidpp: Add PID for MX Anywhere 2
  2020-10-21 13:56 [PATCH] HID: logitech-hidpp: Add PID for MX Anywhere 2 Harry Cutts
@ 2020-10-22  7:13 ` Peter Hutterer
  2020-10-22  9:56 ` Jiri Kosina
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Hutterer @ 2020-10-22  7:13 UTC (permalink / raw)
  To: Harry Cutts; +Cc: LKML, Benjamin Tissoires, Jiri Kosina, linux-input

On Wed, Oct 21, 2020 at 06:56:12AM -0700, Harry Cutts wrote:
> It seems that the PID 0x4072 was missing from the list Logitech gave me
> for this mouse, as I found one with it in the wild (with which I tested
> this patch).
> 
> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice")
> Signed-off-by: Harry Cutts <hcutts@chromium.org>

Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
we have the same PID for this device in libratbag so there must be some
truth to it ;)

Cheers,
   Peter

> ---
> 
>  drivers/hid/hid-logitech-hidpp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index b8b53dc95e86b..730036650f7df 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3947,6 +3947,7 @@ static const struct hid_device_id hidpp_devices[] = {
>  	  LDJ_DEVICE(0x405e), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
>  	{ /* Mouse Logitech MX Anywhere 2 */
>  	  LDJ_DEVICE(0x404a), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
> +	{ LDJ_DEVICE(0x4072), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
>  	{ LDJ_DEVICE(0xb013), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
>  	{ LDJ_DEVICE(0xb018), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
>  	{ LDJ_DEVICE(0xb01f), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
> -- 
> 2.29.0.rc1.297.gfa9743e501-goog
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] HID: logitech-hidpp: Add PID for MX Anywhere 2
  2020-10-21 13:56 [PATCH] HID: logitech-hidpp: Add PID for MX Anywhere 2 Harry Cutts
  2020-10-22  7:13 ` Peter Hutterer
@ 2020-10-22  9:56 ` Jiri Kosina
  1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2020-10-22  9:56 UTC (permalink / raw)
  To: Harry Cutts; +Cc: LKML, Benjamin Tissoires, Peter Hutterer, linux-input

On Wed, 21 Oct 2020, Harry Cutts wrote:

> It seems that the PID 0x4072 was missing from the list Logitech gave me
> for this mouse, as I found one with it in the wild (with which I tested
> this patch).
> 
> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice")
> Signed-off-by: Harry Cutts <hcutts@chromium.org>

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-22  9:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 13:56 [PATCH] HID: logitech-hidpp: Add PID for MX Anywhere 2 Harry Cutts
2020-10-22  7:13 ` Peter Hutterer
2020-10-22  9:56 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).