From: Jiri Kosina <jikos@kernel.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: wacom: Constify attribute_groups
Date: Wed, 25 Nov 2020 14:18:07 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2011251417570.3441@cbobk.fhfr.pm> (raw)
In-Reply-To: <20201124230109.67543-1-rikard.falkeborn@gmail.com>
On Wed, 25 Nov 2020, Rikard Falkeborn wrote:
> These are never modified, so make them const to allow the compiler to put
> them in read-only memory. It also allows the compiler to shrink the
> resulting module with ~900 bytes, test-built with gcc 10.2 on x86_64.
>
> text data bss dec hex filename
> 204377 42832 576 247785 3c7e9 drivers/hid/wacom_old.ko
> 204240 42064 576 246880 3c460 drivers/hid/wacom_new.ko
Applied, thanks Rikard.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2020-11-25 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 23:01 [PATCH] HID: wacom: Constify attribute_groups Rikard Falkeborn
2020-11-25 13:18 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2011251417570.3441@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).