linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro
@ 2019-10-01 23:37 Nayna Jain
  2019-11-14  9:07 ` Michael Ellerman
  0 siblings, 1 reply; 3+ messages in thread
From: Nayna Jain @ 2019-10-01 23:37 UTC (permalink / raw)
  To: linuxppc-dev, linux-efi, linux-integrity
  Cc: linux-kernel, Michael Ellerman, Benjamin Herrenschmidt,
	Paul Mackerras, Ard Biesheuvel, Jeremy Kerr, Matthew Garret,
	Mimi Zohar, Greg Kroah-Hartman, Claudio Carvalho, George Wilson,
	Elaine Palmer, Eric Ricther, Oliver O'Halloran, Nayna Jain

This patch fixes the size and write parameter for the macro
__BIN_ATTR_WO().

Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
---
 include/linux/sysfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 5420817ed317..fa7ee503fb76 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -196,9 +196,9 @@ struct bin_attribute {
 	.size	= _size,						\
 }
 
-#define __BIN_ATTR_WO(_name) {						\
+#define __BIN_ATTR_WO(_name, _size) {					\
 	.attr	= { .name = __stringify(_name), .mode = 0200 },		\
-	.store	= _name##_store,					\
+	.write	= _name##_write,					\
 	.size	= _size,						\
 }
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro
  2019-10-01 23:37 [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro Nayna Jain
@ 2019-11-14  9:07 ` Michael Ellerman
  2019-11-14  9:47   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2019-11-14  9:07 UTC (permalink / raw)
  To: Nayna Jain, linuxppc-dev, linux-efi, linux-integrity
  Cc: Ard Biesheuvel, Eric Ricther, Nayna Jain, linux-kernel,
	Mimi Zohar, Claudio Carvalho, Matthew Garret, Greg Kroah-Hartman,
	Paul Mackerras, Jeremy Kerr, Elaine Palmer,
	Oliver O'Halloran, George Wilson

On Tue, 2019-10-01 at 23:37:18 UTC, Nayna Jain wrote:
> This patch fixes the size and write parameter for the macro
> __BIN_ATTR_WO().
> 
> Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/39a963b457b5c6cbbdc70441c9d496e39d151582

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro
  2019-11-14  9:07 ` Michael Ellerman
@ 2019-11-14  9:47   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-11-14  9:47 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Nayna Jain, linuxppc-dev, linux-efi, linux-integrity,
	Ard Biesheuvel, Eric Ricther, linux-kernel, Mimi Zohar,
	Claudio Carvalho, Matthew Garret, Paul Mackerras, Jeremy Kerr,
	Elaine Palmer, Oliver O'Halloran, George Wilson

On Thu, Nov 14, 2019 at 08:07:49PM +1100, Michael Ellerman wrote:
> On Tue, 2019-10-01 at 23:37:18 UTC, Nayna Jain wrote:
> > This patch fixes the size and write parameter for the macro
> > __BIN_ATTR_WO().
> > 
> > Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
> > Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
> 
> Applied to powerpc next, thanks.
> 
> https://git.kernel.org/powerpc/c/39a963b457b5c6cbbdc70441c9d496e39d151582

Why?  This is already in 5.4-rc5, why do you need/want it again?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-14  9:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 23:37 [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro Nayna Jain
2019-11-14  9:07 ` Michael Ellerman
2019-11-14  9:47   ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).